[Einstein Toolkit] #2119: The binary neutron star gallery example gives different results with the release candiate.

List overview All Threads
Download

newer

older

[Einstein Toolkit] #2173: Test...

[Einstein Toolkit] #2131: Boundary...

Einstein Toolkit

6 Feb 2018 6 Feb '18

10:35 a.m.

#2119: The binary neutron star gallery example gives different results with the release candiate. ---------------------+------------------------------------------------------ Reporter: diener | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Keywords: | ---------------------+------------------------------------------------------ The late part of the waveform plot looks very different in the release candidate than on the gallery page. For l=2, m=2 mode of psi_4 extracted at R=300 (that seems to be the correct data file as otherwise the scale on the y-axis don't match) the merger seem to happen slightly later and the waveform after merger is completely different.

The gallery page plot: [[Image(/home/diener/tmp/mp_Psi4_l2_m2_r300.00.png)]]

The new plot: [[Image(/home/diener/tmp/mp_Psi4_l2_m2_r300.00_new.png)]]

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

6 Feb 6 Feb

10:41 a.m.

#2119: The binary neutron star gallery example gives different results with the release candiate. ----------------------+----------------------------------------------------- Reporter: diener | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: ----------------------+----------------------------------------------------- Description changed by diener:

Old description:

...

The late part of the waveform plot looks very different in the release candidate than on the gallery page. For l=2, m=2 mode of psi_4 extracted at R=300 (that seems to be the correct data file as otherwise the scale on the y-axis don't match) the merger seem to happen slightly later and the waveform after merger is completely different.

The gallery page plot: [[Image(/home/diener/tmp/mp_Psi4_l2_m2_r300.00.png)]]

The new plot: [[Image(/home/diener/tmp/mp_Psi4_l2_m2_r300.00_new.png)]]

New description:

The late part of the waveform plot looks very different in the release candidate than on the gallery page. For l=2, m=2 mode of psi_4 extracted at R=300 (that seems to be the correct data file as otherwise the scale on the y-axis don't match) the merger seem to happen slightly later and the waveform after merger is completely different.

The gallery page plot: [[Image(mp_Psi4_l2_m2_r300.00.png)]]

The new plot: [[Image(mp_Psi4_l2_m2_r300.00_new.png)]]

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:10 a.m.

Comment (by diener):

I will try to add "GRHydro::sources_spatial_order = 4" and see if this fixes this problem as well.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:24 a.m.

Comment (by rhaas):

This may well be the same issue as with the single NS #2118, namely having to set {{{GRHydro::sources_spatial_order = 4}}} since http://einsteintoolkit.org/gallery/bns/nsnstohmns.par does not set it and the default is 2. Admittedly normally a too low order should be more dissipative and should lead to an earlier merger but still, having and order of 2 makes little sense. One would have to go back and check whether at the time the example was created (by me) GRHydro used {{{ADMBase::spatial_order}}} or {{{GRHydro::sources_spatial_order}}}.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7 Feb 7 Feb

8:48 a.m.

Comment (by diener):

With GRHydro::sources_spatial_order = 4 the plot of psi_4 look more similar to the gallery page than before. However,there are still differences after merger as can be seen from this plot: [[Image(mp_Psi4_l2_m2_r300.00_newer.png)]]

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8 Feb 8 Feb

11:56 a.m.

Comment (by roberto.depetri@…):

Quite likely the new run use the c++ code instead of the fortran one (that was the default at that time) and small difference can be present. A better comparison (for the post-merger phase) should be to consider (also) the module of psi_4 instead of just the real part. In the post merger phase there are more than one modes with diffrent constructive-distructive interference) and a small phase differnce on the two-three excited mode may show up. Running the Gallery example on Marconi.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

26 Feb 26 Feb

9:08 a.m.

#2119: The binary neutron star gallery example gives different results with the release candiate. ----------------------+----------------------------------------------------- Reporter: diener | Owner: diener Type: defect | Status: assigned Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: ----------------------+----------------------------------------------------- Changes (by sbrandt):

* owner: => diener * status: new => assigned

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12 Mar 12 Mar

8:37 a.m.

#2119: The binary neutron star gallery example gives different results with the release candiate. ----------------------+----------------------------------------------------- Reporter: diener | Owner: diener Type: defect | Status: assigned Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: ----------------------+-----------------------------------------------------

Comment (by sbrandt):

Peter, what is the status of this ticket?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 May 22 May

1:32 a.m.

#2119: The binary neutron star gallery example gives different results with the release candiate. ---------------------------+--------------------------------- Reporter: Peter Diener | Owner: Peter Diener Type: defect | Status: assigned Priority: blocker | Milestone: ET_2018_02 Component: Other | Version: development version Resolution: | Keywords: ---------------------------+--------------------------------- Changes (by Frank Löffler):

* cc: frank.loeffler@… (added)

Comment:

Putting in my 2 cents, but no solution. I am currently also investigating a difference in our NSNS production runs when we move from the 2016_11 release to the current one. Details are of course different, but the most notable one is also a difference in the post BH-formation GW form, so CCing me here.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

28 May 28 May

9:13 a.m.

Comment (by Steven R. Brandt):

Peter, any progress?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 Aug 22 Aug

10:52 a.m.

* Attachment "dens_compare.png" added.

Plot of maximum of density as function of time

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:53 a.m.

* Attachment "psi4_compare.png" added.

Plot of l=2, m=2 of psi_4 as function of time.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:15 a.m.

Comment (by Peter Diener):

A part of the difference comes from a change to Meudon_Bin_NS to use EOS_Omni in commit: 1b9d6a3eff34224a357a61e3b74d5468f8efa82b. After this change some variables have slightly different profiles on the initial data slice. This affects: hydrobase::press, hydrobase::eps, grhydro::tau and grhydro::scon. The following plot shows the maximum density as function of time for 3 different runs. The red curve is for the original code at the time of the creation of the gallery example. The green curve is for the current development version of the toolkit. The blue curve is for the current development version with Meudon_Bin_NS reverted to the commit before the EOS_Omni commit.

[[Image(dens_compare.png)]]

As can be seen the blue and red curves agrees much better up to the merger, but still some differences appear after that.

The affect on the Psi_4 waveform can be seen here where I have zoomed in to the merger and post-merger phase:

[[Image(psi4_compare.png)]]

Also in this case, the agreement is better between the red and blue curves, but significant differences still appear late in the waveform.

I don't know if Meudon_Bin_NS is more correct before or after the commit mentioned above. And I don't know what then causes the additional differences.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:07 p.m.

Comment (by Roland Haas):

The ticket discussing the change Peter identified is #2039 .

Changes in Meudon_Bin seems quite likely to be capable of changing the initial density, these changes having an effect that only showsup very late (at t=1600) is certainly unexpected and somewhat disturbing.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2119#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

2969

Age (days ago)

3166

Last active (days ago)

trac@lists.einsteintoolkit.org

13 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit