[Einstein Toolkit] #591: Add harmonic shift to McLachlan

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1322:...

[Einstein Toolkit] #1289: Harmonic...

Einstein Toolkit

27 Sep 2011 27 Sep '11

4:25 p.m.

#591: Add harmonic shift to McLachlan -----------------------------------+---------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: McLachlan | -----------------------------------+---------------------------------------- The attached patch adds a harmonic shift condition to McLachlan. It does this by introducing a new real-valued parameter harmonicShift. This should be set to 0 for gamma-driver shift (the default, and the existing behaviour), and to 1 for harmonic shift. This is useful for code- correctness tests with the shifted gauge wave which is an exact solution of the Einstein equations in harmonic gauge. The harmonic shift equation has been tested with the shifted gauge wave exact solution and yields convergence to the exact solution.

The current way that gauge conditions is handled in McLachlan is not very elegant, and I don't think this patch should be applied as-is. I am putting it here for anyone who might find it useful.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

27 Sep 27 Sep

4:56 p.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

#591: Add harmonic shift to McLachlan ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: McLachlan ------------------------------------+---------------------------------------

Comment (by eschnett):

Instead of a real parameter, I suggest an integer parameter, as is done e.g. for the conformal factor. We should also switch the other real parameters to integer.

I suggest to wait until after the release to apply this.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

28 Sep 28 Sep

2:16 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

Comment (by hinder):

It is actually an integer parameter - I was wrong in the original description. Certainly it should not be added until after the release. Even then, do you think it should be applied in its current form? What are your thoughts on splitting gauges into separate calculations? It's probably hard to tell before we have more systematic benchmarks.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:52 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

Comment (by eschnett):

I would not make any argument on performance without measuring it.

I would keep all code combined in a single calculation, because this gives us the greatest flexibility. We know how to split calculations semi- automatically.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

29 Oct 29 Oct

5:13 p.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

Comment (by bmundim):

Hi Ian,

would you mind to apply this patch? I have used it with the shifted gauge wave data and up to a few grid crossing time the solution is good.

Thanks.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

30 Oct 30 Oct

12:35 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

Comment (by hinder):

I have also tested it and am confident that it is correct. I would like to check performance of the gamma-driver shift before applying it. Erik: assuming I don't see a performance problem, is it OK to apply this patch in its current form?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:34 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

Comment (by eschnett):

This patch is ok to apply. Please also commit a test case for the harmonic shift.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

15 Dec 15 Dec

8:56 p.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

#591: Add harmonic shift to McLachlan ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: new => closed * resolution: => fixed

Comment:

I modified this patch to calculate admdtbeta correctly (this also depends on the shift condition), and added a test case for the harmonic shift as well. This is now committed.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 Mar 22 Mar

10:56 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

#591: Add harmonic shift to McLachlan ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2012_11 Resolution: | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by bernard.j.kelly@…):

* priority: minor => major * status: closed => reopened * version: => ET_2012_11 * resolution: fixed => * type: enhancement => defect

Comment:

The harmonicShift currently in the repository assumes that the code is in the "conformalMethod==CMW" branch (that is, using W == exp(-2 phi) in place of the original BSSN " phi"), but does not test for it.

The attached patch (relative to the ET_2012_11 release) corrects this assumption, making a BSSN-phi version available also.

The patch also splits off a particular term, Ddetgt[la] == gtu[uk,ul] PD[gt[lk,ll],la], that should vanish when det(gtil) == 1. By default, it is still calculated explicitly and inserted into the harmonicShift RHS, to pass the test suite.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

15 Apr 15 Apr

9:17 a.m.

New subject: [Einstein Toolkit] #591: Add harmonic shift to McLachlan

#591: Add harmonic shift to McLachlan ------------------------------------+--------------------------------------- Reporter: hinder | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: ET_2012_11 Resolution: fixed | Keywords: McLachlan ------------------------------------+--------------------------------------- Changes (by hinder):

* status: reopened => closed * resolution: => fixed

Comment:

Committed (see #1289 for details).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/591#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4925

Age (days ago)

5491

Last active (days ago)

trac@lists.einsteintoolkit.org

9 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit