#1036: Implement Riemann symmetries in WeylScal4 -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- WeylScal4 calculates 81 instead of 21 (or 20) components of the Riemann tensor. This makes code and run time about four times larger than necessary.
https://github.com/ianhinder/Kranc/issues/81 describes what to do.
#1036: Implement Riemann symmetries in WeylScal4 ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: invalid | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => closed * resolution: => invalid
Comment:
It turns out that the method suggested above does not work, as this applies the symmetries also to the shorthands, leading to zeros and minus signs in the shorthands.
I believe this will require a Kranc modification instead.
#1036: Implement Riemann symmetries in WeylScal4 ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by hinder):
* status: closed => reopened * resolution: invalid =>
Comment:
Kranc has been modified to eliminate the zeroes and minus signs (https://github.com/ianhinder/Kranc/commit/4707e0c3f03cc52d82f88735e602c52cf7...). The attached patch implements the tensor symmetries for R and R4p. I haven't applied any symmetries to Rojo. Resulting code passes tests. OK to apply (with the regenerate)?
#1036: Implement Riemann symmetries in WeylScal4 ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by hinder):
* status: reopened => review
#1036: Implement Riemann symmetries in WeylScal4 ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by barry.wardell):
* status: review => reviewed_ok
Comment:
This looks fine to me. Please apply.
#1036: Implement Riemann symmetries in WeylScal4 ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by hinder):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Thanks. Committed as WeylScal4 r122.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit