[Einstein Toolkit] #916: GetComponents can't update Cactus

List overview All Threads
Download

newer

older

[Einstein Toolkit] #488: Reduce...

[Einstein Toolkit] #708: Cannot...

Einstein Toolkit

21 May 2012 21 May '12

11:15 a.m.

#916: GetComponents can't update Cactus ---------------------------+------------------------------------------------ Reporter: sbrandt | Owner: eric9 Type: defect | Status: new Priority: major | Milestone: Cactus_4.1.0 Component: GetComponents | Version: Keywords: | ---------------------------+------------------------------------------------ Files as simple as !DEFINE ROOT = Cactus !DEFINE ARR = $ROOT/arrangements

# Cactus Flesh !TARGET = $ROOT !TYPE = svn !AUTH_URL = https://svn.cactuscode.org/flesh/trunk !URL = http://svn.cactuscode.org/flesh/trunk !CHECKOUT = Cactus !NAME = .

fail because of trailing whitespace. In particular, all the whitespace on lines following the !NAME line get absorbed so that . becomes .+ws (where ws contains spaces and newlines). This affects the main ET checkout.

Patch: 397a398,400

...

    for my $pairs (@pairs) {
        $pairs =~ s/\s+$//;
    }

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

21 May 21 May

11:23 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: new Priority: critical | Milestone: ET_2012_05 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):

* priority: major => critical * milestone: Cactus_4.1.0 => ET_2012_05

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:24 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: review Priority: critical | Milestone: ET_2012_05 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):

* status: new => review

Comment:

This would remove the ability to have spaces at the end of string - but I think we can live with that. Can please someone else also give his/her ok?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

22 May 22 May

4:02 p.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: review Priority: critical | Milestone: ET_2012_05 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by rhaas):

Ok to apply. I cannot think of a reason why one would want to have a space at the end of a string that is used for a filename or directory name.

The pasted code (or at least what makes it into the html) seems to have a syntax error though. My perl complains unless I use: {{{ for my $pairs (@pairs) { $pairs =~ s/\s+$//; } }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

23 May 23 May

9:19 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: review Priority: critical | Milestone: ET_2012_05 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by sbrandt):

What you have is correct, Roland. It's also what I have. Not sure why copying it and pasting it from my script into Trac produced the syntax error.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

28 May 28 May

10:15 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: review Priority: major | Milestone: ET_2012_11 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by knarf):

* priority: critical => major * milestone: ET_2012_05 => ET_2012_11

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11 Jun 11 Jun

10:32 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2012_11 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+----------------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10 Aug 10 Aug

11:32 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: reviewed_ok Priority: major | Milestone: ET_2012_11 Component: GetComponents | Version: Resolution: | Keywords: ----------------------------+-----------------------------------------------

Comment (by eschnett):

Please apply this.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:49 a.m.

New subject: [Einstein Toolkit] #916: GetComponents can't update Cactus

#916: GetComponents can't update Cactus ----------------------------+----------------------------------------------- Reporter: sbrandt | Owner: eric9 Type: defect | Status: closed Priority: major | Milestone: ET_2012_11 Component: GetComponents | Version: Resolution: fixed | Keywords: ----------------------------+----------------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied as 1f2240d68545bf095563fae518d5783274add0fb of GitHub "remove trailing whitespace from lines"

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/916#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5173

Age (days ago)

5254

Last active (days ago)

trac@lists.einsteintoolkit.org

8 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit