#906: GRHydro: clean-up unused variables ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: review => reviewed_ok

Comment:

The patch applies and compiles and reduces the number of warnings. There are some leftover warnings afterwards that might be cleaned up at the same time: {{{ COMPILING GRHydro/src/GRHydro_Con2PrimM_pt.c GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘grhydro_con2primm_pt_’: GRHydro/src/GRHydro_Con2PrimM_pt.c:214:32: warning: declaration of ‘gamma’ shadows a global declaration [-Wshadow] GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘twod_newton_raphson’: GRHydro/src/GRHydro_Con2PrimM_pt.c:513:13: warning: variable ‘vsq_old’ set but not used [-Wunused-but-set-variable] GRHydro/src/GRHydro_Con2PrimM_pt.c: In function ‘func_vsq’: GRHydro/src/GRHydro_Con2PrimM_pt.c:629:22: warning: variable ‘Wsq’ set but not used [-Wunused-but-set-variable] GRHydro/src/GRHydro_Con2PrimM_pt.c: At top level: GRHydro/src/GRHydro_Con2PrimM_pt.c:479:13: warning: ‘validate_x’ defined but not used [-Wunused-function] COMPILING GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function ‘grhydro_con2primm_polytype_pt_’: GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:209:32: warning: declaration of ‘gamma’ shadows a global declaration [-Wshadow] GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function ‘oned_newton_raphson’: GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:496:13: warning: variable ‘W’ set but not used [-Wunused-but-set-variable] GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:492:27: warning: variable ‘x_old’ set but not used [-Wunused-but-set-variable] GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: In function ‘gnr2’: GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:696:27: warning: variable ‘x_old’ set but not used [-Wunused-but-set-variable] GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c: At top level: GRHydro/src/GRHydro_Con2PrimM_polytype_pt.c:462:13: warning: ‘validate_x’ defined but not used [-Wunused-function] }}}

Otherwise fine to apply.

#906: GRHydro: clean-up unused variables ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: closed Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+---------------------------------------

Comment (by knarf):

x_old is used, but only for debug output, and only if DEBUG_CON2PRIMM is defined (which it probably wasn't for that compilation), so the compiler is in theory right. Maybe we can wrap x0 in #ifdefs for DEBUG_CON2PRIMM.

#906: GRHydro: clean-up unused variables ------------------------------------+--------------------------------------- Reporter: bmundim | Owner: Type: defect | Status: closed Priority: minor | Milestone: ET_2012_05 Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: GRHydro ------------------------------------+---------------------------------------

Comment (by knarf):

You could declare it where it is set, but I believe this would not help with the warning. The variable is already always set at the moment, but it even though it is set, it is never used (only in code which the compiler never sees). So - setting a variable to some value doesn't make it 'being used', because it never has the chance to change the outcome of the function in any way.