[Einstein Toolkit] #1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1223:...

[Einstein Toolkit] #1219: Make...

Einstein Toolkit

23 Sep 2012 23 Sep '12

3:13 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release -----------------------------------+---------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: new Priority: minor | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- Change default of TmunuBase::support_old_CalcTmunu_mechanism to "no", mark it depreciated for the fall 2012 ET release and remove it after that.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

24 Oct 24 Oct

10:21 a.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: ET_2012_11 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:36 a.m.

Comment (by eschnett):

I suggest to do this after the release, because it may break many parameter files.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:06 a.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: ET_2013_05 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* milestone: ET_2012_11 => ET_2013_05

Comment:

Ok, let's deprecate it now and remove it for the next release. Then there is also no reason to change any default.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

13 Jan 13 Jan

7:40 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* milestone: ET_2013_05 =>

Comment:

The default changed now.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:40 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => assigned

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

14 Jan 14 Jan

6:36 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: assigned Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by rhaas):

Admconstraints used the old interface (and is used eg in the TOVSolver tests). I attach a patch to fix admconstraints. We might at the same time also change the default for stress_energy_storage to "yes" since having neither the old nor the new interface available by default is awkward.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6:38 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: assigned => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:40 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by knarf):

I agree with the change to tmunu_storage. The issue with ADMConstraints is the usage of ADMMacros. I do have a patch for that around to make it use the Tmunu grid functions and just need to dig it out if there is interest.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:25 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by rhaas):

ADMConstraints seems to use TmunuBase directly as far as I can tell. I sets up the T[txyz][txyz] variables that ADMMacros apparently relies on. Applying only a patch to admconstraints (new_tmunu_interface.patch above) makes the TOVSolver tests (and all other tests that I could find, once I added TmunuBase to the test parfile see tmunubase_for_admconstraints.patch) pass. Apparently it does not use STRESSENERGY_guts.h which is the file in ADMMacros that uses the old interface.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 Jan 17 Jan

3:06 a.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------

Comment (by hinder):

According to Roland, when this ticket is resolved, the 16 currently- failing ET regression tests (http://build.barrywardell.net:8080/job/EinsteinToolkit/113/testReport/) will pass again. The longer we have failing tests, the more chance there is that another problem will appear and be difficult to disentangle. Can the patch new_tmunu_interface.patch be committed?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:53 a.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => reviewed_ok

Comment:

Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

8:53 a.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by knarf):

* priority: minor => major

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:20 p.m.

#1105: TmunuBase::support_old_CalcTmunu_mechanism to "no" and remove after release ------------------------------------+--------------------------------------- Reporter: knarf | Owner: knarf Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

All applied as rev 154 of ADMConstraints and various other revisions in ADM, DistortedBHIVP, Exact, IDAxiBrillBH, IDAxiOddBrillBH, IDConstraintViolate, RotatingDBHIVP, TwoPunctures, NullInterp.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1105#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

5013

Age (days ago)

5129

Last active (days ago)

trac@lists.einsteintoolkit.org

13 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit