#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod -----------------------+---------------------------------------------------- Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: Keywords: McLachlan | -----------------------+---------------------------------------------------- In ML_BSSN_Helper/src/NewRad.c, the newrad function is called with a background value of 0 for the phi variable, independently of the setting of conformalMethod. For conformalMethod = 1, the background value should be 1.
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: McLachlan ---------------------+------------------------------------------------------
Comment (by hinder):
There is a patch to fix this at http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=38bfec5d987fe20.... I have also written a test case for NewRad (http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=9e1e4c5541f3621...). The thorn name will need to be changed to ML_BSSN in the parameter file and test name if this is applied to master.
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: McLachlan ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: new => review
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Other | Version: Resolution: | Keywords: McLachlan ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Please apply both.
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: ET_2012_05 Component: Other | Version: Resolution: | Keywords: McLachlan ---------------------+------------------------------------------------------ Changes (by eschnett):
* milestone: => ET_2012_05
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: hinder Type: defect | Status: accepted Priority: minor | Milestone: ET_2012_05 Component: Other | Version: Resolution: | Keywords: McLachlan ---------------------+------------------------------------------------------ Changes (by hinder):
* owner: => hinder * status: reviewed_ok => accepted
#848: McLachlan "NewRad" radiative boundary condition does not consider conformalMethod ---------------------+------------------------------------------------------ Reporter: hinder | Owner: hinder Type: defect | Status: closed Priority: minor | Milestone: ET_2012_05 Component: Other | Version: Resolution: fixed | Keywords: McLachlan ---------------------+------------------------------------------------------ Changes (by hinder):
* status: accepted => closed * resolution: => fixed
Comment:
Fix committed in http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=f5fda658d49efce..., test committed in http://www.carpetcode.org/gitweb/?p=McLachlan.git;a=commit;h=ce3b0b3d87ffa53....
trac@lists.einsteintoolkit.org