[Einstein Toolkit] #1359: add "read from file" option ot HydroBase's initial_data options

List overview All Threads
Download

newer

older

[Einstein Toolkit] #1550: Carpet...

[Einstein Toolkit] #1589:...

Einstein Toolkit

11 May 2013 11 May '13

12:34 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: HydroBase | -----------------------------------+---------------------------------------- the attached patch adds a value "read from file" to HydroBase's initial_XXX options. This makes it possible to use IOUtils file reader with hydro data.

This is somewhat similar to IDFileADM's extension of ADMBase's options, only we do not have to set any grid scalars.

Needed to be able to reproduce the MHD paper's collapse test since Whisky_RNSID is not public.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

11 May 11 May

12:43 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: new => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:55 a.m.

Comment (by knarf):

Shouldn't the thorn providing the capability to read data from a file extend these keywords, instead of HydroBase defining them, but not doing anything with them? Imagine what happens when "read_from_file" is specified, but no thorn feels responsible... Also: when a thorn extends it the keyword should be a little more specific than 'read_from_file'. There could be multiple readers.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7:56 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: invalid | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => closed * resolution: => invalid

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:16 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: closed => reopened * resolution: invalid =>

Comment:

The thorn reading the data is IOUtil. It should not know anything about HydroBase or ADMBase.

Currently, it is not possible to use IOUtil's file reader with HydroBase, because HydroBase insists on setting up some kind of initial data, always overwriting what one may have read in with the file reader. This patch prevents this overwriting, allowing the file reader to work.

The file reader API may not be ideal, but it is the standard in Cactus. HydroBase should support it.

The proposed patch is equivalent to what ADMBase does.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:16 a.m.

* status: reopened => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:16 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:23 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+---------------------------------------

Comment (by knarf):

Oh, I didn't think of that. Yes, this is delicate - both thorns don't know of another, but in this case in theory should. Could we add the patch as proposed, but also add a runtime check that looks for an active IOUtils thorn, and checks at least that filereader_ID_vars isn't empty - to avoid both abusing the parameter and accidental usage?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:36 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+---------------------------------------

Comment (by knarf):

Maybe the new keyword could be called IOUtil, so that it's clear where the data is supposed to be coming from.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:37 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+---------------------------------------

Comment (by rhaas):

I took a closer look at IDFileADM to see what extra checking it provides.

The text "read from file" is taken from EinsteinInitial/IDFileADM's parameter initial_shift. That one has some longer text explaining the parameter:

{{{ Read the initial shift using the file reader. Note that this only allows you to read the shift from a file, it does not actually do it. You still have to programme the file reader accordingly. }}}

To avoid users to run with the wrong data, then I wrote a very simple thorn IDFileHydro that extends the parameters and provides some errror checking in ParamCheck the way IDFileADM does. I put the thorn into incoming: https://svn.einsteintoolkit.org/incoming/IDFileHydro/ .

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:59 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+---------------------------------------

Comment (by rhaas):

Come to think of it, one could also simply include the ParamCheck routine in https://svn.einsteintoolkit.org/incoming/IDFileHydro/src/IDFileHydro_ParamCh... (only piece of code) in IDFileHydro in HydroBase which would mean that the "read from file" option is documented in HydroBase and not some obscure helper thorn that people don't know about.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

15 May 15 May

3:50 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied the initial patch as rev 62 and 63 of trunk and ET_2013_05 respectively. Will propose larger patch again after the release.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

16 May 16 May

10:16 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reopened Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: closed => reopened * resolution: fixed =>

Comment:

patch to check consistency of parameters. Also '''adds''' the "read from file" option to initial_hydro where it was missing before.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:12 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:16 p.m.

* status: reopened => review

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:13 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:19 p.m.

Comment (by knarf):

The patch misses the file ParamCheck.c

Also, please include a comment in the parameters that thorn IOUtil is the one a user should look for.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:14 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

10:24 p.m.

Comment (by rhaas):

updated the patch. added "IOUtil" just before "file reader". Ok to apply?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:15 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

17 May 17 May

11:41 a.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by knarf):

* status: review => reviewed_ok

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:16 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

12:41 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: HydroBase ------------------------------------+--------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Applied as rev 64 of trunk and rev 65 of ET_2013_05.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:17 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

25 Apr 25 Apr

2:41 p.m.

#1359: add "read from file" option ot HydroBase's initial_data options ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: HydroBase ------------------------------------+---------------------------------------

Comment (by rhaas):

Fixed a type in the variable name for 'HydroBase::Y_e" in rev 72 of HydroBase.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/1359#comment:18 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

4550

Age (days ago)

4899

Last active (days ago)

trac@lists.einsteintoolkit.org

18 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit