[Einstein Toolkit] #457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: | -------------------------+-------------------------------------------------- the attached patch exposes two new configuration variables (which default to yes): HDF5_ENABLE_CXX and HDF5_ENABLE_FORTRAN setting them to no allows users to avoid building/linking against the respective interfaces to hdf5. This is useful when eg. one does not need them and would like to link against a cluster supplied version of hdf5 (or if one cannot use the Fortran modules due to differing compiler versions). This kind of relates to Ian's original email: http://lists.einsteintoolkit.org/pipermail/users/2011-March/000928.html Although it does not provide any early warning.
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: new => review
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------
Comment (by eschnett):
Approved.
I would put the new code that deals with these new variables into its own section (delimited by #####, as in the script) instead of attaching it to "prepare" and "search", which doesn't quite fit.
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: reopened Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):
* status: closed => reopened * resolution: fixed =>
Comment:
turns out seem to be unable to commit the patch (hdf5_enable_cxx_fortran2.diff above) since the repository lives in cactuscode.org.
#457: let user enable/disable C++ and Fortran support in ExternalLibraries/HDF5 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: rhaas Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):
* status: reopened => closed * resolution: => fixed
Comment:
I have committed the patch - r38.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit