#1423: CarpetIOHDF5 corrupts memory when readingi compressed grid structure strings --------------------+------------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: major | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- Input.cc uses H5Dget_storage_size to determine how much memory to allocate for the large string attributes (Paramters and grid structure). However this function literally returns the space used on disk which differs from the space in memory when compression is used (or when the dataset is sparse, or when the datatype on disk is different from that in memory eg float vs double).
The attached patch instead queries the dataspace for the number of points.
Ok to apply? Is there a preferred way of getting this size othewise?
#1423: CarpetIOHDF5 corrupts memory when readingi compressed grid structure strings ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: review Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: new => review
#1423: CarpetIOHDF5 corrupts memory when readingi compressed grid structure strings ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: reviewed_ok Priority: major | Milestone: Component: Carpet | Version: development version Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved.
#1423: CarpetIOHDF5 corrupts memory when readingi compressed grid structure strings ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: eschnett Type: defect | Status: closed Priority: major | Milestone: Component: Carpet | Version: development version Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as hash fdadb2cfc19a42ada49fc91c12e56646848ca8b9 "CarpetIOHDF5: use simple_extents rather than storage size on disk" of Carpet.
trac@lists.einsteintoolkit.org