[Einstein Toolkit] #2058: Simfactory assumes python is python2

List overview All Threads
Download

newer

older

[Einstein Toolkit] #2071: Correct...

[Einstein Toolkit] #2067: Tov...

Einstein Toolkit

31 Jul 2017 31 Jul '17

10:43 a.m.

#2058: Simfactory assumes python is python2 ------------------------+--------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: unset | Milestone: Component: SimFactory | Version: development version Keywords: | ------------------------+--------------------------------------------------- Simfactory assumes that python is python2. Until recently this seems to have been a valid assumption, but it is no longer so. The "sim" script needs to be updated to check the version of python before invoking any of the simfactory commands.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Show replies by date

Einstein Toolkit

4 Aug 4 Aug

12:11 p.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

#2058: Simfactory assumes python is python2 -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: new Priority: unset | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: newuser -------------------------+-------------------------------------------------- Changes (by hinder):

* keywords: => newuser

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:1 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:30 p.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by sbrandt):

Based on conversations and emails, I think this is what we want.

{{{ diff --git a/bin/sim b/bin/sim index 92f74ab..c6bc075 100755 --- a/bin/sim +++ b/bin/sim @@ -20,4 +20,18 @@ if [ -z "$cmd" ]; then fi

# Forward the call -exec python "$cmd" "$@" +for PYEXE in python python2 +do + $PYEXE - > /dev/null 2>&1 << EOF +import sys +if sys.hexversion < 0x3000000: + exit(0) +else: + exit(1) +EOF + if [ $? = 0 ] + then + exec $PYEXE "$cmd" "$@" + break + fi +done }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:2 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

1:37 p.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by eschnett):

This should check {{{python2}}} first.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:3 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

2:02 p.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by sbrandt):

If I agree to make that change can you put it in review_ok?

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:4 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

6 Aug 6 Aug

3:11 p.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by rhaas):

Since we are version testing, it would also make sense to put in a minimal accepted version (likely python 2.6 or 2.7) I think. The "break" should likely be replaced by an "exit $?" since "exec" can return to its caller (eg if redirection fails, but not if it fails to execute the program).

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:5 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

7 Aug 7 Aug

9:05 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by sbrandt):

I don't want to pick an arbitrary minimum version. If you know of a version for which Simfactory doesn't then I'm all for setting one, otherwise I'd rather not. Using exits make some sense. Anyway, here's what I currently suggest. {{{ # Forward the call for PYEXE in python2 python do $PYEXE - > /dev/null 2>&1 << EOF import sys if sys.hexversion < 0x3000000: exit(0) else: exit(1) EOF if [ $? = 0 ] then exec $PYEXE "$cmd" "$@" exit 1 fi done exit 2 }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:6 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:07 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by eschnett):

Simfactory requires Python 2.3, since that was installed on Queen Bee at the time it was developed, and Queen Bee (at that time) had one of the oldest Red Hat versions. We might have switched to Python 2.6 in the mean time, either accidentally or on purpose, but I'd go with 2.3.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:7 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

9:11 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

Comment (by sbrandt):

OK, then. Version 2.3 corresponds to 0x2030000.

{{{ # Forward the call for PYEXE in python2 python do $PYEXE - > /dev/null 2>&1 << EOF import sys if sys.hexversion >= 0x2030000 and sys.hexversion < 0x3000000: exit(0) else: exit(1) EOF if [ $? = 0 ] then exec $PYEXE "$cmd" "$@" exit 1 fi done exit 2 }}}

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:8 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

14 Aug 14 Aug

11:27 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

#2058: Simfactory assumes python is python2 -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: review Priority: unset | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: newuser -------------------------+-------------------------------------------------- Changes (by rhaas):

* status: new => review

Comment:

Change to review state.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:9 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

11:28 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

#2058: Simfactory assumes python is python2 -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: reviewed_ok Priority: unset | Milestone: Component: SimFactory | Version: development version Resolution: | Keywords: newuser -------------------------+-------------------------------------------------- Changes (by rhaas):

* status: review => reviewed_ok

Comment:

Looks ok. Please apply.

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:10 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

Einstein Toolkit

21 Aug 21 Aug

9:44 a.m.

New subject: [Einstein Toolkit] #2058: Simfactory assumes python is python2

#2058: Simfactory assumes python is python2 -------------------------+-------------------------------------------------- Reporter: sbrandt | Owner: Type: defect | Status: closed Priority: unset | Milestone: Component: SimFactory | Version: development version Resolution: fixed | Keywords: newuser -------------------------+-------------------------------------------------- Changes (by sbrandt):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Fixed in commit 96d3250cc317cceb179b9f4b6f69f9344802a6fd of https://bitbucket.org/simfactory/simfactory2.git

-- Ticket URL: https://trac.einsteintoolkit.org/ticket/2058#comment:11 Einstein Toolkit http://einsteintoolkit.org The Einstein Toolkit

3336

Age (days ago)

3357

Last active (days ago)

trac@lists.einsteintoolkit.org

11 comments

1 participants

tags (0)

participants (1)

Einstein Toolkit