#425: Case sensitivity GSL_DIR=BUILD ----------------------------------------+----------------------------------- Reporter: reisswig@… | Type: enhancement Status: new | Priority: minor Milestone: | Component: Cactus Version: | Keywords: GSL_DIR BUILD ----------------------------------------+----------------------------------- The thorn GSL would not compile if "GSL_DIR=build" in the option list. In order to work, it requires "GSL_DIR=BUILD", i.e. it is really case sensitive although I think, this is not required and should be case insensitive.
Possibly, HDF5_DIR=build may also not work for the same reason (have not checked; should be checked as well).
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: GSL_DIR BUILD -----------------------------------------+---------------------------------- Changes (by eschnett):
* status: new => review
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: GSL_DIR BUILD -----------------------------------------+----------------------------------
Comment (by eschnett):
build3.patch works; ignore the previous two.
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: GSL_DIR BUILD -----------------------------------------+----------------------------------
Comment (by hinder):
(The patch addresses the problem for many thorns in ExternalLibraries other than HDF5, and additionally tidies up some formatting.)
This looks good - please apply.
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: GSL_DIR BUILD -----------------------------------------+---------------------------------- Changes (by knarf):
* cc: reisswig@… (added)
Comment:
Looks good (but please don't mix up changes in patches which are not related to the issue. The changes are all fine, but make reviewing more complicated). Please apply.
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: GSL_DIR BUILD -----------------------------------------+----------------------------------
Comment (by hinder):
Was this patch applied?
#425: Case sensitivity GSL_DIR=BUILD -----------------------------------------+---------------------------------- Reporter: reisswig@… | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: GSL_DIR BUILD -----------------------------------------+---------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Yes.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit