#991: PITTNullCode updates -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: PITTNull code | -----------------------------------+---------------------------------------- These patches contain three types of updates (sorry, I do not have feature separated ones):
* making parameters steerable * respecting the truncate_files Cactus Parameter * a bugfix where points that were interpolated very close to the extraction world tube had very low accuracy due to a hard-coded offset (Nick Taylor and Bela Szilagyi found and fixed this)
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PITTNull code ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PITTNull code ------------------------------------+---------------------------------------
Comment (by anonymous):
NullNews.patch seems to be a patch for NullSHRExtract. It also conflicts with NullSHRExtract.patch
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PITTNull code ------------------------------------+---------------------------------------
Comment (by rhaas):
Are you sure you are looking at the newest patches? There were wrong patches in before but they were corrected today at 9AM. The NullNews one should start as: {{{ Index: param.ccl =================================================================== --- param.ccl (revision 9) +++ param.ccl (working copy) @@ -22,19 +22,19 @@
private:
-BOOLEAN first_order_scheme "should angular derviatives be reduced to first order?" +BOOLEAN first_order_scheme "should angular derviatives be reduced to first order?" STEERABLE=ALWAYS { } "yes" }}}
They are all to be applied in their respective thorn directory it NullNews.patch from within PITTNullCode/NullNews and not from within PITTNullCode.
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PITTNull code ------------------------------------+---------------------------------------
Comment (by anonymous):
It's actually NullVars.patch that seems to be the problem.
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: PITTNull code ------------------------------------+---------------------------------------
Comment (by anonymous):
Please commit these changes. They don't affect the testsuites and Bela found them to be essential for the correctness of the code.
The start-up related change could be logged as
Improve the start-up algorithm of the characteristic marching scheme from the inner boundary towards scri+.
All other changes are related to either improving IO (will correctly truncate/create diagnostic files) or allowing for flexible tuning of IO between checkpoints/restarts (by changing the parameters into steerable ones).
#991: PITTNullCode updates ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: PITTNull code ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Thank you for the review. Yes NullVars was indeed faulty and had not been fixed. My apologies. I have applied all patches as revisions 9 of NullDecomp, 10 of NullEvolve, 10 of NullNews and 10 of NullSHRExtract,
trac@lists.einsteintoolkit.org
-
Einstein Toolkit