#1107: New thorn ML_WaveToy_Test -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- I propose to add a new thorn ML_WaveToy_Test to the Einstein Toolkit. This thorn exists in the McLachlan arrangement and complements the auto- generated McLachlan/ML_WaveToy with test cases.
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
Is there a reason why these tests cannot be implemented for ML_BSSN instead?
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
No, there is no reason, except that maybe scalar waves are easier to debug and faster to run.
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by hinder):
Right, but we are talking about regression tests here, so maybe having a more "complicated" system is more likely to pick up problems. In any case, more tests are always good, so please go ahead! Remember the tests should take only a few seconds and should not take up much disk space or runtime memory.
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => reviewed_ok
Comment:
I agree that test that tests most evolution parts but runs on a workstation (as compared to qc0) is very useful. Please apply (or most likely really just add the thorn to the thornlist).
#1107: New thorn ML_WaveToy_Test ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit