#1084: increase default value of RELTOL to 1e-12 -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Keywords: test system | -------------------------+-------------------------------------------------- right now the defaults for ABSTOL and RELTOL (see lib/sbin/RunTestUtils.pl line 587) are {{{ $runconfig{"ABSTOL"} = 1e-12; $runconfig{"RELTOL"} = 0; }}} in particular RELTOL is set to zero. This means that for values of order 1000 or so ABSTOL requests more significant figures than a double provides.
Instead it would seem to be more sensible to request RELTOL = 1e-12 as well which will leave the accuracy unchanged for values of order unity but make the test system less prone to false alarms for values that are larger (eg sum reductions, values close to the puncture)
#1084: increase default value of RELTOL to 1e-12 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: test system --------------------------+-------------------------------------------------
Comment (by eschnett):
I agree.
#1084: increase default value of RELTOL to 1e-12 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: test system --------------------------+------------------------------------------------- Changes (by eschnett):
* status: new => review
#1084: increase default value of RELTOL to 1e-12 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Cactus | Version: Resolution: | Keywords: test system --------------------------+------------------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
#1084: increase default value of RELTOL to 1e-12 --------------------------+------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: Cactus | Version: Resolution: fixed | Keywords: test system --------------------------+------------------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as rev 4871 of the flesh.
trac@lists.einsteintoolkit.org