#1736: avoid using Fotran compiler to link Riemann1d utility -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: GRHydro | -----------------------------------+---------------------------------------- GRHydro contains a Riemann1d utility which contains a Fotran90 main program. Unfortunately some of the libraries we link against use C++ code and the F90 compiler fails to link the executable (missing vtables, constructors etc). Since the C++ compiler cannot link the main executable either (since it does not know how to start the main Fotran program), the attached patch adds a stub main() function that calls the previous F90 code as a subroutine. Most of the changes are to the build files to make a utility that needs preprocessed C code (for CCTK_FNAME) and contains multiple object files.
Pull request is: https://bitbucket.org/einsteintoolkit/einsteinevolve /pull-request/5/grhydro-add-c-main-function-for-riemann1d/diff though given that this is a single commit I'd much rather have it be applied than to get a merge for a single commit.
#1736: avoid using Fotran compiler to link Riemann1d utility ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: review Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#1736: avoid using Fotran compiler to link Riemann1d utility ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => reviewed_ok
Comment:
Approved.
#1736: avoid using Fortran compiler to link Riemann1d utility ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: GRHydro ------------------------------------+---------------------------------------
#1736: avoid using Fortran compiler to link Riemann1d utility ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: closed Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: GRHydro ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied in EinsteinEvolve hash 0741b3df70e17d4a762df4cd715eafd43c61d7ad .
trac@lists.einsteintoolkit.org