#966: Carpet always calls POSTREGIRD on the finest level --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by eschnett):

It is difficult to judge whether the finest level "changed". For example, if a coarser level changed, then the finest level's prolongation data may change. Internally, Carpet assumes that a regridding operation always changes "level N and all finer levels".

#966: Carpet always calls POSTREGRID on the finest level --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

I see. That certainly makes sense (in particular taking the view of prolongation as a projection into account). In that case, should one change lines 311 in Evolve.cc from {{{ // Do not omit the global mode call when the finest level // does not change: // if (did_recompose or (did_remove_level and rl == reflevels - 1)) { if (did_recompose or ((did_remove_level or did_any_recompose) and rl == reflevels - 1)) }}} to {{{ // Carpet assumes that a regridding operation always changes "level N // and all finer levels" so we should call POSTREGRID on all finer levels if (did_any_recompose) }}} ?

#966: Carpet always calls POSTREGRID on the finest level --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

I should have posted more context I think. This lines are the ones deciding whether to call any routine on this level at all. The GLOBAL-late routines would still execute only on the last level. I had assumed without checking that did_any_recompose would imply did_remove_level which is not true as you point out. The check for did_remove level was clearly missing. So instead how about: {{{ // Carpet assumes that a regridding operation always changes "level N // and all finer levels" so we should call POSTREGRID on all finer levels if (did_any_recompose or (did_remove_level and rl == reflevels - 1)) }}} which should trigger on all levels with rl larger or equal to the first one that was recomposed as well as on the finest one when a level was removed.

This would actually call POSTREGRID more often, since it would enter not only on levels that were recomposed or on the finest one if a level was removed so is not quite in keeping with what we originally would have liked. So I am not averse to not changing anything.

The proposed check assumes that we want to call POSTREGRID whenever a level might be affected by recomposing and that once a coarse level is recomposed, all finer levels also are affected. Or do we want the distinction between regrid and recompose?

#966: Carpet always calls POSTREGRID on the finest level --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

#966: Carpet always calls POSTREGRID on the finest level --------------------------+------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: closed Priority: minor | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: reviewed_ok => closed * resolution: => fixed