#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ---------------------------------+----------------------------------- Reporter: fcipolletta | Type: enhancement Status: new | Priority: unset Milestone: ET_2019_02 | Component: EinsteinToolkit thorn Version: development version | Keywords: Hydro_Analysis ---------------------------------+----------------------------------- Added EinsteinAnalysis/Hydro_Analysis/Hydro_Analysis_Masses.F90 in order to compute the total baryonic mass and baryonic mass within user defined radii. Added parameters to params.ccl in order to control the aforementioned computation. Added a testuite for this new feature. I have already submitted a pull request for this new feature.
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: new Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Description changed by fcipolletta:
Old description:
Added EinsteinAnalysis/Hydro_Analysis/Hydro_Analysis_Masses.F90 in order to compute the total baryonic mass and baryonic mass within user defined radii. Added parameters to params.ccl in order to control the aforementioned computation. Added a testuite for this new feature. I have already submitted a pull request for this new feature.
New description:
Added EinsteinAnalysis/Hydro_Analysis/Hydro_Analysis_Masses.F90 in order to compute the total baryonic mass and baryonic mass within user defined radii. Added parameters to params.ccl in order to control the aforementioned computation. Added a testuite to test the baryonic mass computation. I have already submitted a pull request to EinsteinToolkit/EinsteinAnalysis master branch for this new feature.
--
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: review Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: new => review
Comment:
Pull request is https://bitbucket.org/einsteintoolkit/einsteinanalysis /pull-requests/8/hydro_analysis-added-hydro_masses-in-order/diff
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: reopened Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: review => reopened
Comment:
I added some more comments that should be addressed in the pull request.
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: reopened Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+---------------------------------
Comment (by fcipolletta):
Dear Roland,
I am reviewing the code following your suggestion and soon I will update the pull request.
Yours, Federico.
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: review Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: reopened => review
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: reviewed_ok Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: review => reviewed_ok
Comment:
Please apply.
Bruno says the same thing (private email).
#2217: EinsteinAnalysis/Hydro_Analysis Thorn new feature ------------------------------------+--------------------------------- Reporter: fcipolletta | Owner: (none) Type: enhancement | Status: closed Priority: unset | Milestone: ET_2019_02 Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: Hydro_Analysis ------------------------------------+--------------------------------- Changes (by Roland Haas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Applied as git hash 38fd28d8 "Hydro_Analysis: Merged in code to compute baryonic mass" of einsteinanalysis.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit