[Einstein Toolkit] #1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: Other | Version: Keywords: | --------------------+------------------------------------------------------- The assert(offsets.empty()) in dh::regrid line 1207 and 1265 which may not find the std::vector offsets empty if regrid is called on levels that were not changed.
A quick fix is to clear() local_boxes at the top of dh::regrid (attached). However since local_boxes are expensive I less drastic method might be better.
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* priority: major => minor * status: new => review * component: Other => Carpet
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by eschnett):
Yes, the local boxes should be cleared before they are used.
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: review Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------
Comment (by rhaas):
So the proposed patch is fine to commit?
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: reviewed_ok Priority: minor | Milestone: Component: Carpet | Version: Resolution: | Keywords: ---------------------+------------------------------------------------------ Changes (by eschnett):
* status: review => reviewed_ok
#1235: commit4306806ad6d517f4e9b675d3cd541c95db3ea7fa breaks multipatch runs ---------------------+------------------------------------------------------ Reporter: rhaas | Owner: Type: defect | Status: closed Priority: minor | Milestone: Component: Carpet | Version: Resolution: fixed | Keywords: ---------------------+------------------------------------------------------ Changes (by rhaas):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Appliead as hash 023f22093fde49211829752f37b751fd4b31cc6f "CarpetLib: clear boundary slice offsets in dh::regrid()" of CarpetLib.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit