#2526: McLachlan has incorrect READ declarations for presync.

Reporter: Peter Diener Status: new Milestone: ET_2021_05 Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn

Comment (by Roland Haas):

The `READS` generation is somewhat related to using Tmunu in expression as of commit hash [e69182c](https://github.com/ianhinder/Kranc/commits/e69182cf0e78e4120d6d3e518883037f9...) "generate READS statement for stress_energy_state if needed" of [Kranc](https://github.com/ianhinder/Kranc) which is in ET_2020_05_v0.

While that commit does _not_ produce `READS: TmunuBase:eTxx` it queries the `RequireGroups` variable for their presence and that variable is the one used to generate the `READS` and itself generates a `READS: TmunuBase::stress_energy_state`. Meaning: if there is a `READS: TmunuBase::stress_energy_state` then `RequireGroups` contained TmunuBase variables and `READS` for them will be generated. This seems to be what happens for ML_BSSN_ADMBaseEverywhere.

That commit (once one ignores whitespace changes and putting code in a `Module`) adds:

```mathematica (* must match list in CodeGenCalculation.m *) ignoreGroups = {"TmunuBase::eTtt", "TmunuBase::eTxx", "TmunuBase::eTxy", "TmunuBase::eTxz", "TmunuBase::eTyy", "TmunuBase::eTyz", "TmunuBase::eTzz", "TmunuBase::eTtx", "TmunuBase::eTty", "TmunuBase::eTtz"}; If[ContainsAny[lookupDefault[spec, RequiredGroups, {}], ignoreGroups], "READS: " <> "TmunuBase::stress_energy_state" <> "\n", ""], ```

‌

-- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2526/mclachlan-has-inco...