#136: Don't rebuild external libraries so often
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
One way to keep the external libraries that have been built would be the
following. Create a dummy configuration "ext" where all external libraries
are built. When another configuration is built, it should be easy to
specify to look there for the external libraries, or maybe this should
even be the default.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/136>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#554: GetComponents deletes local changes
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: defect | Status: new
Priority: blocker | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
After checking out an svn repository with GetComponents, I manually
switched to a different branch, and added local changes. GetComponents
--update then checked out the original branch and deleted all my local
changes.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/554>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#508: list-simulations displays job ID when it doesn't make any sense
------------------------+---------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
The list-simulations command displays a restart number and job ID even for
simulations for which there is no job in the queue. The attached patch
omits these in that case.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/508>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#222: Dubious code in Hydro_InitExcision.c
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
Hydro_InitExcision.c contains the following code:
if ( (hydro_initexcision_coordinate_length <= 0.0) &&
( ( x_frac > 0.5 - hydro_initexcision_fraction) &&
( x_frac < 0.5 + hydro_initexcision_fraction) &&
( y_frac > 0.5 - hydro_initexcision_fraction) &&
( y_frac < 0.5 + hydro_initexcision_fraction) &&
( z_frac > 0.5 - hydro_initexcision_fraction) &&
( z_frac < 0.5 + hydro_initexcision_fraction)
) ||
( (hydro_initexcision_coordinate_length > 0.0) &&
( fabs(x[point]-hydro_initexcision_position_x) <=
hydro_initexcision_coordinate_length*0.5) &&
( fabs(y[point]-hydro_initexcision_position_y) <=
hydro_initexcision_coordinate_length*0.5) &&
( fabs(z[point]-hydro_initexcision_position_z) <=
hydro_initexcision_coordinate_length*0.5)
)
)
This code has an "and" (&&) and an "or" (||) operation at top level. Is
this intended? The code would be clearer with an additional set of
parenthesis, or by introducing a suitable set of temporaries for sub-
expressions.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/222>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#545: Use ssh ProxyCommand instead of multiple ssh commands
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
This would simplify quoting, thus also simplify the screen output, and may
speed up things on remote connections.
Here is an example:
ssh -Y -o ProxyCommand='ssh eschnetter(a)mars.perimeterinstitute.ca nc -w 1
curry.pi.local 22' eschnett(a)curry.pi.local
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/545>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#644: Change documentation to talk about SVN instead of CVS
--------------------+-------------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
The current documentation contains outdated references to CVS. Cactus is
now managed using SVN. This patch to the documentation updates the
information. It also removes a detailed description of CVS and leaves
only a basic guide, pointing users instead to the online SVN manual.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/644>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#643: UserGuide: Document current TRAC system instead of GNATS for problem
reports
---------------------------+------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: documentation |
---------------------------+------------------------------------------------
The Cactus documentation (a shared appendix between the User Guide and the
Reference Manual) currently talks about using the GNATS problem reporting
system. We now use TRAC. The attached patch updates the documentation to
describe the new system.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/643>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#637: output puncture velocity in puncturetracker
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: PunctureTracker |
-----------------------------------+----------------------------------------
the attached patch allows the puncture velocities to be output (simply
moves the result of an interpolation into grid functions).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/637>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#544: Enable optimisation in Fortran array index calculations
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
In Fortran, Cactus passes all grid functions as arguments to routines,
and the size of the grid functions are declared in
DECLARE_CCTK_ARGUMENTS. In these declarations, Cactus assumes that the
size of each grid variable group can be different, and the compiler
thus does not see that all grid functions have (locally) the same
array shape. The compiler can thus not simplify array index
calculations. This is probably only relevant in short loops accessing
grid functions from multiple groups (GRHydro?).
The attached patch passes three additional integer arguments
(cctk_lsh[123]) which contain the shape of grid functions, and uses
these to declare grid functions.
This patch is quite old, but was never applied. It comes from a time
when g77 didn't support declaring array shapes via an integer array
(since this is not allowed in Fortran 77). If this is now possible,
one could use the array cctk_lsh instead of passing three extra
integer arguments.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/544>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#235: Improve performance of Fortran index calculations
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
In Fortran, Cactus currently declares grid functions e.g. as (this is the
expansion of DECLARE_CCTK_ARGUMENTS)
REAL*8 gxx (X0metric,X1metric,X2metric)
where X0metric etc. are integers passed into the routine. Each grid
function group has its own, independent size. This has two disadvantages:
1. The compiler does not know that all grid functions have the same size
(namely cctk_lsh), and thus has to perform array index calculations
separately for each group
2. The argument list is longer than neded
The enclosed patch declares grid functions via cctk_lsh. Grid arrays are
still declared independently.
This reduces the code size of e.g. GRHydro/GRHydro_Tmunu.F90 from 6836 to
6241 bytes on my system. I have not attempted to measure a performance
difference.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/235>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit