#555: include header files for prototypes of getpid, sched_getaffinity etc.
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner: rhaas
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Carpet | Version:
Keywords: |
-------------------------+--------------------------------------------------
three small patches that include header files or make prototypes in header
files visible or avoid instantiating a template both explicitly and
implicitly in Carpet.
All three are required to get PGI to compile !Carpet/Hg (plus a change to
loopcontrol.c which should not be required and seems to be due to a
compiler deficiency when handling OpenMP).
The first two actually make the code use fewer implicit declarations of
functions, while the last one (#define NO_COMPLEX) [a] makes the code more
systematic and [b] might actually avoid some implementation defined
behaviour (though I am really not familiar enough with C++ templates to
know).
Unless there are objections I will apply these sometime near the end of
the week (Friday or so).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/555>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#573: Handle derivative orders in WeylScal4 the same way as in McLachlan
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/573>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#514: Regenerate code for WeylScal4
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
We need to regenerate the code for WeylScal4 with the current version of
Kranc.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/514>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#564: McLachlan: Make finite difference order and use of Jacobians selectable at
runtime
-----------------------------------+----------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: McLachlan |
-----------------------------------+----------------------------------------
Currently, we generate separate !McLachlan thorns for different finite
differencing orders and for single-patch and multi-patch. The attached
patch makes use of a new feature in Kranc to enable all finite
differencing orders in all thorns, as well as enabling multi-patch support
in all thorns. These features can now be selected in all thorns via run-
time parameters (fdOrder and jacobian_group). Each thorn defaults to the
finite differencing order that it used before.
This change should be entirely backwards-compatible so users don't need to
change their parameter files or thornlists immediately.
Use of any thorn other than ML_BSSN could be deprecated immediately, and
people should start to transition to using only ML_BSSN. At some point in
the future (after the next release), the other thorns will be dropped. I
don't want to drop the other thorns immediately, as parameter files would
have to be changed, and that makes comparing parameter files between runs
very tedious.
We need to decide whether we want to keep the _UPW variants. These cannot
be used with vectorisation.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/564>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#572: Change scoping of TmunuBase parameter to allow parameter checking in other
thorns
------------------------------+---------------------------------------------
Reporter: filga@… | Type: defect
Status: new | Priority: major
Milestone: | Component: Other
Version: | Keywords:
------------------------------+---------------------------------------------
We would like to be able to check that support_old_CalcTmunu_mechanism is
activated in order to ensure that we will be able to read the stress
energy. However, the parameters in TmunuBase are all default scope, which
is private. The attached patch fixed only the parameter we required. As
other thorns may want to check other parameters, it might be sensible to
change them all to restricted.
Aaryn Tonita
Filippo Galeazzi
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/572>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#574: Formaline: delete tarballs and C files after building object files
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Formaline creates tarballs, converts them to C code, and then compiles
them to object files. Once the object files are there, there is no point
in keeping the corresponding tarball and C file, and they should be
deleted to save disk space.
This may be as simple as removing some .PRECIOUS statements from the
Makefile. However, one has to ensure that deleting these files doesn't
confuse make into believing that they have to be regenerated the next
time.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/574>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#443: Output a stack backtrace on a fatal error in a simulation
-------------------------+--------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Carpet | Version:
Keywords: |
-------------------------+--------------------------------------------------
When a Cactus simulation aborts with a signal, it is often difficult to
determine which part of the code led to the problem. The attached patch
registers a signal handler on Carpet startup for signals 11 and 6
(segmentation fault and abort, e.g. from assert()) which outputs a stack
backtrace from each process to a file, including demangling symbol names.
It uses some low-level and possibly unofficial APIs, and is likely not
completely portable. However, I have tested it on Mac OS (gcc) and Linux
(intel) and it works in those places.
Part of this code was contributed by Justin Luitjens at the Carpet
developers' workshop in summer 2010.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/443>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#556: GetComponents doesn't use AUTH_URL for Mercurial
---------------------------+------------------------------------------------
Reporter: eschnett | Owner: eric9
Type: defect | Status: new
Priority: critical | Milestone:
Component: GetComponents | Version:
Keywords: |
---------------------------+------------------------------------------------
I am checking out Carpet (the Mercurial version) with the following CRL
settings:
!TARGET = $ARR
!TYPE = hg
!AUTH_URL = ssh://carpetmercurial@carpetcode.org/carpet
!URL = http://www.carpetcode.org/hg/carpet
I use this command:
~/Cvanilla/bin/GetComponents ~/Cvanilla/manifest/einsteintoolkit.th
This uses the http url to check out Carpet, which is inconvenient since
one can't push changes via this url. I expected GetComponents to use the
authorized url unless I give the "-a" option. (This seems to work for git;
McLachlan is checked out via AUTH_URL.)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/556>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#482: GetComponents chokes on thorn list using DOS EOL characters in !DEFINEs
---------------------------+------------------------------------------------
Reporter: rhaas | Owner: rhaas
Type: defect | Status: new
Priority: major | Milestone:
Component: GetComponents | Version:
Keywords: |
---------------------------+------------------------------------------------
the attached file uses DOS EOL conventions (ie. \r\n instead of the Unix
typical \n) gives error messages:
{{{
[rhaas3@phys44230 rhaas3]$ ./GetComponents --root dos --parallel cactus.th
Unsuccessful stat on filename containing newline at ./GetComponents line
663.
Unsuccessful stat on filename containing newline at ./GetComponents line
663.
-----------------------------------------------------------------
Checking out module: Cactus
from repository: http://svn.cactuscode.org/flesh/trunk
into: dos
as: .
-----------------------------------------------------------------
Checking out module: CactusBase/Boundary
from repository:
http://svn.cactuscode.org/arrangements/CactusBase/Boundary/trunk
into: dos/arrangements
: No such file or directoryments
Warning: Could not checkout module CactusBase/Boundary
<some more of the same>
-----------------------------------------------------------------
1 components checked out.
0 components updated.
Unable to process CactusBase/Boundary
Unable to process CactusBase/CartGrid3D
Unable to process CactusBase/CoordBase
Unable to process CactusBase/InitBase
Unable to process CactusBase/IOUtil
Unable to process CactusBase/SymBase
Unable to process CactusBase/Time
Unable to process CactusNumerical/MoL
Unable to process CactusBase/LocalInterp
Unable to process CactusUtils/NaNChecker
Unable to process CactusNumerical/Periodic
Unable to process CactusUtils/Formaline
Unable to process CactusNumerical/Slab
Summary of Warnings:
Could not checkout module CactusBase/Boundary
Could not checkout module CactusBase/CartGrid3D
Could not checkout module CactusBase/CoordBase
Could not checkout module CactusBase/InitBase
Could not checkout module CactusBase/IOUtil
Could not checkout module CactusBase/SymBase
Could not checkout module CactusBase/Time
Could not checkout module CactusNumerical/MoL
Could not checkout module CactusBase/LocalInterp
Could not checkout module CactusUtils/NaNChecker
Could not checkout module CactusNumerical/Periodic
Could not checkout module CactusUtils/Formaline
Could not checkout module CactusNumerical/Slab
Time Elapsed: 0 minutes, 8 seconds
}}}
This is due to a \r which becomes part of the ARRANGEMENTS !DEFINE.
A simple solution might be for GetComponents to remove whitespace from end
of input lines via a:
{{{
diff --git a/GetComponents b/GetComponents
index 133487e..5e801f3 100755
--- a/GetComponents
+++ b/GetComponents
@@ -305,6 +305,9 @@ sub parse_list {
my @lines = <$COMPONENT_LIST>;
close($COMPONENT_LIST);
+ # convert CRNL and CR to newline (for lists generated by windows
and macs)
+ map s/(\r\n|\r)/\n/gm, @lines;
+
# handle includes
my $i = -1;
foreach my $line (@lines) {
}}}
Note that his renders the CRtoNL regex on $file below useless (I am also
not sure to what extent we need $orig_file to have the native EOL
character).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/482>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#571: Build error in PITTNullCode/NullSHRExtract
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The thorn PITTNullCode/NullSHRExtract leads to Fortran compile errors for
me:
Preprocessing
/Users/eschnett/Cvanilla/arrangements/PITTNullCode/NullSHRExtract/src/NullSHRE_Pointing.F90
Compiling
/Users/eschnett/Cvanilla/arrangements/PITTNullCode/NullSHRExtract/src/NullSHRE_Pointing.F90
/Users/eschnett/Cvanilla/arrangements/PITTNullCode/NullSHRExtract/src/NullSHRE_Pointing.F90:160.24:
call
NullSHRE_Pointing(cctk_dim,cctk_gsh,cctk_lsh,cctk_lbnd,cctk_ubnd,cctk_ls
1
Error: Dummy argument 'wt_detg' of procedure 'nullshre_pointing' at (1)
has an attribute that requires an explicit interface for this procedure
/Users/eschnett/Cvanilla/arrangements/PITTNullCode/NullSHRExtract/src/NullSHRE_Pointing.F90:218.24:
call
NullSHRE_Pointing(cctk_dim,cctk_gsh,cctk_lsh,cctk_lbnd,cctk_ubnd,cctk_ls
1
Error: Dummy argument 'wt_detg' of procedure 'nullshre_pointing' at (1)
has an attribute that requires an explicit interface for this procedure
make[3]: *** [NullSHRE_Pointing.F90.o] Error 1
make[2]: *** [make.checked] Error 2
make[1]: *** [/Users/eschnett/Cvanilla/configs/sim-
debug/lib/libthorn_NullSHRExtract.a] Error 2
This is with gfortran 4.5. Looking at the source code, I see that the grid
variable wt_detg is declared with a "target" attribute in one of the
routines.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/571>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit