#911: First dependencies for optional capabilities is ignored
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: blocker | Milestone: ET_2012_05
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
The first optional dependency for a thorn is not taken into account when
deciding the build order for capabilities. The reason is a missing space,
which accidentally concatenates the names for the last required and the
first optional dependency. The patch below corrects this.
{{{
$ svn diff
Index: sbin/CreateConfigurationBindings.pl
===================================================================
--- sbin/CreateConfigurationBindings.pl (revision 4825)
+++ sbin/CreateConfigurationBindings.pl (working copy)
@@ -81,7 +81,7 @@
{
if ($providedcaps{$optionalcap})
{
- $cfg->{"\U$thorn\E REQUIRES"} .= "$optionalcap ";
+ $cfg->{"\U$thorn\E REQUIRES"} .= " $optionalcap";
}
}
}
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/911>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#868: Write Formaline tarballs in the background
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Write the Formaline tarballs in the background (using fork()) to
elminiate the wait.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/868>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#215: Driscoll&Healy integration for Multipole
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The attached patch implements a more accurate integration over the sphere,
using an algorithm by Driscoll & Healy. This algorithm uses Gaussian
integration weights, leading (almost) to exponential convergence.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/215>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#512: Run testsuite in "distribute" script
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
Run the testsuite in the distribute script.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/512>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#515: Silently overrides DEBUG and OPTIMISE options
---------------------------+------------------------------------------------
Reporter: barry.wardell | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
---------------------------+------------------------------------------------
When building a configuration with SimFactory, no matter what is set in
the OptionList it sets the DEBUG and OPTIMISE options based on its own
--optimise and --debug options, which default to enabling optimisation and
disabling debug. This means that even if I have an OptionList with
DEBUG="yes", SimFactory will silently change this to DEBUG="no". This is
very unexpected and should not happen.
I think SimFactory should respect what is set in the OptionList and never
change it. The attached patch disables the overriding of all OptionList
settings.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/515>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#936: Cactus binary tree implementation in src/util/BinaryTree.c is broken
----------------------+-----------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: optional | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
It contains an obvious bug of the form:
{{{
int i = something;
if(i<0) {...}
else if(i>0) {...}
else if(i==0} {...}
else {do something else}
}}}
which is clearly nonsensical (this is the second half of the patch). It
also triggers segfaults since it blindly recurses into NULL pointers.
The second one concerns adding elements into the tree, which always
compares to the prospective subtree's parent rather than the subtree
itself.
No thorn seems to use these functions right now, nor are they documented.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/936>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#888: Add thorn ExternalLibraries/hwloc to Einstein Toolkit
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The Portable Hardware Locality (hwloc) software package provides a
portable abstraction (across OS, versions, architectures, ...) of the
hierarchical topology of modern architectures, including NUMA memory
nodes, sockets, shared caches, cores and simultaneous multithreading.
It also gathers various system attributes such as cache and memory
information. It primarily aims at helping applications with gathering
information about modern computing hardware so as to exploit it
accordingly and efficiently.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/888>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#910: Cactus does not detect circular schedule items
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
Right now none of the three schedule items below (which should all be
flagged as faulty I think), triggers any warning during compile or run
time:
{{{
schedule group ordertest at initial
{
} "test schedule sorter"
schedule ADMBase_CartesianMinkowski in ordertest after ADMBase_LapseOne
{
LANG: C
} "Set the metric and extrinsic curvature to cartesian minkowski values"
schedule ADMBase_LapseOne in ordertest after ADMBase_CartesianMinkowski
{
LANG: C
} "Set the lapse to 1 at all points"
SCHEDULE ADMBase_SetShiftStateOn in ordertest after
ADMBase_SetShiftStateOn
{
LANG: C
} "Set the shift_state variable to 1"
}}}
I attach:
* a patch against ADMBase/schedule.ccl to demonstrate the output
* stdout when one runs Exact/Schwarzschild_EF with the faulty schedule.ccl
* a patch against src/schedule/ScheduleSorter.c and Creator that adds
error checks for this situation (the part inside of TEST_SCHEDULECREATOR
is for the stand-alone test inside to compile)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/910>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#909: abort IOUtil_TruncateOutputFiles if called too early
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: IOUtil |
-----------------------------------+----------------------------------------
currently when called before the grid extension for IOUtil has been
registered (which is when IOUtils learns if the is a checkpoint recovery
run or not), the routine returns -1. However the documentation in the
thorn guide states that
{{{
Thorn IOUtil provides an aliased function for other I/O thorns to call:
CCTK_INT FUNCTION IO_TruncateOutputFiles (CCTK_POINTER_TO_CONST IN
cctkGH)
This function simply returns 1 or 0 if output files should or should not
be truncated.
}}}
Since there are thorns out there that take this to heart and test for
IO_TruncateOutputFiles() being true (ie non-zero) these thorns always
overwrite data during a recovery when calling IOUtils too early. This
happened to Carpet in ticket #908.
The attached patch makes IOUtil abort instead which seems better than
silently returning the wrong (since undocumented) answer. No actual user
thorn should be affected.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/909>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#908: do not output grid structure to files in SetupGH
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
--------------------+-------------------------------------------------------
instead wait until WRAGH at which point IOUtils has had time to initialize
itself and we can query IO_TruncateOutputFiles with confidence.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/908>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit