#953: Don't produce core files while running test suite
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
-------------------------+--------------------------------------------------
I suggest to disable core file while running the test suite:
{{{
$ svn diff bin/RunTestSuite
Index: bin/RunTestSuite
===================================================================
--- bin/RunTestSuite (revision 1694)
+++ bin/RunTestSuite (working copy)
@@ -13,4 +13,7 @@
# This is the number of MPI processes to run on
export CCTK_TESTSUITE_RUN_PROCESSORS=@NUM_PROCS@
+# Do not produce core files
+ulimit -c 0
+
make @CONFIGURATION@-testsuite PROMPT=no
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/953>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#956: Allow skipping setting the RHS to zero in MoL
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
By default, MoL initialises the RHS variables to zero before calling the
CalcRHS routines. This is (a) superfluous in a well-written code, and (b)
makes it impossible to re-use a RHS that has been calculated ahead of
time, e.g. at the end of the previous time step.
This patch adds a parameter to disable this behaviour.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/956>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#888: Add thorn ExternalLibraries/hwloc to Einstein Toolkit
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The Portable Hardware Locality (hwloc) software package provides a
portable abstraction (across OS, versions, architectures, ...) of the
hierarchical topology of modern architectures, including NUMA memory
nodes, sockets, shared caches, cores and simultaneous multithreading.
It also gathers various system attributes such as cache and memory
information. It primarily aims at helping applications with gathering
information about modern computing hardware so as to exploit it
accordingly and efficiently.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/888>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#951: Add lssh field to cGroupDynamicData
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
The size and memory layout of grid functions is described by two
variables, cctk_lsh and cctk_lssh. The structure cGroupDynamicData is
missing the lssh field. I propose to add it, and am providing a patch.
cctk_lssh is originally intended to support staggered grid functions, i.e.
grid functions that have fewer "active" grid points than are allocated in
memory (e.g. n-1 cells vs. n vertices). This can also be used to pad grid
variables, which can improve cache efficiency and vectorisation.
Fully supporting cctk_lssh in the flesh will later allow supporting
padding in Carpet and/or PUGH.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/951>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#910: Cactus does not detect circular schedule items
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
--------------------+-------------------------------------------------------
Right now none of the three schedule items below (which should all be
flagged as faulty I think), triggers any warning during compile or run
time:
{{{
schedule group ordertest at initial
{
} "test schedule sorter"
schedule ADMBase_CartesianMinkowski in ordertest after ADMBase_LapseOne
{
LANG: C
} "Set the metric and extrinsic curvature to cartesian minkowski values"
schedule ADMBase_LapseOne in ordertest after ADMBase_CartesianMinkowski
{
LANG: C
} "Set the lapse to 1 at all points"
SCHEDULE ADMBase_SetShiftStateOn in ordertest after
ADMBase_SetShiftStateOn
{
LANG: C
} "Set the shift_state variable to 1"
}}}
I attach:
* a patch against ADMBase/schedule.ccl to demonstrate the output
* stdout when one runs Exact/Schwarzschild_EF with the faulty schedule.ccl
* a patch against src/schedule/ScheduleSorter.c and Creator that adds
error checks for this situation (the part inside of TEST_SCHEDULECREATOR
is for the stand-alone test inside to compile)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/910>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#909: abort IOUtil_TruncateOutputFiles if called too early
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: IOUtil |
-----------------------------------+----------------------------------------
currently when called before the grid extension for IOUtil has been
registered (which is when IOUtils learns if the is a checkpoint recovery
run or not), the routine returns -1. However the documentation in the
thorn guide states that
{{{
Thorn IOUtil provides an aliased function for other I/O thorns to call:
CCTK_INT FUNCTION IO_TruncateOutputFiles (CCTK_POINTER_TO_CONST IN
cctkGH)
This function simply returns 1 or 0 if output files should or should not
be truncated.
}}}
Since there are thorns out there that take this to heart and test for
IO_TruncateOutputFiles() being true (ie non-zero) these thorns always
overwrite data during a recovery when calling IOUtils too early. This
happened to Carpet in ticket #908.
The attached patch makes IOUtil abort instead which seems better than
silently returning the wrong (since undocumented) answer. No actual user
thorn should be affected.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/909>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#908: do not output grid structure to files in SetupGH
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
--------------------+-------------------------------------------------------
instead wait until WRAGH at which point IOUtils has had time to initialize
itself and we can query IO_TruncateOutputFiles with confidence.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/908>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#949: RotatingSymmetry90: abort when evaluating tensor type for Weyl scalars
---------------------------------------------+------------------------------
Reporter: bmundim | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: RotatingSymmetry90 Weyl scalars |
---------------------------------------------+------------------------------
RotatingSymmetry90 is aborting when evaluating tensor type for Weyl
scalars. It doesn't take into account the ManualCartesian type for
example. The attached patch avoids that.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/949>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#884: RotatingSymmetry90 lacks ManualCartesian tensor type support
--------------------+-------------------------------------------------------
Reporter: tbode | Owner: tbode
Type: defect | Status: new
Priority: major | Milestone: ET_2012_05
Component: Cactus | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
RotatingSymmetry90 currently doesn't process the ManualCartesian tensor
type. Since WeylScal4 now has more than Psi4, this means WeylScal4 and
RotatingSymmetry90 can't both be active. Does anyone have a patch lying
around adding ManualCartesian support to RotatingSymmetry90 they wish to
contribute? If not, I'll see to writing a patch.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/884>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#948: Do not use bare "except:"
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
A bare "except:" (without listing an exception class) will intercept all
exceptions, including the user typing control-C to abort. This should
therefore not be used, except if (a) the code will abort anyway with an
appropriate user-visible error message, or (b) the code will re-raise the
exception via "raise".
In particular, Simfactory catches filesystem errors with bare excepts;
this should be cleaned up.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/948>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit