#1084: increase default value of RELTOL to 1e-12
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: test system |
-------------------------+--------------------------------------------------
right now the defaults for ABSTOL and RELTOL (see lib/sbin/RunTestUtils.pl
line 587) are
{{{
$runconfig{"ABSTOL"} = 1e-12;
$runconfig{"RELTOL"} = 0;
}}}
in particular RELTOL is set to zero. This means that for values of order
1000 or so ABSTOL requests more significant figures than a double
provides.
Instead it would seem to be more sensible to request RELTOL = 1e-12 as
well which will leave the accuracy unchanged for values of order unity but
make the test system less prone to false alarms for values that are larger
(eg sum reductions, values close to the puncture)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1084>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1076: abort Formaline's git-lock.pl if aquiring lock fails for reasons other than
EEXIST
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: Formaline |
-----------------------------------+----------------------------------------
without this it enters an infinite loop if eg the path to the lockdir does
not exist. With this patch, the command that wait for the lock is not
executed and the make system prints out an error message.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1076>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1087: qc0-mclachlan fails with Assertion `not reg.processors' failed
----------------------+-----------------------------------------------------
Reporter: hinder | Owner: eschnett
Type: defect | Status: new
Priority: critical | Milestone:
Component: Carpet | Version:
Keywords: |
----------------------+-----------------------------------------------------
I am running qc0-mclachlan.par from the ET trunk on Datura. I get this
error message during startup:
cactus_sim:
/home/ianhin/Cactus/EinsteinToolkit/arrangements/Carpet/CarpetLib/src/region.cc:166:
void combine_regions(const std::vector<region_t, std::allocator<region_t>>
&, std::vector<region_t, std::allocator<region_t>> &): Assertion `not
reg.processors' failed.
I get the same message whether I run on 1 MPI process or 2, and also on
another machine. Since qc0-mclachlan is a standard BBH simulation, I
assume that a similar error could/does occur for any binary simulation
with moving-boxes mesh refinement. Setting priority to Critical as a
result.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1087>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1090: use efficient RK4 in multirate RK4 RK2 scheme
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: MoL |
-------------------------+--------------------------------------------------
This patch cleans up the code, improves performance of the MoL loops since
it combines several loops into one, and reduces the required scratch
space.
Code originally by Erik, the imported into Zelmani by Christian Reisswig.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1090>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1088: cctk_Capabilities.h has strange content
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
The autogenerated per-thon file cctk_Capabilities.h has a strange content.
It seems to include, for each thorn, configuration files form all thorns
that precede it alphabetically. For example, thorn Accelerator's
cctk_Capabilities.h looks like:
{{{
#include "../Configuration/Thorns/cctki_ADM.h"
#include "../Configuration/Thorns/cctki_ADMAnalysis.h"
#include "../Configuration/Thorns/cctki_ADMBase.h"
#include "../Configuration/Thorns/cctki_ADMConstraints.h"
#include "../Configuration/Thorns/cctki_AHFinder.h"
#include "../Configuration/Thorns/cctki_AHFinderDirect.h"
#include "../Configuration/Thorns/cctki_Accelerator.h"
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1088>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#895: PITTNullCode does not work with Devel AEILocalInterp
---------------------------------+------------------------------------------
Reporter: yosef@… | Type: defect
Status: new | Priority: major
Milestone: | Component: EinsteinToolkit thorn
Version: | Keywords: CCE complex interpolation
---------------------------------+------------------------------------------
The CCE testsuite fails in the development version of ET.
The interpolation calls in NullNews fail with the error
WARNING[L1,P0] (AEILocalInterp):
CCTK_InterpLocalUniform(): input datatype 111 not supported!
(0-origin) input #in=0
The interpolation call is for a variable of type CCTK_VARIABLE_COMPLEX.
The call works with the Maxwell version of AEILocalInterp
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/895>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1080: Can't build Carpet with MPI = CUSTOM in the optionlist
---------------------+------------------------------------------------------
Reporter: alibeck | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: Carpet | Version:
Keywords: |
---------------------+------------------------------------------------------
There was 1 error during execution of the CST
This must be corrected before compilation can proceed
------------------------------------------------------
Having Carpet as a thorn in the Thronlist, but not "ExternaLibraries/MPI"
the build fails with the message:
[snip]
CST error 1:
-> Thorn 'Carpet' requires the capability 'MPI'.
Please add a thorn that provides 'MPI' to your ThornList or remove
'Carpet' from it !
[snip]
However, adding the thorn "ExternaLibraries/MPI" to the Thornlist gives
the error:
[snip]
CST error 1:
-> Configuration script for thorn MPI returned exit code 1
Error message: 'Setting the option "MPI" is incompatible with the MPI
thorn. Please remove the option MPI=CUSTOM.'
[snip]
I need "MPI = CUSTOM" because Intel MPI shoould be used.
The error occurs with the actual Carpet version
changeset: 3658:dca1e61b47bd
tag: tip
user: Roland Haas <roland.haas(a)physics.gatech.edu>
date: Fri Sep 07 23:18:34 2012 -0400
summary: Carpet: insert routines into Boundary group to capture
boundary update
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1080>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1023: Improve OpenMP parallelisation of SummationByParts
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
The Intel compiler does not handle workshare constructs well. The attached
patch replaces them by explicit loops, which execute faster. This makes a
measurable difference on Hopper with 24 OpenMP threads.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1023>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1079: Don't use "-C" in rsync exclusion pattern
------------------------+---------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: SimFactory | Version:
Keywords: |
------------------------+---------------------------------------------------
Don't use "-C" in rsync exclusion pattern; it excludes too much
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1079>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1089: Disable K&R getopt() prototype
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
The file getopt.h, taken from glibc, defines a prototype for the function
getopt() (which is not actually used in Cactus). Depending on the compiler
used, this is either an ANSI prototype with arguments, or a K&R prototype
without arguments.
The IBM C++ compiler does not handle the K&R prototype well; it complains
that it sees ANSI prototypes in stdio.h and stdlib.h, and aborts.
Since we don't call getopt() in Cactus, I suggest to disable the K&R
prototype:
{{{
Index: gnu/getopt.h
===================================================================
--- gnu/getopt.h (revision 4867)
+++ gnu/getopt.h (working copy)
@@ -150,7 +150,9 @@
int __long_only);
# endif
#else /* not __STDC__ */
-extern int getopt ();
+/* The declaration below leads to a prototype mismatch with
+ IBM XL C/C++ for AIX, V11.1 (5724-X13), Version: 11.01.0000.0005 */
+/* extern int getopt (); */
# ifndef __need_getopt
extern int getopt_long ();
extern int getopt_long_only ();
}}}
I also tried various options to disable the ANSI prototypes in the system
libraries (didn't help), and tried updating getopt.h to a more recent
version (didn't help either).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1089>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit