#1492: missing parameter in CactusExamples/WaveMoL ?
--------------------+-------------------------------------------------------
Reporter: knarf | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone: ET_2014_05
Component: Carpet | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The testsuites CarpetInterp/waveinterp* set a parameter
WaveMoL::num_timelevels that does not exist in CactusExamples/WaveMoL.
Since CactusExamples was only just recently added to the ET, this
testsuite now tries to run and fails. This is not really a failure of the
newly added thorn, but that of the long existing, but never run testsuite.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1492>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1266: Featue request for Parity Symmetry thorn
---------------------------------+------------------------------------------
Reporter: yosef@… | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
---------------------------------+------------------------------------------
I started looking at runs with parity symmetry, that is the only
symmetry is the simultaneous reflection about x, y, and z. I think
I was able to "implement" this symmetry by changing just a handful of
lines in Rotating180 and I'm a little less sure about my changes to
carpetregrid2. I was wondering, would there be any interest in adding
this symmetry to ET?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1266>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1384: simplify using Refluxing with MoL
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: optional | Milestone:
Component: Other | Version: development version
Keywords: Refluxing |
-------------------------+--------------------------------------------------
currently one needs to set two parameters when using Refluxing with
GRHydro only: nvars and nvars_evolved which are set to the same value. The
two different parameters allow refluxing to be used with thorns that
implement their own timestepping indedpendent of MoL.
To simplify usage in situations where only MoL is used I proposed to
introduce a new parameter nvars_not_evolved_with_MoL which defaults to
zero and to retire nvars_evolved in favor of the new parameter. This would
make MoL based simulations with only a single parameter choice possible.
Alternatively we could have a second string non_MoL_refluxing_variables
that lists the variables which have refluxing applied to them but are not
evolved with MoL.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1384>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1503: Support XFAIL for test cases
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
There should be a mechanism to mark test cases as "XFAIL" if they are
expected to fail.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1503>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1502: provide equivalent of CCTK_PASS_CTOC and CCTK_PASS_FTOF between languages
-------------------------+--------------------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
It is occasionally (such as when interfacing with legacy code) code useful
to use the equivalent of {{{CCTK_PASS_CTOF}}} and {{{CCTK_PASS_FTOC}}}.
This seems to be impossible to directly. Workarounds are declare the C
function to take {{{cGH ** p_cctkGH}}} as an argument then set up a local
{{{cGH *cctkGH = *p_cctkGH}}} before {{{DECLARE_CCTK_ARGUMENTS}}} for
{{{CCTK_PASS_FTOC}}} while for {{{CCTK_PASS_CTOF}}} one seems to have to
resort to {{{CCTK_FortranWrapper}}} and call the returned wrapper with
cctkGH and the (Fortran) function pointer.
Note: this of course suffers from combinatorial explosion of options when
Cactus starts to support Lua/Python/Tcl/Java/Forth.
It might be useful to instead provide a set of functions that allow this
to be done "officially". Something like:
{{{
call CCTK_PASSFTOC(Cfunc)
}}}
and
{{{
CCTK_PASSCTOF(CCTK_FNAME(Ffunc));
}}}
where the later is essentially
{{{
#define CCTK_PASSCTOF(fun) (CCTK_FortranWrapper(CCTK_THORNSTRING))(fun,
cctkGH)
}}}
and the former
{{{
#define CCTK_PASSFTOC(fun) CCTK_PassFtoC(fun, cctkGH)
void CCTK_FNAME(CCTK_PassFtoC)(void (*f)(cGH *cctkGH), cGH **p_cctkGH)
{
f(*p_cctkGH);
}
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1502>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1501: Include string null terminator in HDF5 attributes
---------------------------+------------------------------------------------
Reporter: barry.wardell | Owner: eschnett
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Carpet | Version: development version
Keywords: |
---------------------------+------------------------------------------------
The HDF5 documentation <http://www.hdfgroup.org/HDF5/doc/RM/RM_H5T.html
#Datatype-SetSize> states that the size of a string should include space
for a null terminator. Up to now, the "name" attribute in HDF5 output
files was stored as a string excluding the null terminator. This meant
that when the attributed was read back, it could not be treated as a
standard C string since it was missing the null terminator.
The attached patch changes the behaviour so that the null terminator is
included.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1501>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1476: Use mvapich2 instead of impi on Stampede
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2013_11
Component: Other | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
mvapich2 is the default, has probably less problems, and should provide a
higher performance.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1476>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1485: Remove support of StaticConformal from ADMMacros
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2014_05
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
The attached patch removes support of StaticConformal from ADMMacros. The
patch tries to do this in a minimal way, e.g. it set's the macros to 0. or
1. Optimizing this isn't worth it IMHO, we should instead look into a
replacement of the thorn itself in the long run. However, in the meantime,
this patch enables us to remove the dependency on StaticConformal from
thorns using ADMMacros.
This lets testcases fail that actually use a static conformal metric (from
ADM, ADMConstraints, Extract, and IDAnalyticBH) - which is expected. All
others succeed.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1485>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1486: GRHydro updates
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: GRHydro |
-----------------------------------+----------------------------------------
two updates that I had already prepared for inclusion quite a while ago.
To be included after the release.
0001 improves handling of mangnetic fields inside of the excised region by
being less aggressive when resetting to atmosphere values. 0002 ensures
that the trivial_rp grid function has the same memory layout at the other
grid functions. Given that way that reconstruction is done, there was
nothing actually wrong with the previous method though (even when padding
is used so that cctk_ash != cctk_lsh).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1486>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit