#1152: Add option to compute center of mass to hydro_analysis and lots of smaller
changes
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: Hydro_Analysis |
-----------------------------------+----------------------------------------
The attached set of patches adds the possibility to compute a center of
mass location to hydro_analysis. It works by computing the center of mass
(via x[idx]*rho[idx]) of the matter in a region of radius
Hydro_Analysis_r_core around the point of maximum density. Only points
whose density is above a fraction Hydro_Analysis_rho_core_rel_min of the
maximum density are considered.
I also include a number of bugfix patches and patches to make
Hydro_Analysis more controllable by user input rather than hard-coded
values. All patches contain a short description in the patch (ie. the git
commit message).
The ones adding extra control and/or warnings are:
* Hydro_Analysis: add verbosity_level option to control how much data to
output to stdout
* Hydro_Analysis: use Fortran modules for prototypes if available
* Hydro_Analysis: add parameters to control which interpolator is used
* Hydro_Analysis: make parameters steerable
* Hydro_Analysis: warn if grid point with maximum value cannot be found on
grid
* Hydro_Analysis: add parameter Hydro_Analysis_comp_rho_max_every
* Hydro_Analysis: add option rho_max_loc_use_rotatingsymmetry180
* Hydro_Analysis: add option to average the location of multiple identical
maxima
* Hydro_Analysis: fiddle with when to warn about multiple identical maxima
Bugfixes are:
* Hydro_Analysis: checkpoint grid scalars
* Hydro_Analysis: do reduction in global mode
New feature:
* Hydro_Analysis: add routine to compute center of mass in core region
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1152>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1006: ExternalLibraries' configure.sh scripts handle /usr inconistently
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: ExternalLibraries |
-----------------------------------+----------------------------------------
library path used for -L should not contain the system paths at least
/lib, /lib64, /usr/lib, /usr/lib64, /usr/local/lib, /usr/local/lib64 (plus
MacOS equivalents, and any other OS we support).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1006>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1338: Rename Carpet output files
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: Carpet | Version:
Keywords: |
----------------------+-----------------------------------------------------
Windows does not allow colons in file names. Output files produced by
Carpet's should therefore not use colons.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1338>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1490: ExternalLibraries/PAPI contains testsuite, but no data
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone: ET_2014_05
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
ExternalLibraries/PAPI contains testsuite, but no data. This means the
testsuite mechanism (currently) will count it always as succeeding, which
is not helpful. Also, it contains a README file which only says that this
directory is empty - which is not only not helpful, but also wrong, given
that there is this README inside..
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1490>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1481: Hidden hard-coded limits on max_l_modes and max_vars in Multipole
--------------------------------------+-------------------------------------
Reporter: bernard.j.kelly@… | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2013_11
Component: EinsteinToolkit thorn | Version: ET_2013_05
Keywords: Multipole |
--------------------------------------+-------------------------------------
The EinsteinAnalysis/Multipole thorn has hard-coded limits (in
src/multipole.cc) on the number of grid functions that can be decomposed
(max_vars) and how high in polar quantum number this decomposition can go
(max_l_modes). However, these are not reflected in the thorn's param.ccl.
In fact, param.ccl contains a parameter "l_max", allowing it to be *any*
positive value, and doesn't test this against max_l_modes until execution
of this source. Wouldn't it make more sense to impose max_l_modes
immediately at PARAMCHECK?
To make the actual limit on interpolated functions explicit, a number of
desired interpolants could be set in param.ccl (like "n_variables") ---
limited if necessary to a hard-coded number that appears as a limit in the
range. If the user tries to set n_variables too high, it gets caught at
PARAMCHECK; if (s)he accidentally includes too many entries in the
"variables" parameter, the extra ones would just be silently ignored.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1481>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1360: TAT/TATPETSc has no (ET-only) testsuite
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2013_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
It would be nice if TATPETSc, being part of the ET, would have at least
one testsuite that can actually run using the ET only.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1360>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1317: GRHydro should provide _one_ mechanism to set a GP to atmosphere
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
GRHydro should provide _one_ mechanism to set a GP to atmosphere which
should then be used whenever that should be the case. Right now, this is
copied in several places.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1317>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1075: Test cases with specific number of processes
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
Some test cases require a specific number of processes. Instead not
running, they should run on that number of processes. This would ensure
that all tests execute all the time.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1075>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1158: ExternalLibraries/HDF5 should change the defaults for HDF5_ENABLE_CXX and
HDF5_ENABLE_FORTRAN to "no".
-----------------------------------+----------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
ExternalLibraries/HDF5 should change the defaults for HDF5_ENABLE_CXX and
HDF5_ENABLE_FORTRAN to "no". Nothing within the toolkit or Cactus still
uses these interfaces and system wide installed libraries might not come
with it, leading to link failures.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1158>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1388: New thorn MemSpeed
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
I have written a thorn MemSpeed, available at
<https://svn.einsteintoolkit.org/incoming/MemSpeed>. This thorn is useful
for performance tuning. I propose to add it to CactusUtils.
From the README:
Determine the speed of the CPU, as well as latencies and bandwidths of
caches and main memory. These provides ideal, but real-world values
against which the performance of other routines can be compared.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1388>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit