#1388: New thorn MemSpeed -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- I have written a thorn MemSpeed, available at https://svn.einsteintoolkit.org/incoming/MemSpeed. This thorn is useful for performance tuning. I propose to add it to CactusUtils.
From the README:
Determine the speed of the CPU, as well as latencies and bandwidths of caches and main memory. These provides ideal, but real-world values against which the performance of other routines can be compared.
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: new => review
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: review => closed * resolution: => fixed
Comment:
Committed.
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reopened Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: closed => reopened * resolution: fixed =>
Comment:
This thorn is in the repository, but not part of the EinsteinToolkit. I propose to add it to the Einstein Toolkit.
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reopened => review
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+--------------------------------------- Changes (by hinder):
* status: review => reviewed_ok
Comment:
This seems like a useful thorn to have available. Some comments:
1. The name "MemSpeed" seems to be historical; the thorn measures both CPU and memory speeds. Maybe "HWSpeed" or "HWPerf" might be better? If it is to be renamed, now seems like a good time, before it is in the official thornlist. (optional) 2. There is extensive documentation (thanks!) 3. There is a test case. Am I correct that this test is safe to run as part of the automated tests? It says to skip the large memory benchmark. Does that mean it should be fast enough to run? 4. I have skimmed through the code and didn't notice any major issues
I support inclusion in the toolkit as long as the default test case does not require large amounts of time or memory.
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: reviewed_ok Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: ------------------------------------+---------------------------------------
Comment (by eschnett):
1. The majority of the tests are for memory performance; the other tests are just small add-ons.
3. Yes, the test case should be safe to run. You can run multiple tests simultaneously on the same node. In fact, if the test case takes a long time to run, then this indicates a problem (e.g. wrong OpenMP configuration). The standard test (without disabling the large- memory test) can only run once simultaneously per node, and is useful only on compute nodes of clusters.
#1388: New thorn MemSpeed ------------------------------------+--------------------------------------- Reporter: eschnett | Owner: Type: enhancement | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: ------------------------------------+--------------------------------------- Changes (by eschnett):
* status: reviewed_ok => closed * resolution: => fixed
Comment:
Added to manifest.th via https://bitbucket.org/einsteintoolkit/manifest/commits/8303c31adbb992a2b8945...
trac@lists.einsteintoolkit.org
-
Einstein Toolkit