#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: new Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

Would you like this to be reviewed?

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by eschnett):

* status: review => reviewed_ok

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: closed Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: fixed | Keywords: --------------------------+------------------------------------------------- Changes (by sbrandt):

* status: reviewed_ok => closed * resolution: => fixed

Comment:

Committed Revision 2250

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: review Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: reopened => review

Comment:

ok to apply (both :-) )? Should we revert rev 2250 (there is nothing wrong with the patch after all)?

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: review Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by rhaas):

Hmm, outputting the same information twice certainly should be avoided. Having lookied at the dprint routine that the uberftp cude uses, I think we are not quite doing the right thing though. Most likely we should use info() or dprint() instead of just print to make sure that the information also appears in the simfactory log file. Currently both info() and dprint() always write to the log file, so to get the behaviour we just implemented (but also writing to the log) we'd need another dprint wrapper eg "verbose_info" (or replicate the verbosity level in the callers).

Also seems to me as if libutil.py's dprint code contains a bug in that it does not check for flag == USE_VERBOSE and does not actually implement what the comment just above indicates.

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: eschnett Type: enhancement | Status: reopened Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):

* status: review => reopened

Comment:

I think the current situation is that the patch was applied to an old release branch, not the trunk, and there are still issues with the patch as discussed above. The patch would never have been applied to the release branch, so I suggest reverting it.

I can't quite tell what the remaining issues are from the discussion above. Maybe you could list them here, or fix them? This feature would be very useful to have in simfactory, especially when debugging problems, so we should try to add it.

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: assigned Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+-------------------------------------------------

Comment (by sbrandt):

I've merged the patches and made another small change to prevent redundant output.

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: review => reviewed_ok

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: reopened Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by hinder):

* status: closed => reopened * resolution: fixed =>

Comment:

I have reverted this commit because it causes the automated build and test to fail completely. See https://build.barrywardell.net/job/EinsteinToolkit/1312/console. The failure is

{{{ Skeleton Created Job directory: "/home/jenkins/workspace/EinsteinToolkit/../simulations/EinsteinToolkit_a639fc5731c04d0ace7e147133c453e5b82ad5bb_1" Option --testsuite given Executable: "/home/jenkins/workspace/EinsteinToolkit/exe/cactus_sim" Option list: "/home/jenkins/workspace/EinsteinToolkit/../simulations/EinsteinToolkit_a639fc5731c04d0ace7e147133c453e5b82ad5bb_1/SIMFACTORY/cfg/OptionList" Submit script: "/home/jenkins/workspace/EinsteinToolkit/../simulations/EinsteinToolkit_a639fc5731c04d0ace7e147133c453e5b82ad5bb_1/SIMFACTORY/run/SubmitScript" Run script: "/home/jenkins/workspace/EinsteinToolkit/../simulations/EinsteinToolkit_a639fc5731c04d0ace7e147133c453e5b82ad5bb_1/SIMFACTORY/run/RunScript" Simulation name: EinsteinToolkit_a639fc5731c04d0ace7e147133c453e5b82ad5bb_1 Assigned restart id: 0 Copying testsuite data Traceback (most recent call last): File "simfactory/bin/../lib/sim.py", line 148, in <module> main() File "simfactory/bin/../lib/sim.py", line 144, in main CommandDispatch() File "simfactory/bin/../lib/sim.py", line 106, in CommandDispatch module.main() File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/sim- manage.py", line 397, in main CommandDispatch() File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/sim- manage.py", line 376, in CommandDispatch exec("command_%s()" % command) File "<string>", line 1, in <module> File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/sim- manage.py", line 183, in command_create_run command_run() File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/sim- manage.py", line 220, in command_run restart.userRun(simulationName) File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/simrestart.py", line 956, in userRun self.copyTestsuiteData() File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/simrestart.py", line 494, in copyTestsuiteData rsyncversion = simlib.RsyncVersion(rsyncInfo) File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/simlib.py", line 1055, in RsyncVersion versionText = ExecuteCommand('%s --version' % rsynccmd, True) File "/home/jenkins/workspace/EinsteinToolkit/simfactory/lib/simlib.py", line 545, in ExecuteCommand if (not output) or (global_dict['VERBOSE']): KeyError: 'VERBOSE' }}}

The script which is running when this failure occurs is at https://bitbucket.org/ianhinder/cactusjenkins/src/master/test- cactus?at=master and the relevant command is presumably the {{{ simfactory/bin/sim create-run --testsuite $tests --procs $cores --num- threads $((cores/nprocs)) $simname }}} Maybe you can reproduce the failure with a similar command line?

#1517: Make Simfactory tell you what it's doing --------------------------+------------------------------------------------- Reporter: sbrandt | Owner: sbrandt Type: enhancement | Status: reviewed_ok Priority: optional | Milestone: Cactus_4.3.0 Component: SimFactory | Version: development version Resolution: | Keywords: --------------------------+------------------------------------------------- Changes (by rhaas):

* status: review => reviewed_ok

Comment:

Please apply (personal communication: Steve could reproduce the issue and fix it with the new patch).