#780: missing small packages
----------------------------------------------+-----------------------------
Reporter: knarf | Owner: dcastl2
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Einstein Toolkit Virtual Machine | Version:
Keywords: |
----------------------------------------------+-----------------------------
Some tools to be installed:
mmv
screen
tmux
texlive (probably quite large, but also probably necessary)
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/780>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1231: "How did I get here" error in test suite mechanism
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
----------------------+-----------------------------------------------------
I see several error such as the one below reported by Cactus. The error is
the line that begins with "ERROR".
Test Hydro_InitExcision: x_flip_pugh_eno
"1D shocktube, RK2, Marquina, ENO, Ideal Gas, x-Excision"
Issuing ln -fns . output-0000-active && mkdir -p SIMFACTORY &&
TESTSUITE_PARFILE=/scratch/jenkins/jobs/EinsteinToolkit/simulations/EinsteinToolkit_69189d49fa86945d70ba137f840efe1301b13c71_2/output-0000/arrangements/EinsteinInitialData/Hydro_InitExcision/test/x_flip_pugh_eno.par
/scratch/jenkins/jobs/EinsteinToolkit/simulations/EinsteinToolkit_69189d49fa86945d70ba137f840efe1301b13c71_2/output-0000/SIMFACTORY/RunScript
ERROR: How did I get here, maximum difference is 9.99999388850981e-12 and
maximum value is 0 for h.t0.ah2.gp
BH_diagnostics.ah1.gp: differences below tolerance on 1 lines
BH_diagnostics.ah2.gp: differences below tolerance on 1 lines
h.t0.ah1.gp: differences below tolerance on 704 lines
h.t0.ah2.gp: differences below tolerance on 731 lines
sf_area[0].xg: differences below tolerance on 1 lines
sf_min_radius[0].xg: differences below tolerance on 1 lines
sf_radius[0]_2D.asc: differences below tolerance on 308 lines
sf_radius[1]_2D.asc: differences below tolerance on 23 lines
Success: 55 files compared, 8 differ in the last digits
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1231>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1192: Speed up Hydro_InitExcision test cases
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
Hydro_InitExcision sets up an excision mask for hydrodynamics evolution.
It is active at initial and poststep (and postregrid), and its logic
depends only on parameters, not on the simulation state.
Its test cases take a very long time to run:
(1) Running this for 100 iterations with PUGH is overkill. 1 iteration
suffices, testing both initial and poststep.
(2) The excision mask is not even output! Instead, only the indirect
results on the hydro variables are tested.
(3) All test cases use PUGH, so Carpet's postregrid bin is not tested.
(4) Each test exists three times, for different reconstruction methods.
The reconstruction methods do not enter into this thorn's logic.
I conclude: The existing tests confirm that this thorn has the right
functionality. They are therefore important. However, they should not be
in the Cactus test suite.
We want regression tests in the Cactus test cases, and this could be
achieved about 100x faster (fewer iterations, fewer test cases).
Additionally, there should be Carpet tests, and the excision mask should
be output.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1192>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#456: Ensure functions are not defined twice
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
When multiple source files define non-static functions with the same name,
these are all compiled together into the resulting executable. Which one
gets called is not predictable by the user.
This can happen if a user copies a thorn, modifies it slightly, and
compiles both thorns into the same configuration. This can lead to *very*
difficult-to-find bugs, and it would be helpful if Cactus was able to
prevent this, or at least to mitigate the problem.
At the CST level, Cactus should be able to tell that there are two thorns
which schedule functions with the same name. At the moment, this is not
caught. I propose that this should be a fatal error, as there is no way
to predict which function will be called eventually.
This will solve the problem in some cases, but not in the case where there
are instances of duplicate function names which are not scheduled. It
should be possible to scan the object/library files using standard tools
(nm etc) to determine if there are multiple globally visible symbols with
the same name. There might even be standard tools for this purpose.
Doing this in a portable way might not be straightforward, but having an
implementation for Linux, for example, would catch the majority of cases.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/456>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1195: Modify bisection algorithm in EOS_Omni's nuc_eos
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
EOS_Omni's nuc_eos routines use a bisection method to find the temperature
for a given internal energy. This bisects on the temperature T. I suggest
to bisect on log T instead, which is a more natural operation.
For example, if the temperature range is [1...1000] in some units, then
bisecting in T will examine the sequence 500, 250, 125, ..., and will thus
perform many table lookups until (say) T=10 is reached. Bisecting in log T
will find this result much faster.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1195>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#447: simfactory 1.0 always uses -L 3
----------------------------------------------+-----------------------------
Reporter: alexander.beck-ratzka@… | Owner: eschnett
Type: defect | Status: new
Priority: major | Milestone:
Component: SimFactory | Version:
Keywords: |
----------------------------------------------+-----------------------------
The perl version of simfactory always uses the debugging loglevel for
simulations. The loglevel of a cactus simulation can be specified by
setting -L to a value between 0 (none) and 3 (debug). While the cactus
default is 0, simfactory sets it to 3. The debug loglevel could lead to
huge output files.
I would suggest to set it to the cactus default, and allow a user to
increase it.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/447>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#107: Update released einsteintoolkit.bib once we have a more final version
-----------------------+----------------------------------------------------
Reporter: anonymous | Type: task
Status: new | Priority: major
Milestone: | Component: EinsteinToolkit website
Version: | Keywords:
-----------------------+----------------------------------------------------
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/107>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1299: Correct ET logo on https://www.ohloh.net/p/einsteintoolkit
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
----------------------+-----------------------------------------------------
The Einstein Toolkit logo on <https://www.ohloh.net/p/einsteintoolkit>
looks bad, because it has the wrong aspect ratio. We should upload a
square logo instead.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1299>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#346: Detect when --reconfig is necessary
----------------------+-----------------------------------------------------
Reporter: eschnett | Owner:
Type: defect | Status: new
Priority: minor | Milestone:
Component: Other | Version:
Keywords: |
----------------------+-----------------------------------------------------
Cactus sometimes outputs an error message that a configuration needs to be
reconfigured. Simfactory should notice this, and then automatically build
with --reconfig.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/346>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1065: Pass CCTK_ARGUMENTS more efficiently in Fortran
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: major | Milestone:
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
CCTK_ARGUMENTS is passed differently in C and in Fortran. In C, only a
single pointer is passed, pointing to cctkGH. The cctk_... variables and
pointers to grid functions are defined locally from cctkGH. This is
efficient, because (a) only a single variable is passed, and (b) the
compiler can eliminate unused definitions.
In Fortran, all the cctk_... variables and all grid functions are passed
explicitly. This is expensive for the caller, because hundreds of
arguments have to be set up and passed to the subroutine. The compiler
cannot eliminate any unused variables.
I suggest to change the Fortran calling convention to be the same as the
one for C. Since regular Fortran pointers differ significantly from C
pointers, I suggest to use "Cray pointers" instead, which are very similar
to C pointers. Cray pointers are an extension to the Fortran standard, and
are supported by all Fortran compilers I know of.
I attach sample code that shows how to declare, define, and use this
convention.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1065>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit