Trac January 2014

trac@lists.einsteintoolkit.org

1 participants
145 discussions

[Einstein Toolkit] #1352: ExternalLibraries/Lua requires readline-headers
by Einstein Toolkit 16 Jan '14

16 Jan '14

#1352: ExternalLibraries/Lua requires readline-headers --------------------+------------------------------------------------------- Reporter: knarf | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: Keywords: | --------------------+------------------------------------------------------- ExternalLibraries/Lua requires readline-headers, but there is no check for it. We could provide a thorn containing it (or forget about the lua thorn - I don't know of any user right now). -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1352> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1520: src/piraha does not adhere to Cactus coding style
by Einstein Toolkit 16 Jan '14

16 Jan '14

#1520: src/piraha does not adhere to Cactus coding style ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: optional | Milestone: Component: Other | Version: development version Keywords: | ----------------------+----------------------------------------------------- The sources files in the src/piraha directory do not adhere to the flesh coding style described in http://einsteintoolkit.org/documentation/MaintGuide/MaintGuidech2.html#x4-3… . It would be very nice if they had GRDOC (or javadoc or doxygen) headers. Also the internal function cctk_PirahaParser should be called CCTKi_PirahaParser instead (ie uppercase CCTK and an added i for internal). Minor point: smart_ptr.cc should be SmartPtr.cc . This is a project for rainy evenings I guess :-). -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1520> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 1

[Einstein Toolkit] #1401: misspelling ActiveThorns in parfiles results in unhelpful error message
by Einstein Toolkit 15 Jan '14

15 Jan '14

#1401: misspelling ActiveThorns in parfiles results in unhelpful error message --------------------+------------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | --------------------+------------------------------------------------------- the attached parfile (which misspells ActiveThorns as ActiveThrons) causes the error message: {{{ Activating thorn Cactus...Success -> active implementation Cactus ERROR IN PARAMETER FILE: In rule 'file::set::par' Line=1, Column=13 ActiveThrons = "Cactus" ^ Expected one of the following characters: [ \t\r\n#:] WARNING level 0 in thorn Cactus processor 0 host horizon.tapir.caltech.edu (line 167 of /mnt/data/rhaas/postdoc/gr/Zelmani/src/main/ProcessParameterDatabase.c): -> CCTKi_SetParameterSetMask: 1 parsing errors in parameter file WARNING level 0 in thorn Cactus processor 0 host horizon.tapir.caltech.edu (line 167 of /mnt/data/rhaas/postdoc/gr/Zelmani/src/main/ProcessParameterDatabase.c): -> CCTKi_SetParameterSetMask: 1 parsing errors in parameter file }}} which does not provide a hint for the cause of the error. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1401> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 10

[Einstein Toolkit] #1381: Carpet no longer has an implied sync() call after restriction
by Einstein Toolkit 14 Jan '14

14 Jan '14

#1381: Carpet no longer has an implied sync() call after restriction --------------------+------------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- I just pushed two tests for the higher order restriction code into CarpetProlongateTest. What I did was to generate the test data before the commit that removes the extra sync, then save the data and apply as the test data on top of the master branch. I also verified that indeed I get the same restricted data across an interprocessor boundary (ie in the z direction of the tests). Surprisingly I actually do since in fact the schedule.ccl file in CarpetProlongateTest does not apply boundary conditions are SYNC in MoL_PostStep so that I should have gotten test failures. This would seem to indicate that either (a) I don't have my test setup correctly (always possibly) or (b) there is yet another SYNC hidden somewhere inside of CarpetLib/Carpet. On the other hand, the current "_rest" tests in CarpetProlongateTest now fail for me unless I re-add the sync. Adding a dummy routine and SYNC to MoL_PostStep which I think is the correct thing to do does not help possibly because the SYNC implies a prolongation while a low-level sync call does not (and which is where I see differences). This of course would argue against (b) above. Attached please find my code change a a plot of diffference.z.asc for test_cc_rest_o3 before and after the change. I do not necessarily think that this is a bug, it certainly is unexpected though. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1381> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 2

[Einstein Toolkit] #1363: Crash on startup in Piraha
by Einstein Toolkit 13 Jan '14

13 Jan '14

#1363: Crash on startup in Piraha ----------------------+----------------------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: blocker | Milestone: ET_2013_05 Component: Other | Version: Keywords: | ----------------------+----------------------------------------------------- I built a Cactus configuration with fewer thorns than usual, and with assertions disabled (-DNDEBUG. This configuration does not start; it crashes on startup with a backtrace {{{ #0 std::_Rb_tree<void*, void*, std::_Identity<void*>, std::less<void*>, std::allocator<void*> >::_M_insert_unique<void* const&> (this=0x0, __v=@0x7fff5fbfd228) at locale_facets.h:1078 #1 0x000000010072e6f2 in smart_ptr<piraha::Grammar>::smart_ptr (this=0x104b9d0d0, ptr=0x10570a5a0, array_=<value temporarily unavailable, due to optimizations>) at stl_set.h:415 #2 0x0000000100721542 in piraha::AutoGrammar::reparserGenerator () at AutoGrammar.cc:6 #3 0x0000000100c2ada6 in _GLOBAL__sub_I_Grammar.cc () at smart_ptr.hpp:53 #4 0x00007fff5fc13762 in __dyld__ZN16ImageLoaderMachO16doInitializationERKN11ImageLoader11LinkContextE () }}} This indicates that the failure oocurs during initialisation of a global variable during startup. _Rb_tree points to a set or a map. This may be caused by {{{ extern smart_ptr<Grammar> pegGrammar; }}} I also see that Piraha has some code in smart_ptr.hpp that is only added when DNEBUG is defined, and contains assert calls (!). Given that NDEBUG disables assert, this looks like an error. It is considered bad style to use C++ constructors to initialise global variables; this is fragile and breaks often. I suggest instead to change these global variables to pointers, to initialise them to NULL, and to allocate to respective objects explicitly at run time. This is safer, as it ensures that things are allocated in the right order. I also just see that there is a global variables called "ptrs" in Piraha. This is not good; please use a cctki_ prefix for all globally visible variables and functions (or move them into a namespace). -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1363> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 8

[Einstein Toolkit] #1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults
by Einstein Toolkit 13 Jan '14

13 Jan '14

#1516: using GRHydro::reconstruct_Wv with recon_method = WENO segfaults -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: GRhydro backport | -----------------------------------+---------------------------------------- revision 587 of GRHydro intoruced a regression and causes the code to abort with a segfault if GRHydro::reconstruct_Wv = yes and GRHydro:recon_method = WENO are both set. The problem is access to an uninitialized pointer. The attached patch removes the pointers and moves the function call using the pointer inside of a set of if statements which makes the usage of pointer unnecessary. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1516> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1457: m=2 ftp coefficient for teukolsky waves in IDLinearWaves missing
by Einstein Toolkit 13 Jan '14

13 Jan '14

#1457: m=2 ftp coefficient for teukolsky waves in IDLinearWaves missing -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: | -----------------------------------+---------------------------------------- the theta-phi coefficient was not set at all and contained random data. The patch implements the coefficient as found in Eq. 7 of PRD 26:745 (1982) which is the paper referenced in the docs. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1457> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1515: support Intel compilers in OpenSSL configure.sh
by Einstein Toolkit 13 Jan '14

13 Jan '14

#1515: support Intel compilers in OpenSSL configure.sh -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: OpenSSL backport | -----------------------------------+---------------------------------------- the configure script actively remove OpenMP flags from CFLAGS etc but only searches for -fopenmp but not for -openmp as used by (older) intel compilers. The attached patch changes the used regular expression to fix this. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1515> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1291: Boundary does not check for storage
by Einstein Toolkit 13 Jan '14

13 Jan '14

#1291: Boundary does not check for storage -----------------------------------+---------------------------------------- Reporter: eschnett | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: Keywords: | -----------------------------------+---------------------------------------- I accidentally selected a variable for a flat boundary condition (with thorn Boundary) without storage. This led to a segfault. Instead, thorn Boundary should output an error message or a warning. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1291> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 7

[Einstein Toolkit] #1514: Kranc's Differencing.h fails to compile if KRANC_DIFF_FUNCTIONS is defined
by Einstein Toolkit 11 Jan '14

11 Jan '14

#1514: Kranc's Differencing.h fails to compile if KRANC_DIFF_FUNCTIONS is defined --------------------+------------------------------------------------------- Reporter: rhaas | Owner: hinder Type: defect | Status: new Priority: minor | Milestone: Component: Kranc | Version: development version Keywords: | --------------------+------------------------------------------------------- the error is not passing the correct number of arguments: {{{ In file included from /mnt/data/rhaas/postdoc/gr/ET_trunk/configs/sim/build/ML_BSSN/ML_BSSN_Advect.cc:14:0: /mnt/data/rhaas/postdoc/gr/ET_trunk/arrangements/McLachlan/ML_BSSN/src/Differencing.h: In function 'double PDupwindNthfdOrder23_impl(const double*, double, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t)': /mnt/data/rhaas/postdoc/gr/ET_trunk/arrangements/McLachlan/ML_BSSN/src/Differencing.h:1043:56: error: too few arguments to function 'double PDupwindNthfdOrder22_impl(const double*, double, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t, ptrdiff_t)' return PDupwindNthfdOrder22_impl(u, pm1o2dz, cdk, cdj); ^ /mnt/data/rhaas/postdoc/gr/ET_trunk/arrangements/McLachlan/ML_BSSN/src/Differencing.h:884:18: note: declared here static CCTK_REAL PDupwindNthfdOrder22_impl(const CCTK_REAL* restrict const u, const CCTK_REAL pm1o2dy, const ptrdiff_t cdj, const ptrdiff_t cdk, const ptrdiff_t dir1, const ptrdiff_t dir2, const ptrdiff_t dir3) ^ }}} which indeed does not pass any of dir1 -- dir3. Nothing currently uses KRANC_DIFF_FUNCTIONS however so this is a bug in unused code. To reproduce disable UseVectors in McLachlan_BSSN.m and add {{{ #define KRANC_DIFF_FUNCTIONS }}} at the top of arrangements/McLachlan/ML_BSSN/src/Differencing.h once Kranc finishes. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1514> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 2

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac January 2014