#641: Parameter files and thornlists could be tested as part of the release
process
-------------------------+--------------------------------------------------
Reporter: hinder | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2012_05
Component: Other | Version:
Keywords: |
-------------------------+--------------------------------------------------
There are a number of parameter files and thornlists included as examples
with thorns in the ET, and in Cactus. Would it be feasible to have these
tested as part of the release process? For example, they should run
without crashing or missing thorns, should not trigger NaNs etc, and we
should minimise any warnings that are emitted. It would be nice to
automate this, though it probably requires a cluster, so would be distinct
from the usual test suite procedure, due to requiring more memory than
tests.
Something to think about for the next release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/641>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1762: thorn lists in utils refer to old svn repositories
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2015_05
Component: Other | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
The thornlists in https://bitbucket.org/cactuscode/utilities.git refer to
the old Subversion repositories. This should be fixed before the next
release.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1762>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#697: Repository and thorn names cannot be different
---------------------------+------------------------------------------------
Reporter: eschnett | Owner: eric9
Type: defect | Status: new
Priority: critical | Milestone:
Component: GetComponents | Version:
Keywords: |
---------------------------+------------------------------------------------
I am accessing some thorns stored in git repositories at bitbucket.org,
which insists that all repository names are all lower case. I don't know
how to specify this in GetComponents. When I say
!TARGET = $ARR
!TYPE = git
!URL = git@bitbucket.org:user/thorn.git
!AUTH_URL = git@bitbucket.org:user/thorn.git
!CHECKOUT =
Arrangement/Thorn
then GetComponents does not create a symbolic link from Thorn to
../../repos/thorn, but to ../../repos/thorn/Arrangement/Thorn instead. How
do I avoid this?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/697>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#241: Thorns should be able to specify implementation versions, and other thorns
should be able to depend on those
-------------------------+--------------------------------------------------
Reporter: knarf | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Cactus | Version:
Keywords: |
-------------------------+--------------------------------------------------
Cactus thorns implement 'implementations', and other thorns can then
depend on particular implementations being present. However, quite often
those are updated, and incompatibilities occur. Usually this is resolved
by the developer in both thorns - the implementing and the using thorn.
However, a user might just update one of them, and Cactus would not catch
this error. Thus, I suggest to think about, and implement how to:
- specify implementation versions
e.g. IMPLEMENTS: Cactus (4.0)
The version string within () would have be sorted in an intelligent way
to allow
comparisons [1].
- specify dependencies on particular versions of other implementations
In particular I suggest the following dependencies: depends, and
conflicts, both
with comparisons < <= == >= > !=
e.g. DEPENDS: Cactus (>= 4.0)
DEPENDS: BadImplementation (!=3.14) <-- this introduces a
dependency
CONFLICTS: BadImplementation (==3.14) <-- this doesn't introduce
a depencency
[1] First the initial part of each string consisting entirely of non-digit
characters is determined. These two parts (one of which may be empty) are
compared lexically. If a difference is found it is returned. The lexical
comparison is a comparison of ASCII values modified so that all the
letters sort earlier than all the non-letters. Then the initial part of
the remainder of each string which consists entirely of digit characters
is determined. The numerical values of these two parts are compared, and
any difference found is returned as the result of the comparison. For
these purposes an empty string (which can only occur at the end of one or
both version strings being compared) counts as zero.
These two steps (comparing and removing initial non-digit strings and
initial digit strings) are repeated until a difference is found or both
strings are exhausted.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/241>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1796: Include IllinoisGRMHD into the Toolkit, as an Arrangement
-----------------------------------+----------------------------------------
Reporter: zachetie@… | Owner: Zachariah Etienne
Type: enhancement | Status: new
Priority: major | Milestone: ET_2015_11
Component: EinsteinToolkit thorn | Version: development version
Keywords: GRMHD IllinoisGRMHD |
-----------------------------------+----------------------------------------
IllinoisGRMHD, an open-source, compact rewrite of the Illinois NR group's
GRMHD code, has been graciously hosted by the ET community in its
BitBucket repo for more than a year, under the EinsteinEvolve arrangement.
This ticket requests official inclusion of an updated IllinoisGRMHD and
closely-related thorns into the ET, as an arrangement.
IllinoisGRMHD brings a number of key new features to the Toolkit,
including:
1) a staggered, vector-potential-based, AMR-compatible GRMHD scheme that
automatically preserves divergenceless B-fields without the need for
specialized interpolation schemes or divergence cleaning.
2) excision-less, robust modeling of GRMHD flows into black hole interiors
3) a highly-robust conservative-to-primitive solver, which checks the
physicality of the conservative variables *prior* to inversion, and
modifies them minimally to restore physicality.
The proposed arrangement will include:
1) IllinoisGRMHD: Core GRMHD evolution routines, some significant bugfixes
since the original version currently in the ET's bitbucket repo; about
3,400 lines of code (cloc)
2) ID_converter_ILGRMHD: Converts HydroBase variables into variables
IllinoisGRMHD can read (e.g., IllinoisGRMHD uses a velocity definition
consistent with the magnetic induction equation, not the Valencia
formulation); about 209 lines of code (cloc)
3) convert_to_HydroBase: Does the reverse of ID_converter_ILGRMHD, needed
for compatibility with HydroBase-based analysis thorns; 126 lines of code.
All codes are written in C99 and are fully OpenMP-ified. You can read more
about IllinoisGRMHD in its code announcement paper (CQG in press):
http://arxiv.org/abs/1501.07276
Additionally, a Guide to Getting Started with IllinoisGRMHD has also been
written and is available at the IllinoisGRMHD webpage:
http://math.wvu.edu/~zetienne/ILGRMHD/
You may now download all three of these thorns (licensed GNU GPL v2 or
higher) from:
math.wvu.edu/~zetienne/IllinoisGRMHD_arrangement_July_20_2015.tar.gz
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1796>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1815: simfactory: sim show-output selects inactive, queued restart
------------------------+---------------------------------------------------
Reporter: knarf | Owner:
Type: defect | Status: new
Priority: minor | Milestone: ET_2015_11
Component: SimFactory | Version: development version
Keywords: |
------------------------+---------------------------------------------------
{{{
sim show-output NAME
}}}
currently selects the 'maximum' restart for output, which in case of
queued up restarts is one that isn't (yet) running. It should select the
currently active restart (if there is one), given that this version of
simfactory is going to be retired anyway ....
The patch could probably be done 'nicer', but this is the minimally
invasive version.
Patch:
{{{
diff --git a/lib/sim-manage.py b/lib/sim-manage.py
index 87a26fd..c0e8343 100755
--- a/lib/sim-manage.py
+++ b/lib/sim-manage.py
@@ -300,7 +300,12 @@ def command_show_output():
if simenv.OptionsManager.HasOption('restart-id'):
restart_id = simenv.OptionsManager.GetOption('restart-id')
else:
- restart_id = restartlib.GetMaxRestartID(simulationName)
+ restart = simrestart.SimRestart()
+ restart.load(simulationName)
+ restart_id = restartlib.GetActiveRestartId(restart)
+ restart.done()
+ if (restart_id == None):
+ restart_id = restartlib.GetMaxRestartID(simulationName)
restart = simrestart.SimRestart()
ret = restart.load(simulationName, restart_id)
}}}
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1815>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1814: Make git repository names conform to Cactus CamelCase name convention.
-------------------------+--------------------------------------------------
Reporter: bmundim | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone: ET_2015_11
Component: Other | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
https://bitbucket.org/einsteintoolkit/manifest/pull-requests/4/make-git-
repository-names-conform-to/diff
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1814>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1794: Backport MPI detect.pl changes from development to release version
----------------------+-----------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: Other | Version: development version
Keywords: backport |
----------------------+-----------------------------------------------------
According to the ET mailing list discussion at
http://lists.einsteintoolkit.org/pipermail/users/2015-July/004312.html,
the ET does not build on Mac OS with MacPorts in the released version,
probably due to changes in MacPorts since the release. The fix was
committed to the MPI thorn detect.pl script and needs to be backported to
the release. Comer Duncan confirms that this fixes the problem. The
required commit seems to be
http://git.barrywardell.net/?p=arrangements/ExternalLibraries/MPI.git;a=blo….
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1794>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1802: move AEIThorns into git repositories
-----------------------------------------------------------------------------+
Reporter: rhaas | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: ADMMass AEILocalInterp PunctureTracker SystemStatistics Trigger |
-----------------------------------------------------------------------------+
Currently the ET contains the following AEI thorns:
* AEIThorns/ADMMass
* AEIThorns/AEILocalInterp
* AEIThorns/PunctureTracker
* AEIThorns/SystemStatistics
* AEIThorns/Trigger
since the AEI would like to shut down the svn server (or at least change
it to read only mode) it would be good to move these thorns into:
EinsteinAnalysis:: ADMMass PunctureTracker
CactusUtils:: SystemStatistics Trigger (need change of license to LGPL)
Numerical:: AEILocalInterp (license must stay GPL)
For the ET thorns Barry kindly did the conversion using a set of scripts
of his. If you were to make the scripts accessible (or give the whole
thing a try yourself), then this could be started as soon as the authors
(Ian and Frank are main authors if SystemStatistics and Trigger, Erik,
Barry and I contributed, I am fine with a license change) agree to the
license change where required.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1802>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1803: Move LSUThorns into git repositories at Bitbucket
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1803>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit