Trac January 2017

trac@lists.einsteintoolkit.org

1 participants
99 discussions

[Einstein Toolkit] #1994: PITTNUllCode/SphericalHarmonicRecon uses HDF5 1.8 functions
by Einstein Toolkit 11 Jan '17

11 Jan '17

#1994: PITTNUllCode/SphericalHarmonicRecon uses HDF5 1.8 functions ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: SphericalHarmonicRecon | ------------------------------------+--------------------------------------- SphericalHarmonicRecon's Recon.cc file uses H5LTread_dataset_double (https://support.hdfgroup.org/HDF5/doc/HL/RM_H5LT.html#H5LTread_dataset_doub…) which is only available in the hdf5 hl level library which is only provided in hdf5 1.8.7. Nothing in the ET states that HDF5 1.8 is required. This can be fixed my making sure that hdf5_hl is included in HDF5_LIBS which also will make compilation fail if the library in indeed missing. We should decide whether we want to bump ExternalLibraries/HDF5's version number and have it itself check for HDF5 1.8 in which case thorns can rely on this version being present (if they require a new enough HDF5 ExternalLibraries) or provide workarounds in Reconn.cc. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1994> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 5

[Einstein Toolkit] #1993: fix piecewise polytropes in LORENE1
by Einstein Toolkit 10 Jan '17

10 Jan '17

#1993: fix piecewise polytropes in LORENE1 -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: LORENE | -----------------------------------+---------------------------------------- LORENE1 constains a bug when handling piecewise polytropes that was reported to the LORENE developers by Sebastiano Bernuzzi et al. However the fix is only in our LORENE2 ExternalLibrary (after the incompatible file format change) so this patch aim to import Sebastiano's original fix into LORENE as patch. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1993> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1973: Hydro_Analysis: fix scheduling to access grid functions in local mode
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: HydroAnalysis | -----------------------------------+---------------------------------------- HydroAnalysis tried to execute some routines accesses grid function data while in global mode. This leads to incorrect behaviour (namely nothing is done) and also LoopControl asserting about nonsensical imin/imax values. This seems to have been in HydroAnalysis from the very beginning. Pull request is here: https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/4 /hydro_analysis-fix-scheduling-to-access/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1973> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 4

[Einstein Toolkit] #1928: support make parallel options in simfactory
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1928: support make parallel options in simfactory -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: SimFactory | Version: development version Keywords: | -------------------------+-------------------------------------------------- Pull request https://bitbucket.org/simfactory/simfactory2/pull-requests/11 /parallel-make/diff adds a --jobs option to sim build that sets a @MAKEJOBS@ replacement so that one can use make -j @MAKEJOBS@ in machine definitons files and let the user choose the number of make jobs when compiling -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1928> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 15

[Einstein Toolkit] #1975: Cactus: mark routines used by DECLARE_CCTK_ARGUMENTS as pure
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1975: Cactus: mark routines used by DECLARE_CCTK_ARGUMENTS as pure -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: Cactus | Version: development version Keywords: | -------------------------+-------------------------------------------------- Currently CCTK_DECLARE_ARGUMENTS contains code like this: {{{ static int varindex = -100; if (varindex == -100) varindex = CCTK_VarIndex("thorn::var"); var = CCTKi_VarDataPtr(cctGH, 0, varindex); }}} ie it calls the two functions VarIndex and VarDataPtr for all variables that the thorn defines or inherits. This happens no matter whether the variable "var" is later used in the routine or not since the two functions could have side effects. The patch in the pull requests declares the functions "pure", ie side effect free (https://gcc.gnu.org/onlinedocs/gcc /Common-Function-Attributes.html#index-functions-that-have-no-side- effects-3320) which lets the compiler remove the call to the functions if their result is not used. Technically CCTK_VarIndex does have a side effect: it can call CCTK_VWarn (at level 6) for unknown variable names though the result does not affect the computation. CCTKi_VarDataPtr is explicitly designed to be side-effect free. The patch would lead to slightly smaller code and possible slightly faster code as well when CCTK_DECLARE_ARGUMENTS is used often or with many inherited variables. The pull request is at https://bitbucket.org/cactuscode/cactus/pull- requests/34/cactus-mark-routines-used-by/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1975> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 4

[Einstein Toolkit] #1861: NaNChecker: do not report missing storage when checking "all" variables
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1861: NaNChecker: do not report missing storage when checking "all" variables -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: enhancement | Status: new Priority: minor | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: Formaline | -----------------------------------+---------------------------------------- pull request at https://bitbucket.org/cactuscode/cactusutils/pull- requests/6/nanchecker-do-not-report-missing-storage/diff removes lots of output about variables having no storage if checking all variables for NaN is requested. Since "all" variables means "all that could be defined" and not "all that are turned on" there is always lots of clutter when "all" is used. -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1861> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1979: EOS_Omni: read add option to read EOS table on a single process
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1979: EOS_Omni: read add option to read EOS table on a single process ----------------------+----------------------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: minor | Milestone: Component: Other | Version: development version Keywords: EOS_Omni | ----------------------+----------------------------------------------------- This re-activates the functionality from e7eb9a5 which was accidentally removed in the meantime. Pull request is in https://bitbucket.org/einsteintoolkit/einsteineos/pull-requests/1 /eos_omni-read-add-option-to-read-eos-table/diff This is a bugfix since the parameters for the functionality were never removed, this is minor since to code works perfectly fine as is, it is just slower (and ignores those parameters). -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1979> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

[Einstein Toolkit] #1977: CarpetIOHDF5: fix numbering of files when there are fewer than ioprocs than mpi ranks, create output directory on all ranks
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1977: CarpetIOHDF5: fix numbering of files when there are fewer than ioprocs than mpi ranks, create output directory on all ranks --------------------+------------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: defect | Status: new Priority: minor | Milestone: Component: Carpet | Version: development version Keywords: | --------------------+------------------------------------------------------- The first patch makes it possible to read the generated output files in VisIt without having to rename them since they are now (again) names var.file_0.h5 var.file_1.h5 ... var.file_<nioprocs>.h5 rather than eg var.file_0.h5 var.file_4.h5. The second one matches what out_vars does. Pull request is at: https://bitbucket.org/eschnett/carpet/pull-requests/15/carpetiohdf5-minor- fixes/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1977> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 5

[Einstein Toolkit] #1976: CarpetIOHDF5: add option to have one output file per process
by Einstein Toolkit 01 Jan '17

01 Jan '17

#1976: CarpetIOHDF5: add option to have one output file per process -------------------------+-------------------------------------------------- Reporter: rhaas | Owner: eschnett Type: enhancement | Status: new Priority: major | Milestone: Component: Carpet | Version: development version Keywords: | -------------------------+-------------------------------------------------- This is useful when running on systems where many files slow down file access (ie lustre file systems) and where there are many hdf5 output files per MPI rank. The code combines all output into a file $parfile.h5 which is currently hard-coded. https://bitbucket.org/eschnett/carpet/pull-requests/14/carpetiohdf5-add- option-to-have-one-output/diff -- Ticket URL: <https://trac.einsteintoolkit.org/ticket/1976> Einstein Toolkit <http://einsteintoolkit.org> The Einstein Toolkit

1 3

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac January 2017