[Einstein Toolkit] #1973: Hydro_Analysis: fix scheduling to access grid functions in local mode
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode -----------------------------------+---------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: new Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Keywords: HydroAnalysis | -----------------------------------+---------------------------------------- HydroAnalysis tried to execute some routines accesses grid function data while in global mode. This leads to incorrect behaviour (namely nothing is done) and also LoopControl asserting about nonsensical imin/imax values.
This seems to have been in HydroAnalysis from the very beginning.
Pull request is here: https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/4 /hydro_analysis-fix-scheduling-to-access/diff
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroAnalysis ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: new => review
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroAnalysis ------------------------------------+---------------------------------------
Comment (by rhaas):
Anyone? This is a bug after all which makes Hydro_Analysis' non- functional.
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: review Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: | Keywords: HydroAnalysis ------------------------------------+---------------------------------------
Comment (by rhaas):
Unless there are objections I will apply this the day after the release.
#1973: Hydro_Analysis: fix scheduling to access grid functions in local mode ------------------------------------+--------------------------------------- Reporter: rhaas | Owner: Type: defect | Status: closed Priority: major | Milestone: Component: EinsteinToolkit thorn | Version: development version Resolution: fixed | Keywords: HydroAnalysis ------------------------------------+--------------------------------------- Changes (by rhaas):
* status: review => closed * resolution: => fixed
Comment:
Applied in git hash cb12bfac of einsteinanalysis.
trac@lists.einsteintoolkit.org
-
Einstein Toolkit