#2035: NaNChecker should not use integer division
-------------------------+--------------------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: Other | Version: development version
Keywords: |
-------------------------+--------------------------------------------------
I profiled the NaNChecker, and it seems as if it spent two thirds of its
time performing integer division. I assume that these are the integer
divisions where the code re-calculates the {{{(i,j,k)}}} triple from a
linear index. This part of the code could easily be rewritten.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2035>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2036: ML_ADMConstraints is not vectorized
-----------------------------------+----------------------------------------
Reporter: eschnett | Owner:
Type: enhancement | Status: new
Priority: minor | Milestone:
Component: EinsteinToolkit thorn | Version: development version
Keywords: |
-----------------------------------+----------------------------------------
I see that the thorn ML_ADMConstraints is not vectorized. Doing so should
be straightforward, requiring only changing one or two lines in the Kranc
script and regenerating the code.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2036>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2034: CarpetLib's defs.hh and defs.cc file don't encapsulate defintions in a
namespace
--------------------+-------------------------------------------------------
Reporter: rhaas | Owner: eschnett
Type: defect | Status: new
Priority: minor | Milestone:
Component: Carpet | Version: development version
Keywords: |
--------------------+-------------------------------------------------------
CarpetLib's defs.hh and defs.cc do not (as far as I can tell) contain any
namespace enclosing the defined functions so that they all end up in the
global namespace eg its ipow and also its get_poison_value function. It
should however either put them into a CarpetLib namespace or prefix them
by CarpetLib_ like other symbols with global linkage.
This apparently has always been the case at least far back as importing
carpet-5 into git (5 years ago).
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2034>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2033: BBH gallery page has missing images
-------------------------------------+--------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone:
Component: EinsteinToolkit website | Version: development version
Keywords: |
-------------------------------------+--------------------------------------
The BBH gallery page (http://einsteintoolkit.org/gallery/bbh/index.html)
on the new website has two images (hright.jpg and Strain_sm.png) missing.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2033>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2031: Option to disable Piraha
---------------------+------------------------------------------------------
Reporter: sbrandt | Owner:
Type: defect | Status: new
Priority: unset | Milestone:
Component: Other | Version: development version
Keywords: |
---------------------+------------------------------------------------------
On the 4/24/2017 it was discussed whether we should have both Piraha and
the old parser in the new release. It was decided that it should be
possible to disable Piraha, otherwise doing it twice provdes little
benefit. Therefore, it should be possible to disable Piraha.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2031>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#2028: ADMConstraints param.ccl fails to parse
----------------------+-----------------------------------------------------
Reporter: hinder | Owner:
Type: task | Status: new
Priority: optional | Milestone:
Component: Cactus | Version: development version
Keywords: |
----------------------+-----------------------------------------------------
arrangements/EinsteinAnalysis/ADMConstraints/param.ccl fails to parse with
the new parser, giving the error
{{{
CST ERROR IN FILE
'/home/ianhin/Cactus/EinsteinToolkitGit/arrangements/EinsteinAnalysis/ADMConstraints/param.ccl'
ERROR ON LINE 70:
string excision_mask_name "The name of the bitfield chosen for excision"
{
:: "Anything goes"
^
| here
FOUND CHARACTER: ':'
EXPECTED CHARACTER(S): DOUBLE_QUOTE, 'A' to 'Z', '\', '_', 'a' to 'z', '}'
Parse Error at
/home/ianhin/Cactus/EinsteinToolkitGit/lib/sbin/parameter_parser.pl line
51.
main::create_parameter_database('TwoPunctures',
'/home/ianhin/Cactus/EinsteinToolkitGit/arrangements/EinsteinI...',
'pciutils',
'/home/ianhin/Cactus/EinsteinToolkitGit/arrangements/ExternalL...',
'CoordBase',
'/home/ianhin/Cactus/EinsteinToolkitGit/arrangements/CactusBas...',
'ADMConstraints',
'/home/ianhin/Cactus/EinsteinToolkitGit/arrangements/EinsteinA...',
'OpenBLAS', ...) called at
/home/ianhin/Cactus/EinsteinToolkitGit/lib/sbin/CST line 142
make[1]: *** [/home/ianhin/Cactus/EinsteinToolkitGit/configs/gw150914
/config-data/make.thornlist] Error 255
make: *** [gw150914] Error 2
}}}
I'm pretty sure this violates the description of the allowed values for
"parameter values" in
http://einsteintoolkit.org/usersguide/UsersGuidech12.html#x17-191000D2.3.
I have corrected the param.ccl file. I am mentioning it here in case
anyone thinks that the parser should be extended to support this incorrect
usage, since it was accepted by the previous version. I don't think that
this is worth doing.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/2028>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#1916: GetComponents checks out git repositories serially
---------------------------+------------------------------------------------
Reporter: hinder | Owner:
Type: defect | Status: new
Priority: major | Milestone: ET_2016_11
Component: GetComponents | Version: development version
Keywords: |
---------------------------+------------------------------------------------
When called with --parallel, GetComponents still checks out git
repositories serially. This may have been introduced with #83, but there
is no information in that ticket about what was done.
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/1916>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit
#614: relative tolerence in test.ccl of QuasiLocalMeasures very high
-----------------------------------+----------------------------------------
Reporter: rhaas | Owner:
Type: defect | Status: new
Priority: optional | Milestone:
Component: EinsteinToolkit thorn | Version:
Keywords: |
-----------------------------------+----------------------------------------
LSUThorns/QuasiLocalMeasures/test/test.ccl curerntly reads:
{{{
ABSTOL 1.e-7
RELTOL 1.e+5
}}}
I am curious: is the relative tolerance of 10,000 intentional or should it
have been 1e-5 instead?
--
Ticket URL: <https://trac.einsteintoolkit.org/ticket/614>
Einstein Toolkit <http://einsteintoolkit.org>
The Einstein Toolkit