#2546: CarpetIOHDF5: Don't set "delta" attribute to zero for zero-width components
Reporter: Erik Schnetter
Status: closed
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component:
Changes (by Erik Schnetter):
status: closed (was resolved)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2546/carpetiohdf5-dont…
#2546: CarpetIOHDF5: Don't set "delta" attribute to zero for zero-width components
Reporter: Erik Schnetter
Status: resolved
Milestone:
Version: development version
Type: enhancement
Priority: minor
Component:
Changes (by Erik Schnetter):
status: resolved (was open)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2546/carpetiohdf5-dont…
#2548: Compilation failure: "const" assignment in LoopControl/src/loopcontrol.cc
Reporter: Bernard Kelly
Status: open
Milestone: ET_2021_05
Version: ET_2021_05
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
I can compile fine with Intel 17 on Blue Waters if I use a modern enough C\+\+ library. However if I force it to use gcc 4.3 by using --gxx-name then I get the same error that you see:
```
COMPILING Carpet/LoopControl/src/loopcontrol.cc
/mnt/a/u/staff/rhaas/ET_Next/arrangements/Carpet/LoopControl/src/loopcontrol.cc(70): error: function call must have a constant value in a constant expression
lc_random.max() - lc_random.min() + 1;
^
/mnt/a/u/staff/rhaas/ET_Next/arrangements/Carpet/LoopControl/src/loopcontrol.cc(70): error: function call must have a constant value in a constant expression
lc_random.max() - lc_random.min() + 1;
^
compilation aborted for /mnt/a/u/staff/rhaas/ET_Next/configs/sim-intel/build/LoopControl/loopcontrol.cc (code 2)
```
so both this and #2547 are due to a too old stdc\+\+ library. Trying to work around this by using `minstd_rand::max()` does not work and gives:
```plaintext
COMPILING Carpet/LoopControl/src/loopcontrol.cc
/mnt/a/u/staff/rhaas/ET_Next/arrangements/Carpet/LoopControl/src/loopcontrol.cc(70): error: a nonstatic member reference must be relative to a specific object
minstd_rand::max() - minstd_rand::min() + 1;
^
/mnt/a/u/staff/rhaas/ET_Next/arrangements/Carpet/LoopControl/src/loopcontrol.cc(70): error: a nonstatic member reference must be relative to a specific object
minstd_rand::max() - minstd_rand::min() + 1;
^
compilation aborted for /mnt/a/u/staff/rhaas/ET_Next/configs/sim-intel/build/LoopControl/loopcontrol.cc (code 2)
```
indicating that the library does not declare the function correctly as a static class function and indeed digging into the header files on BlueWaters shows it to be defined as:
```c++
result_type
max() const
{ return __m - 1; }
```
A workaround would be to remove `constexpr` from this line of code but given that thorn `Vectors` also fails with due to the same old C\+\+ library, I am not sure if the workaround would help a lot \(would only help in situations where `LoopControl` but not `Vectors` is used\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2548/compilation-failu…
#2407: Cactus math work-arounds break CarpetX reduction operators
Reporter: Erik Schnetter
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: Cactus
Comment (by Roland Haas):
Comet had been retired so is no longer an issue.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2407/cactus-math-work-…
#2534: Evolution of grid arrays with Mol no longer works
Reporter:
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Carpet
Comment (by Roland Haas):
Somewhat unrelated: instead of the current workaround for arrays of
> The kludge was to check to see that if the "correct" component is being updated, and if not, re-write the old values of the grid array\).
wouldn’t it be possible ot make this work by scheduling the RHS function as `GLOBAL` ? That way it would only execute once per iteration and not once per iteration per refinement level. MoL would still update the state vector for the array but b/c it initializes the RHS to zero before the `CalcRHS` schedule group the fact that the RHS routine does not run would leave the RHS unchanged \(ie 0\) and thus effectively no update would be done.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2534/evolution-of-grid…
#2534: Evolution of grid arrays with Mol no longer works
Reporter:
Status: new
Milestone:
Version: development version
Type: bug
Priority: major
Component: Carpet
Comment (by Roland Haas):
I cannot reproduce this with the provided thorn and parfile. The parfile seems to be for a different setup. Eg the thorn name differs, the thorn in the parfile has parameters while the thorn in the tarball does not, the parfile contains `@FOO@` placeholders, the parfile has no mesh refinement or MoL active but the ticket description mentions both being required.
I have a guess what is going on, but without a reproducer will not be able to make headway fixing this.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2534/evolution-of-grid…