Trac October 2022

trac@lists.einsteintoolkit.org

1 participants
87 discussions

#2174: Test "Multi Patch Scalar Wave Equation" example
by Roland Haas 10 Oct '22

10 Oct '22

#2174: Test "Multi Patch Scalar Wave Equation" example Reporter: Roland Haas Status: open Milestone: ET_2022_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was closed) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-…

1 0

#2655: Incorrect assert in Carpet/src/modes.cc
by Samuel Cupp 08 Oct '22

08 Oct '22

#2655: Incorrect assert in Carpet/src/modes.cc Reporter: Samuel Cupp Status: resolved Milestone: Version: development version Type: bug Priority: major Component: Carpet Changes (by Samuel Cupp): status: resolved (was new) Comment (by Samuel Cupp): Fix merged into master. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2655/incorrect-assert-…

1 0

#2655: Incorrect assert in Carpet/src/modes.cc
by Samuel Cupp 07 Oct '22

07 Oct '22

#2655: Incorrect assert in Carpet/src/modes.cc Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet Comment (by Samuel Cupp): I made a [PR](https://bitbucket.org/eschnett/carpet/pull-requests/55/fix-to-incorrect…. Please review and apply. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2655/incorrect-assert-…

1 0

#2655: Incorrect assert in Carpet/src/modes.cc
by Roland Haas 07 Oct '22

07 Oct '22

#2655: Incorrect assert in Carpet/src/modes.cc Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet Comment (by Roland Haas): that would be very wrong. It should be: ``` assert(cctkGH->cctk_tile_min[d] == 0); assert(cctkGH->cctk_tile_max[d] == cctkGH->cctk_lsh[d]); ``` as far as I can tell \(Carpet not actually supporting tiles\). Deleting is not an option. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2655/incorrect-assert-…

1 0

#2655: Incorrect assert in Carpet/src/modes.cc
by Samuel Cupp 07 Oct '22

07 Oct '22

#2655: Incorrect assert in Carpet/src/modes.cc Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet Comment (by Samuel Cupp): @{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} has suggested that perhaps it can simply be deleted. @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} @{557058:56049c54-f8c2-4b6c-9b88-ab697c967495} Do either of you have opinions on this? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2655/incorrect-assert-…

1 0

#2655: Incorrect assert in Carpet/src/modes.cc
by Samuel Cupp 07 Oct '22

07 Oct '22

#2655: Incorrect assert in Carpet/src/modes.cc Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet In Carpet/src/modes.cc, there is a block of asserts ``` assert(cctkGH->cctk_lsh[d] >= 0); assert(cctkGH->cctk_lsh[d] <= cctkGH->cctk_gsh[d]); assert(cctkGH->cctk_lbnd[d] >= 0); assert(cctkGH->cctk_lbnd[d] <= cctkGH->cctk_ubnd[d] + 1); assert(cctkGH->cctk_ubnd[d] < cctkGH->cctk_gsh[d]); assert(cctkGH->cctk_lbnd[d] + cctkGH->cctk_lsh[d] - 1 == cctkGH->cctk_ubnd[d]); assert(cctkGH->cctk_lbnd[d] <= cctkGH->cctk_ubnd[d] + 1); assert(cctkGH->cctk_lsh[d] <= cctkGH->cctk_ash[d]); #ifdef CCTK_HAVE_CGH_TILE assert(cctkGH->cctk_tile_min[d] == 0); assert(cctkGH->cctk_tile_max[d] = cctkGH->cctk_lsh[d]); #endif assert(cctkGH->cctk_from[d] >= 0); assert(cctkGH->cctk_from[d] <= cctkGH->cctk_to[d]); assert(cctkGH->cctk_to[d] <= cctkGH->cctk_lsh[d]); ``` Inside the #ifdef, the second assert ``` assert(cctkGH->cctk_tile_max[d] = cctkGH->cctk_lsh[d]); ``` is setting the value instead of doing a comparison. This is definitely wrong and should be changed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2655/incorrect-assert-…

1 0

#2630: WaveMoL example computes energy from unsynchronized grid variables
by Roland Haas 07 Oct '22

07 Oct '22

#2630: WaveMoL example computes energy from unsynchronized grid variables Reporter: Roland Haas Status: closed Milestone: Version: Type: bug Priority: major Component: Changes (by Roland Haas): status: closed (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2630/wavemol-example-c…

1 0

#2630: WaveMoL example computes energy from unsynchronized grid variables
by Roland Haas 07 Oct '22

07 Oct '22

#2630: WaveMoL example computes energy from unsynchronized grid variables Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Applied as git hash [890b57e](https://bitbucket.org/cactuscode/cactusexamples/commits/890b57e7d0… "WaveMoL: compute energy only after field is valid everywhere" of [cactusexamples](https://bitbucket.org/cactuscode/cactusexamples) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2630/wavemol-example-c…

1 0

#2639: CarpetLib internal error with PreSync and analysis thorns
by Roland Haas 06 Oct '22

06 Oct '22

#2639: CarpetLib internal error with PreSync and analysis thorns Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet Comment (by Roland Haas): Great. I will use the one you already included then. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2639/carpetlib-interna…

1 0

#2639: CarpetLib internal error with PreSync and analysis thorns
by Samuel Cupp 06 Oct '22

06 Oct '22

#2639: CarpetLib internal error with PreSync and analysis thorns Reporter: Samuel Cupp Status: new Milestone: Version: development version Type: bug Priority: major Component: Carpet Comment (by Samuel Cupp): Roland, you asked for a parfile to reproduce the behavior, but it looks like I included one in the original ticket. To have the reads/writes for BaikalVacuum, you will want to checkout my scupp/BaikalRDWR branch of wvuthorns. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2639/carpetlib-interna…

1 0

← Newer
1
2
3
4
5
6
7
8
9
Older →

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac October 2022