Trac February 2022

trac@lists.einsteintoolkit.org

1 participants
53 discussions

#2531: remove non piraha parser from Flesh
by William Gabella 18 Feb '22

18 Feb '22

#2531: remove non piraha parser from Flesh Reporter: Roland Haas Status: new Milestone: Version: development version Type: enhancement Priority: trivial Component: Comment (by William Gabella): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…

1 0

#2531: remove non piraha parser from Flesh
by William Gabella 17 Feb '22

17 Feb '22

#2531: remove non piraha parser from Flesh Reporter: Roland Haas Status: new Milestone: Version: development version Type: enhancement Priority: trivial Component: Comment (by William Gabella): Also re-compiled and ran the testsuites make sim-testsuite the first time running it was very slow and essentially stopped making much progress at GiRaFFE\_tests\_ThreeWave $from GiRaFFE$, I think. Stopped and re-ran and that went smoothly. The results are ```none Summary for configuration sim Time -> Thu Feb 17 06:38:31 PM CST 2022 Host -> fedora Processes -> 2 User -> gabella Total available tests -> 346 Unrunnable tests -> 14 Runnable tests -> 332 Total number of thorns -> 258 Number of tested thorns -> 99 Number of tests passed -> 330 Number passed only to set tolerance -> 193 Number failed -> 2 Tests passed: tov (from ADMMass) tov_carpet (from ADMMass) ... teukolskyParity (from WeylScal4) magnetized_explosionTOV (from particle_tracerET) magnetized_explosionTOV (from smallbPoynET) Tests failed: Kerr-Cartoon (from AHFinderDirect) Kerr-Cartoon-EE (from AHFinderDirect) ``` ‌ Curiously the previous tests had no failures, 2 Feb 2022, posted above. The reports are AHFinderDirect: Kerr-Cartoon Failure: Cactus exited with error code 1. AHFinderDirect: Kerr-Cartoon-EE Failure: Cactus exited with error code 17. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…

1 0

#2531: remove non piraha parser from Flesh
by William Gabella 17 Feb '22

17 Feb '22

#2531: remove non piraha parser from Flesh Reporter: Roland Haas Status: new Milestone: Version: development version Type: enhancement Priority: trivial Component: Comment (by William Gabella): Created the gabella/piraha branch via BitBucket, re-installed the master on my laptop, checked out the gabella/piraha branch putting in the edited ParseFile.c ---with the removed non-Piraha code---into the directory Cactus/repos/flesh/src/util . For the git push, required I set the upstream git push --set-upstream origin gabella/piraha and logged in with username and password, despite having SSH keys set. Also saw a warning about username logins being disabled and app passwords being necessary, oh, for HTTPS logins. Should have used the SSH address for the repos. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…

1 0

#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed
by Zach Etienne 17 Feb '22

17 Feb '22

#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed Reporter: Zach Etienne Status: new Milestone: Version: development version Type: bug Priority: major Component: Changes (by Zach Etienne): In `Newton.c` , lines 375-376: ``` if (*normres <= tol) return 0; ``` returns from the function after temporary memory for the `Newton()` function has been allocated, but does not free that memory. `valgrind` confirms this issue. I attach an updated version of `Newton.c` that should fix the issue. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2596/einsteininitialda…

1 0

#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed
by Zach Etienne 17 Feb '22

17 Feb '22

#2596: EinsteinInitialData/TwoPunctures: Allocated memory is not freed Reporter: Zach Etienne Status: new Milestone: Version: development version Type: bug Priority: major Component: In `Newton.c` , lines 375-376: ``` if (*normres <= tol) return 0; ``` returns from the function after temporary for the `Newton()` function has been allocated, but does not free the memory. `valgrind` confirms this issue. I attach an updated version of `Newton.c` that should fix the issue. attachment: Newton.c (https://api.bitbucket.org/2.0/repositories/einsteintoolkit/tickets/issues/2…) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2596/einsteininitialda…

1 0

#2392: default values of keyword parameters are not checked to be in the allowed set
by Steven R. Brandt 16 Feb '22

16 Feb '22

#2392: default values of keyword parameters are not checked to be in the allowed set Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: Cactus Comment (by Steven R. Brandt): PR [https://bitbucket.org/cactuscode/cactus/pull-requests/138/get-range-checkin… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2392/default-values-of…

1 0

#1568: Reduce overhead of Formaline
by Roland Haas 14 Feb '22

14 Feb '22

#1568: Reduce overhead of Formaline Reporter: Ian Hinder Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: Cactus Comment (by Roland Haas): [https://bitbucket.org/einsteintoolkit/tickets/issues/1568/reduce-overhead-o… uses GNU ld to include files. Using regular ld one gets something like: ``` rhaas@8992d193:~/tmp$ ld -r -b binary -o foo.o xcts.pdf rhaas@8992d193:~/tmp$ file foo.o foo.o: ELF 64-bit LSB relocatable, x86-64, version 1 (SYSV), not stripped rhaas@8992d193:~/tmp$ nm foo.o 000000000002bebd D _binary_xcts_pdf_end 000000000002bebd A _binary_xcts_pdf_size 0000000000000000 D _binary_xcts_pdf_start ``` but eg the xalt wrapper linker does: ``` rhaas@h2ologin4:~$ ld -r -b binary -o foo.o foo.tar.gz rhaas@h2ologin4:~$ nm foo.o 00000000c0421df1 D _binary__tmp_rhaas_2022_02_14_13_22_52_a8ab3fb3_e7ae_4131_a8a4_7ae6143cb4c6_xalt_o_end 0000000000000481 A _binary__tmp_rhaas_2022_02_14_13_22_52_a8ab3fb3_e7ae_4131_a8a4_7ae6143cb4c6_xalt_o_size 00000000c0421970 D _binary__tmp_rhaas_2022_02_14_13_22_52_a8ab3fb3_e7ae_4131_a8a4_7ae6143cb4c6_xalt_o_start 00000000c0421970 D _binary_foo.tar.gz_end 00000000c0421970 A _binary_foo.tar.gz_size 0000000000000000 D _binary_foo.tar.gz_start ``` ie there is “extra” struff being included. So we must ensure that we use the actual GNU linker. We need a special variable for this since in Cactus `$LD` is usually `$CXX`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1568/reduce-overhead-o…

1 0

#1568: Reduce overhead of Formaline
by Roland Haas 14 Feb '22

14 Feb '22

#1568: Reduce overhead of Formaline Reporter: Ian Hinder Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: Cactus Comment (by Roland Haas): Somewhat similar proposal was in [#2218](https://bitbucket.org/einsteintoolkit/tickets/issues/2218/simplify-including-external-files-in) ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1568/reduce-overhead-o…

1 0

#1568: Reduce overhead of Formaline
by Roland Haas 14 Feb '22

14 Feb '22

#1568: Reduce overhead of Formaline Reporter: Ian Hinder Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: Cactus Comment (by Roland Haas): @{557058:56049c54-f8c2-4b6c-9b88-ab697c967495} says: > i found a way to put binary blobs directly into object files, without generating C code in between. this should speed up generating the Formaline objects for our source code quite a bit. thsi project [https://git.astron.nl/RD/tensor-core-correlator](https://git.astron.nl/RD/t… uses it; look how the \`libtcc/TCcorrelator.cu\` CUDA file is "compiled". ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1568/reduce-overhead-o…

1 0

#2218: Simplify including external files in Formaline
by Roland Haas 14 Feb '22

14 Feb '22

#2218: Simplify including external files in Formaline Reporter: Erik Schnetter Status: duplicate Milestone: Version: development version Type: enhancement Priority: minor Component: EinsteinToolkit thorn Changes (by Roland Haas): status: duplicate (was new) Comment (by Roland Haas): Duplicate of #1568. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2218/simplify-includin…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac February 2022