#2593: `Since this was the default value, setting anyway - please fix!`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
This ticket is \(basically\) a duplicate of #2392 at least if the parameter in question was a “keyword” type parameter \(which was the type I tested before responding to Erik\). Apparently this was to be addressed in ET\_2020\_05 .
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2593/since-this-was-th…
#2593: `Since this was the default value, setting anyway - please fix!`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Erik Schnetter):
I don’t know which parameter caused this. I saw these errors in debug output sent by a collaborator.
Maybe the error message could mention the parameter name and value?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2593/since-this-was-th…
#2531: remove non piraha parser from Flesh
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: trivial
Component:
Comment (by William Gabella):
Passed all tests in make sim-testsuite:
```
Summary for configuration sim
Time -> Wed Feb 2 05:47:18 PM CST 2022
Host -> fedora
Processes -> 2
User -> gabella
Total available tests -> 346
Unrunnable tests -> 14
Runnable tests -> 332
Total number of thorns -> 258
Number of tested thorns -> 99
Number of tests passed -> 332
Number passed only to
set tolerance -> 195
Number failed -> 0
```
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…
#2531: remove non piraha parser from Flesh
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: trivial
Component:
Comment (by William Gabella):
Seems to only affect the ParseFile.c . No other changes.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…
#2593: `Since this was the default value, setting anyway - please fix!`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Steven R. Brandt):
@{557058:56049c54-f8c2-4b6c-9b88-ab697c967495} can you tell me what parameter this was? The CST does have code for checking the default value falls within the allowed range.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2593/since-this-was-th…
#2593: `Since this was the default value, setting anyway - please fix!`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
The default value for a parameter is out of range. Just why default values \(in param.ccl\) are not checked against the allowed range I do not quite know. It is possible that this was too complicated to do at CST time \(b/c parameter ranges can be extended\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2593/since-this-was-th…
#2593: `Since this was the default value, setting anyway - please fix!`
Reporter: Erik Schnetter
Status: new
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
I see many messages `WARNING[L1,P0] (Cactus): Since this was the default value, setting anyway - please fix!` in some simulation output. This message is repeated many times, and there is no other message providing context before or after this message.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2593/since-this-was-th…
#2531: remove non piraha parser from Flesh
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: trivial
Component:
Comment (by William Gabella):
Roland points out the next level is to look for functions in the deleted parts of ParseFile.c that are called from external sources and are ONLY used in the old part of ParseFile.c.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…
#2531: remove non piraha parser from Flesh
Reporter: Roland Haas
Status: new
Milestone:
Version: development version
Type: enhancement
Priority: trivial
Component:
Comment (by William Gabella):
Took this ticket for the Hack-a-thon, 2 Feb 2022. Removing all the local routines, etc, related to the “old way” of parsing the file, and of course keeping the “new way,” with cctk\_PirahaParser\(\) function. This is in Cactus/repos/flesh/src/util/ParseFile.c , as Roland mentions above.
Re-compiling with \(from the Cactus folder\)
```
./simfactory/bin/sim build -j2 --thornlist ../einsteintoolkit.th
```
and watching for the “COMPILING … ParseFile.c” to go by.
And running HelloWorld first, as
```
./simfactory/bin/sim create-run helloworld \
--parfile arrangements/CactusExamples/HelloWorld/par/HelloWorld.par
```
If that is not broke, then finally the testsuite with
```
make sim-testsuite
```
Format for the teststuite is “make <config name>-testsuite. It gave a set of defaults and I chose them all; testing exe/cactus\_sim .
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2531/remove-non-piraha…