#2052: piraha assumes that assert(false) always aborts
Reporter: Roland Haas
Status: open
Milestone:
Version: development version
Type: bug
Priority: minor
Component: Cactus
Comment (by Roland Haas):
@{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} any progress on this?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2052/piraha-assumes-th…
#2696: Update kuibit to 1.4.0
Reporter: Gabriele Bozzola
Status: on hold
Milestone: ET_2023_05
Version:
Type: enhancement
Priority: major
Component:
Changes (by Roland Haas):
status: on hold (was new)
Comment (by Roland Haas):
Sleep until after release and revisit if there are any issues / clusters with old Python anymore where the newest kuibit version cannot be used.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2696/update-kuibit-to-…
#2709: move tov example parfile out of cell in notebook into file in einsteinexamples
Reporter: Roland Haas
Status: resolved
Milestone:
Version:
Type: enhancement
Priority: minor
Component:
Changes (by Roland Haas):
status: resolved (was new)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2709/move-tov-example-…
#2721: Cactus does not detect `gettimeofday` timer
Reporter: Erik Schnetter
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by Roland Haas):
There is one other “odd' uses of `AC_TRY_XXX` in Cactus \(not failures like this one thoug in `CCTK_CHECK_C_INLINE` we have
```
AC_TRY_COMPILE(, [} $ac_kw int foo() {], [cctk_cv_c_inline=$ac_kw; break])
```
which probably would be nicer if it did:
```
AC_TRY_COMPILE($ac_kw int foo(){return 0;}], [], [cctk_cv_c_inline=$ac_kw; break])
```
since it does not “trick” autoconf by closing the autoconf created `main` function with the leading `}`.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…
#2711: attempting to build KadathThorn assumes a git repository
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by tootle):
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Thanks for finding the work around! Based on these changes, I needed to modify the build script for the \`KadathThorn\`.
In [4cca4c8](https://bitbucket.org/fukaws/kadaththorn/commits/4cca4c8a6cd4e4427… I removed the manual git pull that took place before and updated copying files correctly to the scratch directory based on the new symbolic links
In [cc91146](https://bitbucket.org/fukaws/kadaththorn/commits/cc9114684da656587… I removed the submodule since this is no longer needed.
I have since tested the build procedure and everything worked on my end. Let me know if there are any further issues.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2711/attempting-to-bui…
#2721: Cactus does not detect `gettimeofday` timer
Reporter: Erik Schnetter
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by Roland Haas):
The global variable declaration I don’t buy. Since those look like:
```c
extern int errno
```
whether they are in the function or not does not matter \(and the `extern` is required for the declaration otherwise it would be a repeated definition each time the header file is included\). Same with function prototypes:
```c
int printf(fmt, ...);
```
is valid inside of main. Inline function _definitions_ being forbidden seems correct, yes, those cannot be nested in `main`.
It is, in any case, bad practise to have the header includes in main, even if it may have been allowable at one point in C’s history.
Would it be ok to apply this after the release unless there is urgent need to have this fixed right now?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…
#2721: Cactus does not detect `gettimeofday` timer
Reporter: Erik Schnetter
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by Erik Schnetter):
Yes, this is forbidden. Consider e.g. a global variable declaration, or the definition of an inline function. These have very different meaning when inside a function, or are not allowed.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2721/cactus-does-not-d…