Trac April 2023

trac@lists.einsteintoolkit.org

1 participants
128 discussions

#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver?
by Roland Haas 05 Apr '23

05 Apr '23

#2300: Update: Add Piecewise Polytrope EoS Support to IllinoisGRMHD, Improved TOV Solver? Reporter: Zach Etienne Status: open Milestone: Version: Type: enhancement Priority: major Component: Comment (by Roland Haas): Is this being superseded by #2690 ? If so it should be closed as a duplicate. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2300/update-add-piecew…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): @{557058:088051f9-5b94-4b5e-bfbe-71137030b9c1} @{5bae587b96242d2e2b6110a4} ? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by tootle 05 Apr '23

05 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by tootle): I’ve resolved \(1\) and \(2\). For \(3\), thanks for the information related to using submodules in git. Regarding the actions just prior to the release, I have no issue adding someone to the thorn repos to make their \(our\) lives easier if it allows for a level of automation. They can reach out to me and let me know \(here or e-mail\) Re: what they prefer and I’ll make it happen. Thanks a lot Roland! -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#1775: Add Boost to ET
by tootle 05 Apr '23

05 Apr '23

#1775: Add Boost to ET Reporter: Erik Schnetter Status: new Milestone: Version: development version Type: enhancement Priority: minor Component: EinsteinToolkit thorn Comment (by tootle): For my 2cents, I think it is an excellent idea to add a thorn that can detect boost libraries, but I think having to include the ability to build the whole library is too much bloat not to mention compile time. The number of dependencies that boost has in order to build the full suite is incredibly large - run spack concretize for a full boost spec and you’ll see what I mean. Even on our cluster, boost alone can take 30\+ minutes to compile the full suite including dependencies. I understand this goes against the ETK paradigm of everything that is needed is included, which should definitely be the case for fundamental components such as Carpet \(glad to hear CarpetX will remove the boost dependency\), but I think it would be more useful to fail gracefully and list the Thorns that depend on boost rather than defaulting to building the entire suite. Also, for modern clusters boost is usually available by default, but the environments may not be updated correctly making automated searches like those in Radice’s boost not robust. Cmake has incredibly good features for finding boost as well as individual components, but this still depends on the environment correctly setting \`BOOST\_ROOT\`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/1775/add-boost-to-et

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 04 Apr '23

04 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): 1. yes, please 2. only the `[submodule "fuka"]` block \(which is non-functional anyway\) 3. you won’t need a `ET_YYYY_MM` etc. branch in `fuka` as long as the submodule import in `KadathThorn` is a “regular” one that specifies a specific commit \(that one then needs to manually update when one wants to use a newer `fuka` version\) and is not auto-set to track a \(changing\) branch \(your’s does currently have a fixed commit\). If things are changed at `KadathThorn` is set to track a specific branch of `fuka` \(via the `git submodule set-branch` and `git update --remote` commands\) then a `ET_YYYY_MM` branch and tags of type `ET_YYYY_MM_vN` \(where N starts from 0 and increases by 1 for each point \[bugfix\] release\) are needed. These are created shortly before the release when all code is frozen \(I think about 1 week before the release\). See [https://docs.einsteintoolkit.org/et-docs/Release\_Process#Timeline\_for\_a\… and the “Release preparation II” item. ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2692: Inclusion of FUKA importer thorns
by tootle 04 Apr '23

04 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by tootle): Hi @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Thanks for the feedback. Since I haven’t been told directly, what was the results of the meeting? Will the FUKA thorns be included as DISABLED? If so, is the following summary accurate for the required changes for inclusion: 1\. Set the `Kadaththorn` to require BOOST 2\. Remove submodule block 3\. Generate ET release branches/tags \(ET\_2023\_05\) for fuka, kadaththorn, and kadathimporter repos \* For tags, what is used for vN? Is this comprehensive? Thanks ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

#2706: increase TwoPunctures resolution in BBH gallery example
by Roland Haas 03 Apr '23

03 Apr '23

#2706: increase TwoPunctures resolution in BBH gallery example Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit website @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} reports that increasing TP resolution in the galley example helps reducing initial data noise in the simulations \(in a forthcoming paper\). Thus is might be good to increase the resolution and regenerate all data for the gallery page and Zenodo \(and ask Barry and Ian to update it with a new version\). Most likely this is too late for ET\_2023\_05 but could be done for ET\_2023\_11. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2706/increase-twopunct…

1 0

#2692: Inclusion of FUKA importer thorns
by Roland Haas 01 Apr '23

01 Apr '23

#2692: Inclusion of FUKA importer thorns Reporter: tootle Status: new Milestone: ET_2023_05 Version: ET_2023_05 Type: proposal Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): In the current KadathThorn, there is a `.gitmodules` file: ``` [submodule "src/fuka"] path = src/fuka url = https://bitbucket.org/fukaws/fuka/ [submodule "fuka"] branch = fuka ``` for the fuka library checked out into `src/fuka` as a git submodule. This all works and is fine. However I notice that you are also including a section: ``` [submodule "fuka"] branch = fuka ``` which will be ignored since there is no `fuka` submodule \(the submodule is `src/fuka`\). Moreover, if it was _not_ ignored, it would actually be an issue for the ET unless it is removed or fixed to a `ET_YYYY_MM` branch for each release branch and fixed to a specific git hash for each `ET_YYYY_MM_vN` release tag. Otherwise it points to the _current_ head of that branch which is not what one would want for an ET release branch or tag \(which should point to the specific, tested version that was released\). Since it is ignored anyway, it may be best to remove this section altogether to not give any false impression on what commit of `fuka` is actually checked out. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac April 2023