#2705: error: more than one instance of overloaded function "isnan" matches the argument list
Reporter: Miguel Zilhão
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component:
Comment (by Roland Haas):
I am proposing an automated test \(and thus better error message\) for this in [#2663](https://bitbucket.org/einsteintoolkit/tickets/issues/2663/add-an-notice-about-minimum-intel-gcc). Feel free to review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2705/error-more-than-o…
#2663: add an notice about minimum Intel / GCC version required to configure output
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
Please review.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2663/add-an-notice-abo…
#2707: tests for lean_public are very slow
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Right now, out of the 10 [slowest tests](https://einsteintoolkit.github.io/tests/), 5 are lean\_public and 1 is `twopunctures_kerrproca_c11` . With 339 tests in the ET one tries to encourage each test to run as quickly as possible \([https://docs.einsteintoolkit.org/et-docs/Adding\_a\_test\_case](https://docs.einsteintoolkit.org/et-docs/Adding_a_test_case)\).
With about 6 minutes runtime and about 25minutes total test runtime \([https://einsteintoolkit.github.io/tests/plot.html](https://einsteintoolkit.github.io/tests/plot.html) in the time taken tab\) this accounts for almost 1/4 of the test runtime \(not including build time\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2707/tests-for-lean_pu…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
Looking at thornlist fragment included in in manifest:
```
# Elliptic ID reader
!TARGET = $ARR
!TYPE = git
!URL = https://github.com/aup1075/EllipticaID.git
!REPO_BRANCH = BHNS_reader
!REPO_PATH = $2
!CHECKOUT =
EllipticaID/Elliptica_BHNS
# required lib for Elliptica BHNS ID reader
!TARGET = $ARR
!TYPE = git
!URL = https://github.com/rashti-alireza/Elliptica_ID_Reader.git
!REPO_BRANCH = Cactus
!REPO_PATH = ../$2
!CHECKOUT =
ExternalLibraries/Elliptica_ID_Reader
```
then both use a non-default branch \(not just not named “master” but actually not the default branch\). This is ok as long as those branches are \(in the “master” branch manifest\) are the ones that will continue to be the ones that releases will be spun off from and are the ones that are actually used by the authors. That is they should not be branches created _solely_ for this ticket.
`https://github.com/rashti-alireza/Elliptica_ID_Reader.git` seems to be ok in that respect since it is the branch containing the Cactus ExternalLibrary like thorn and includes a tar file of the source \(though it could have also been included in a subdirectory of the main branch \[and include its own tar-file there\] in the way RePrimAnd does\).
However [https://github.com/aup1075/EllipticaID/tree/BHNS\_reader](https://github.co… has what looks like the same `Elliptica_BHNS` thorn also available in `main`. If the copy of the thorn is `BHNS_reader` is just a copy of the one in `main` then it would be preferable to track `main` where presumably the actual updates will happen. In particular in anticipation of a future inclusion of other types of readers. There is no harm in having extra thorns \(or other code\) in the repo and branch that is used with Cactus. The extra ones are just ignored as long as they are not actually listed in the thornlist \(and are not subject to review\).
The added simplicity of not having to maintain multiple branches that need to be kept up to date with bugfixes and \(possibly\) improvements may well be worth the larger size on disk when checking out the repo.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…
#2619: include Ellipitca (reader) in Einstein Toolkit
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Roland Haas):
When this was discussed in the ET calls then the argument for inclusion was that there would be a library of initial data files available. Right now I cannot find those anywhere. Are they available?
An alternative would be to have the elliptica initial data solver \(not just the reader\) available, though right now it is unclear where it is located or if it is available.
Having either one available was a condition for inclusion in the ET \(open source astro code\): [http://lists.einsteintoolkit.org/pipermail/users/2022-July/008615.html](htt…
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2619/include-ellipitca…