#2690: Include new IllinoisGRMHD with tabulated and hybrid EOS support
Reporter: Leonardo Werneck
Status: resolved
Milestone: ET_2023_05
Version:
Type: enhancement
Priority: major
Component:
Changes (by Leonardo Werneck):
status: resolved (was new)
Comment (by Leonardo Werneck):
Marking issue as resolved as we are favoring the inclusion of the GRHayL library instead.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2690/include-new-illin…
#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Samuel Cupp):
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} Do you mind if I also move the canuda-lean down with the other canuda repos? Its a bit weird that there are several repos between them despite the header
```
# Canuda thorns
#===============
```
since the intervening repos are clearly not canuda.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Samuel Cupp):
I can change the manifest to point to master.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#2697: Include BBH+scalar field initial data code from Canuda in ET
Reporter: Cheng-Hsin Cheng
Status: new
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Comment (by Cheng-Hsin Cheng):
Hi all, after discussing with the other authors and maintainers of Canuda/Scalar, we decided to merge TwoPunctures\_BBHSF from the branch `proposal_ET_2023_05` into `master`. So any updates or bug fixes for the new thorn will happen on `master`, and `proposal_ET_2023_05` would not be maintained.
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} could we update the manifest thornlist to use the master branch for Scalar? Should we make another pull request for the change, or can the release team just make the changes?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2697/include-bbh-scala…
#2692: Inclusion of FUKA importer thorns
Reporter: tootle
Status: new
Milestone: ET_2023_05
Version: ET_2023_05
Type: proposal
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
The only docs that exist are: [https://docs.einsteintoolkit.org/et-docs/Release\_Process#create\_branches]…
The script shown there should work for the Kadath codes in this ticket due to \(3\). They are basically the same as Kranc and its Examples repo \(also a submodule with fixed git hash\).
You _will_ have to \(at this point\) manually handle `proposal_ET_2023_05` in canuda/scalar since that is not the “default” branch and script fragment on the wiki assumes that one branches of release branches from the current head of the default branch. This most likely can \(and should\) be changed so that one can run the script fragment in the repository structure created by GetComponents on the master thornlist from the `manifest` repo and make it assume that the branching happens off the currently checked out branch \(which for canuda/scalar is currently `proposal_ET_2023_05`\). This \(probably\) just means removing the:
```
default_branch=$(git symbolic-ref refs/remotes/origin/HEAD | sed 's@^refs/remotes/origin/@@')
```
and
```
git checkout $default_branch
```
lines. It will also affect how one learns which changes to announce \(which also looks at the default branch\), but that process requires some human interaction anyway.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…
#2692: Inclusion of FUKA importer thorns
Reporter: tootle
Status: new
Milestone: ET_2023_05
Version: ET_2023_05
Type: proposal
Priority: major
Component: EinsteinToolkit thorn
Comment (by Samuel Cupp):
Sorry, but I didn’t really follow the specifics of point 3, as I haven’t dealt with anything that doesn’t just have a branch called “ET\_release\_date”. I am fine with having commit access so I can make the branches. If there’s something special that needs to be done for some repos, is there a guide or something on the wiki about these cases?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2692/inclusion-of-fuka…