July 2024 - Trac - lists.einsteintoolkit.org

#2813: Allow CarpetX to implement Driver.
by Steven R. Brandt 30 Jul '24

30 Jul '24

#2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Steven R. Brandt): OK, I’ve moved regrid\_error to a new thorn “Regrid” in CarpetX. With this change, no modifications to the flesh or wvuthorns\_diagnostics are needed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-…

1 0

#2719: GetCompnents does not handle symbolic links correctly when checking repository inter-dependencies
by Roland Haas 30 Jul '24

30 Jul '24

#2719: GetCompnents does not handle symbolic links correctly when checking repository inter-dependencies Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: GetComponents Comment (by Roland Haas): Further complicated by `cd` not just splitting the given path at `/` and then walking that list. Instead, unless a `-P` is given, it removes \`./\` and \`../\` bits from the string first: [https://pubs.opengroup.org/onlinepubs/9699919799/utilities/cd.html](https:/… though this behaviour can be changed via use options in `.bashrc` . -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2719/getcompnents-does…

1 0

#2176: Test "Binary neutron star" example
by Roland Haas 30 Jul '24

30 Jul '24

#2176: Test "Binary neutron star" example Reporter: Roland Haas Status: resolved Milestone: ET_2024_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutr…

1 0

#2813: Allow CarpetX to implement Driver.
by Steven R. Brandt 29 Jul '24

29 Jul '24

#2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Steven R. Brandt): Pull request for the flesh: [https://bitbucket.org/cactuscode/cactus/pull-requests/163](https://bitbucke… for PUGH: [https://bitbucket.org/cactuscode/cactuspugh/pull-requests/4](https://bitbuc… for Carpet: [https://bitbucket.org/eschnett/carpet/pull-requests/61](https://bitbucket.o… for CarpetX: [https://github.com/EinsteinToolkit/CarpetX/pull/299](https://github.com/Ein… for Cactus Examples: [https://bitbucket.org/cactuscode/cactusexamples/pull-requests/4](https://bi… for wvuthorns\_diagnostics: [https://bitbucket.org/zach\_etienne/wvuthorns\_diagnostics/pull-requests/15… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-…

1 0

#2813: Allow CarpetX to implement Driver.
by Steven R. Brandt 29 Jul '24

29 Jul '24

#2813: Allow CarpetX to implement Driver. Reporter: Steven R. Brandt Status: new Milestone: Version: Type: bug Priority: major Component: Several problems exist with respect to making CarpetX implement Driver. $1$ It has a grid function named regrid\_error that PUGH and Carpet do not. $2$ Carpet and PUGH have periodic\_x…z defaulting to true instead of false. $3$ CarpetX does not have a parameter named periodic. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2813/allow-carpetx-to-…

1 0

#2812: make Extract work with Carpet
by Roland Haas 29 Jul '24

29 Jul '24

#2812: make Extract work with Carpet Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): responsible: [] (was ) assignee: David Radice (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2812/make-extract-work…

1 0

#2812: make Extract work with Carpet
by Roland Haas 29 Jul '24

29 Jul '24

#2812: make Extract work with Carpet Reporter: Roland Haas Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2812/make-extract-work…

1 0

#2812: make Extract work with Carpet
by Roland Haas 29 Jul '24

29 Jul '24

#2812: make Extract work with Carpet Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn This pull request contains three patches needed for Extract to be usable with Carpet in AMR simulations. Admittedly, these are workarounds and Exact would probably need to be redesigned to more transparently work with AMR grids. I have tested these changes and I can now use Extract to Extract gravitational wave and.the results are consistent with those of Multipole \+ integration of Psi4. ‌ * Extract: do not check grid extension Extract is not producing any output, because it incorrectly assumes that the detectors are outside of the grid. This patch is a workaround which removes this check. * Extract: set variables prolongation to None * Extract: only extract waves in one refinement level Extract was previously attempting to extract waves on all refinement levels, producing incorrect output for those levels that do not include the extraction surfaces. This patch adds a parameter to Extract to specify which refinement level to analyize. In the long term, it would be cleaner to redesign Extract to work in GLOBAL mode, rather than in LOCAL mode. ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2812/make-extract-work…

1 0

#2172: Test "Binary black hole GW150914" example
by Deborah Ferguson 24 Jul '24

24 Jul '24

#2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: open Milestone: ET_2024_05 Version: development version Type: task Priority: major Component: EinsteinToolkit website Comment (by Deborah Ferguson): I have run GW150914.par and confirmed that the output looks right. I’ve uploaded the tar.gz and updated the website with the date last tested. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black…

1 0

#2811: Formaline Optionally use non-system Perl
by Yosef Zlochower 22 Jul '24

22 Jul '24

#2811: Formaline Optionally use non-system Perl Reporter: Yosef Zlochower Status: open Milestone: Version: Type: proposal Priority: minor Component: Cactus Comment (by Yosef Zlochower): The code will compile with the following patch where I replace “PATH/makeblob.pl … ” with “$$PERL$ PATH/makeblob.pl …” ```diff diff --git a/Formaline/src/make.configuration.deps b/Formaline/src/make.configuration.deps index 18fbae4..6be8b86 100644 --- a/Formaline/src/make.configuration.deps +++ b/Formaline/src/make.configuration.deps @@ -132,7 +132,7 @@ $(TARBALL_DIR)/config-Cactus.c: $(TARBALL_DIR)/config-Cactus.files $(CCTK_HOME)/ # 3.81 to hang due to a make bug if ( cd $(CONFIGS_DIR) && ( $(TAR) czf $(TARBALL_DIR)/config-Cactus.tar.gz -T $< || [ $$? -lt $(TAR_ERROR_THRESHOLD) ] ) ) ; then \ $(RM) -f $(@:%.c=%-????.c) && \ - $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) '' CactusConfig < $(TARBALL_DIR)/config-Cactus.tar.gz && \ + $(PERL) $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) '' CactusConfig < $(TARBALL_DIR)/config-Cactus.tar.gz && \ rm $(TARBALL_DIR)/config-Cactus.tar.gz ; \ else \ exit $$? ; \ @@ -203,7 +203,7 @@ $(TARBALL_DIR)/flesh-Cactus.c: $(TARBALL_DIR)/flesh-Cactus.files $(CCTK_HOME)/ar # 3.81 to hang due to a make bug if ( cd $(CCTK_HOME) && ( $(TAR) czf $(TARBALL_DIR)/flesh-Cactus.tar.gz -T $< || [ $$? -lt $(TAR_ERROR_THRESHOLD) ] ) ) ; then \ $(RM) -f $(@:%.c=%-????.c) && \ - $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) '' Cactus < $(TARBALL_DIR)/flesh-Cactus.tar.gz && \ + $(PERL) $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) '' Cactus < $(TARBALL_DIR)/flesh-Cactus.tar.gz && \ $(RM) $(TARBALL_DIR)/flesh-Cactus.tar.gz ; \ else \ exit $$? ; \ @@ -269,7 +269,7 @@ $(TARBALL_DIR)/thorn-%.c: $(TARBALL_DIR)/thorn-%.files $(CCTK_HOME)/arrangements # 3.81 to hang due to a make bug if ( cd $(CCTK_HOME) && ( $(TAR) czf $(@:%.c=%.tar.gz) -T $< || [ $$? -lt $(TAR_ERROR_THRESHOLD) ] ) ) ; then \ cd $(TARBALL_DIR) && $(RM) -f $(@:$(TARBALL_DIR)/%.c=%-????.c) && \ - $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) $(patsubst %/,%,$(dir $(filter %/$(@:$(TARBALL_DIR)/thorn-%.c=%),$(THORNS)))) $(@:$(TARBALL_DIR)/thorn-%.c=%) < $(@:%.c=%.tar.gz) && \ + $(PERL) $(FORMALINE_BIN_DIR)/makeblob.pl $(@:%.c=%) $(patsubst %/,%,$(dir $(filter %/$(@:$(TARBALL_DIR)/thorn-%.c=%),$(THORNS)))) $(@:$(TARBALL_DIR)/thorn-%.c=%) < $(@:%.c=%.tar.gz) && \ rm $(@:%.c=%.tar.gz) ; \ else \ exit $$? ; \ ``` ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2811/formaline-optiona…

1 0

#2811: Formaline Optionally use non-system Perl
by Roland Haas 22 Jul '24

22 Jul '24

#2811: Formaline Optionally use non-system Perl Reporter: Yosef Zlochower Status: open Milestone: Version: Type: proposal Priority: minor Component: Cactus Comment (by Roland Haas): Cactus' build system uses the `make` $and thus shell$ variable `$PERL` for the location of the configured Perl interpreter. This cannot quite be used in the `#!` line since that line does not do variable expansion. We also cannot use any options of `env` other than the ones in POSIX: [https://pubs.opengroup.org/onlinepubs/9699919799/utilities/env.html](https:… so `-S` is not possible $though it does seems to be supported on Linux and macOS$. Otherwise using something like `env -S ${PERL} -w` would be great. Instead the Cactus make files run perl scripts as `$PERL foo.pl` and the scripts should use `use warnings;` instead of the `-w` switch. Is that something that you could give a try? I am not sure what other scripts in Formaline exist that are directly called and not already via `$PERL`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2811/formaline-optiona…

1 0

#2811: Formaline Optionally use non-system Perl
by Roland Haas 22 Jul '24

22 Jul '24

#2811: Formaline Optionally use non-system Perl Reporter: Yosef Zlochower Status: open Milestone: Version: Type: proposal Priority: minor Component: Cactus Changes (by Roland Haas): responsible: [] (was ) assignee: Yosef Zlochower (was ) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2811/formaline-optiona…

1 0

#2811: Formaline Optionally use non-system Perl
by Roland Haas 22 Jul '24

22 Jul '24

#2811: Formaline Optionally use non-system Perl Reporter: Yosef Zlochower Status: open Milestone: Version: Type: proposal Priority: minor Component: Cactus Changes (by Roland Haas): status: open (was new) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2811/formaline-optiona…

1 0

#2811: Formaline Optionally use non-system Perl
by Yosef Zlochower 22 Jul '24

22 Jul '24

#2811: Formaline Optionally use non-system Perl Reporter: Yosef Zlochower Status: new Milestone: Version: Type: proposal Priority: minor Component: Cactus During the last stage of the build process, makeblob.pl, under Formaline/src/utils/ is run. The build fails if /usr/bin/perl is missing or doesn’t have the necessary modules included. I got around this issue by compiling my own version of perl and replacing “#! /usr/bin/perl -w” with “#! /usr/bin/env -S perl -w” ‌ ```diff diff --git a/Formaline/src/util/makeblob.pl b/Formaline/src/util/makeblob.pl index e5bcafd..bcc2084 100755 --- a/Formaline/src/util/makeblob.pl +++ b/Formaline/src/util/makeblob.pl @@ -1,4 +1,4 @@ -#! /usr/bin/perl -w +#! /usr/bin/env -S perl -w use diagnostics; use warnings; ``` ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2811/formaline-optiona…

1 0

#2810: download tar files for Multipatch gallery example misnamed
by Roland Haas 19 Jul '24

19 Jul '24

#2810: download tar files for Multipatch gallery example misnamed Reporter: Roland Haas Status: wontfix Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit website Changes (by Roland Haas): status: wontfix (was new) Comment (by Roland Haas): Nope, turns out "Multipole" was intentional. The parfile is named the same and the commit message introducing it [e6ea25d](https://bitbucket.org/llamacode/llama/commits/e6ea25df2d09a8226673… "LlamaWaveToy: Add examples with multipolar initial data" of [llama](https://bitbucket.org/llamacode/llama) shows that the naming was intentional. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2810/download-tar-file…

1 0

#2810: download tar files for Multipatch gallery example misnamed
by Roland Haas 19 Jul '24

19 Jul '24

#2810: download tar files for Multipatch gallery example misnamed Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit website Most of the Kerr-Schild multi\*patch\* gallery example tar files are named incorrectly $with the correctly named one being @{557058:a2800088-fc6e-4fbe-9a1e-663271f736bd} 's from 2019$. Namely they are named Kerr-Schild\_\*Multipole\*. Not sure if there is anything that can be done about the past files, but future files should be named correctly unless we want to maintain bug-for-bug backwards compatibility in naming schemes of those files. Files are at: [https://bitbucket.org/einsteintoolkit/www/downloads/](https://bitbucket.org… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2810/download-tar-file…

1 0

#2809: version numbers in Cactus Makefile out of date
by Steven R. Brandt 18 Jul '24

18 Jul '24

#2809: version numbers in Cactus Makefile out of date Reporter: Roland Haas Status: resolved Milestone: Version: ET_2024_05 Type: bug Priority: major Component: Changes (by Steven R. Brandt): status: resolved (was new) Comment (by Steven R. Brandt): Done -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2809/version-numbers-i…

1 0

#2786: support CarpetX in Multipole
by Roland Haas 18 Jul '24

18 Jul '24

#2786: support CarpetX in Multipole Reporter: Roland Haas Status: open Milestone: Version: Type: enhancement Priority: minor Component: EinsteinToolkit thorn Changes (by Roland Haas): status: open (was on hold) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2786/support-carpetx-i…

1 0

#2179: NaNChecker: fix output of NaNMask
by Roland Haas 18 Jul '24

18 Jul '24

#2179: NaNChecker: fix output of NaNMask Reporter: Roland Haas Status: open Milestone: Version: development version Type: bug Priority: minor Component: EinsteinToolkit thorn Changes (by Roland Haas): In af45e31 - NaNChecker: reduce nan mask in level mode a bug was introduced that caused the NaNMask to be cleared in level mode where the NaNMask pointer is not valid. This fixes this and also restructures the functions so that all levels of the NaNMask starting with the one containing NaNs are output. Pull request is here: [https://bitbucket.org/cactuscode/cactusutils/pull-requests/42](https://bitb… **Keyword:** NaNChecker -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2179/nanchecker-fix-ou…

1 0

#2520: update gauge settings in TOV example to be more typical
by David Boyer 17 Jul '24

17 Jul '24

#2520: update gauge settings in TOV example to be more typical Reporter: Roland Haas Status: new Milestone: ET_2023_11 Version: development version Type: enhancement Priority: major Component: Comment (by David Boyer): @{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} I attempted the changes of the parfile as mentioned in the ticket. I’m posting what I changed in the parfiles and the plots I got. I would like to hear your opinion on if it is okay, or if there is another fix you suggest. _**Original parfiles**_: ``` ML_BSSN::harmonicN = 1 # these set: ML_BSSN::harmonicF = 1.0 # dot[alpha] = - alpha A ML_BSSN::evolveA = 1 # dot[A] = dot[trK] ML_BSSN::evolveB = 1 # these set: dot[beta] = dot[dot[beta]] = 0 ML_BSSN::ShiftGammaCoeff = 0.0 # by choosing coeffs to zero the RHS ML_BSSN::AlphaDriver = 0.0 ML_BSSN::BetaDriver = 0.0 ML_BSSN::advectLapse = 0 ML_BSSN::advectShift = 0 ``` _**I Replaced with**_: ``` ML_BSSN::harmonicN = 1 # 1+log ML_BSSN::harmonicF = 2.0 # 1+log ML_BSSN::ShiftGammaCoeff = 0.75 ML_BSSN::AlphaDriver = 0.0 ML_BSSN::BetaDriver = 0.0 ML_BSSN::advectLapse = 1.0 ML_BSSN::advectShift = 1.0 ``` _**Summary of differences**_: I mainly had an issue with the given BetaDriver. **I did first attempt this by using what was directly stated in the latter half of the ticket $no changes$, but whenever BetaDriver was turned on $set to 1$, densities would begin to runaway with nans at around t=60M. Turning BetaDriver off seemed to fix this issue, but I’m not sure if it was okay to do.** On a smaller note, I also changed Lapse/ShiftAdvectionCoeff to advectLapse/Shift, as it was stated in the ML\_BSSN thorn that the former was the outdated name and was renamed to advectLapse/Shift. Same variable, just a new name. I don’t think this point really changes anything, just using the up-to-date variable names. _**Plots**_: I have included my plots here. They are VERY NEARLY the same plots as the current gallery example, but there seems to be slight differences, the most noticeable being slightly more runoff at the end of the low res run for density. Are these plots okay, or were they meant to be point-per-point exactly the same? And if BetaDriver needs to be set to 1, is there another variable that needs to be changed to avoid the runaway nans? ![](https://bitbucket.org/repo/8zBLME5/images/160932728-convergence_p.png) ![](https://bitbucket.org/repo/8zBLME5/images/3330105359-density_p.png) ‌ -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2520/update-gauge-sett…

1 0

#2179: NaNChecker: fix output of NaNMask
by Roland Haas 12 Jul '24

12 Jul '24

#2179: NaNChecker: fix output of NaNMask Reporter: Roland Haas Status: open Milestone: Version: development version Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2179/nanchecker-fix-ou…

1 0

#2809: version numbers in Cactus Makefile out of date
by Roland Haas 12 Jul '24

12 Jul '24

#2809: version numbers in Cactus Makefile out of date Reporter: Roland Haas Status: new Milestone: Version: ET_2024_05 Type: bug Priority: major Component: The ET\_2024\_05 Cactus Makefile has ``` CCTK_VERSION_MAJOR = 4 CCTK_VERSION_MINOR = 15 CCTK_VERSION_OTHER = 0 ``` same as the ET\_2023\_11 release. Same in `doc/latex/cactus.sty`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2809/version-numbers-i…

1 0

#2808: prevent wvuthorns/IllinoisGRMHD from compiling in release past 2024_05
by Roland Haas 11 Jul '24

11 Jul '24

#2808: prevent wvuthorns/IllinoisGRMHD from compiling in release past 2024_05 Reporter: Roland Haas Status: new Milestone: Version: Type: enhancement Priority: minor Component: With `ET_2024_05` there are now 2 thorns called IllinoisGRMHD in the `repos` directory. Only one of them is in the ET $arrangements/GRHayLET/IllinoisGRMHD$. ‌ To avoid users accidentally using the old thorn in the $familiar$ wvuthorns repository it may be a good idea to: 1\. add warning to its README file that this thorn is outdated, no longer maintained and superseded by the one in GRHayLET 2\. add a “bomb” to the source code that shows that same information. Similar to eg [https://github.com/rhaas80/Outflow/commit/506c08d7139a5f4ed8aac4acf8658611f… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2808/prevent-wvuthorns…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Roland Haas 11 Jul '24

11 Jul '24

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no" Reporter: Gabriele Bozzola Status: resolved Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Changes (by Roland Haas): status: resolved (was open) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…

1 0

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no"
by Roland Haas 11 Jul '24

11 Jul '24

#2497: IllinoisGRMHD is incompatible with setting TmunuBase::stress_energy_at_RHS = "no" Reporter: Gabriele Bozzola Status: open Milestone: Version: development version Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): I see, thank you. My `ET_Next` checkout still had both present $`arrangements/WVUThorns/IllinoisGRMHD` and `arrangements/GRHayLET/IllinoisGRMHD`$ most likely b/c things were added to the thornlist after my initial checkout. Sorry for the confusion. Ok, so this can then be closed. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2497/illinoisgrmhd-is-…

1 0

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac July 2024