#2834: Baikal regeneration instruction in README fail
Reporter: Roland Haas
Status: new
Milestone: ET_2024_11
Version:
Type: bug
Priority: major
Component:
Comment (by Zach Etienne):
Largely this is a README issue:
Only codes requiring NRPy generation will populate the thorns, so test/ doc/ and par/ will not be populated just by running NRPy. Instead, src/ and \*.ccl files should be deleted in the thorns and replaced with generated codes. The README should be updated to reflect this.
In addition, there have been some minor reshufflings to improve maintainability, diagnostics, and performance, including
1. computing the squared momentum constraint \(MSQUAREDGF\).
2. sorting the parameters in param.ccl in a case-insensitive alphabetical way.
3. replacing pow\(x, -1/6\) with 1 / sqrt\(cbrt\(x\)\) \(it is faster!\)
4. Starting all function-level comment blocks with /\*\* instead of /\* . This enables syntax highlighting of @param \[parameter name\] in all IDEs I tried \(emacs & vscode\).
5. simd/simd\_intrinsics.h has been tidied up a bit, and a few new intrinsics \(currently unused by Baikal\*, but used by other \[future ET\] NRPy projects\) were added.
The above changes reflect the Baikal\* thorns in the latest `NRPy-main`. Should I proceed in updating the README to use this? There is no functional change.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2834/baikal-regenerati…
#2818: failing tests with gcc-14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
The negative array index warning is actually from within AMReX:
```text
COMPILING CarpetX/CarpetX/src/reduction.cxx
In file included from /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_Box.H:9,
from /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_BaseFab.H:9,
from /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_FArrayBox.H:6,
from /data/rhaas/postdoc/gr/cactus/ET_Next/arrangements/CarpetX/Loop/src/loop.hxx:4,
from /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/bindings/include/loop.hxx:4,
from /data/rhaas/postdoc/gr/cactus/ET_Next/arrangements/CarpetX/CarpetX/src/driver.hxx:4,
from /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/build/CarpetX/reduction.cxx:1:
In member function ?constexpr int& amrex::IntVectND<dim>::operator[](int) [with int dim = 3]?,
inlined from ?amrex::Box amrex::BATbndryReg::operator()(const amrex::Box&) const? at /data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_BoxArray.H:223:25:
/data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_IntVect.H:240:79: warning: array subscript -1 is below array bounds of ?int [3]? [-Warray-bounds=]
240 | int& operator[] (int i) noexcept { BL_ASSERT(i>=0 && i < dim); return vect[i]; }
| ~~~~^
/data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_IntVect.H: In member function ?amrex::Box amrex::BATbndryReg::operator()(const amrex::Box&) const?:
/data/rhaas/postdoc/gr/cactus/ET_Next/configs/sim/scratch/external/AMReX/include/AMReX_IntVect.H:788:9: note: while referencing ?amrex::IntVectND<3>::vect?
788 | int vect[dim] = {};
| ^~~~
```
and from the output I cannot see who may be calling `amrex::Box amrex::BATbndryReg::operator()(const amrex::Box&)` other than “somewhere in `reduction.cxx`".
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2818/failing-tests-wit…
#2175: Test "Single, stable neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Roland Haas):
uploading only the new one should be sufficient. Maybe add a comment to #2520 that before you updated the parfile everything looked the same as before to document that the change observed is only due to the changed gauge.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stabl…
#2175: Test "Single, stable neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by David Boyer):
@{557058:59e031ba-9bb5-4298-a472-7b99d0ae6f22} I have run the gallery example and everything looks good, same outcome as before. The new runs are tarred up and ready to go. However, I have also rerun the test with the new gauge settings from ticket #2520, and now since I know what I need to do, I could upload those instead if you like, taking out both tickets at the same time. Would this alternative be preferred?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2175/test-single-stabl…
#2173: Test "Poisson equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Changes (by Roland Haas):
responsible: [] (was [])
milestone: ET_2024_11 (was ET_2024_05)
assignee: Lucas Timotheo Sanches (was Steven R. Brandt)
Comment (by Roland Haas):
@{5f2f18c8e8c45600229698f5} will run this for 2024-11
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2173/test-poisson-equa…
#2173: Test "Poisson equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_05
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Changes (by Roland Haas):
status: open (was resolved)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2173/test-poisson-equa…
#2174: Test "Multi Patch Scalar Wave Equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Changes (by Roland Haas):
responsible: [] (was [])
assignee: William Gabella (was Lucas Timotheo Sanches)
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-…