#2174: Test "Multi Patch Scalar Wave Equation" example
Reporter: Roland Haas
Status: open
Milestone: ET_2024_05
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Lucas Timotheo Sanches):
# Instructions
I had a few minor issues getting the instructions to produce the expected output. Bellow are the corrections needed:
1. In step 3, instruction 1 where one reads
```
./utils/Scripts/MakeThornList --master thonrlists/einsteintoolkit.th --output thornlists/Kerr-Schild_Multipole.th
```
one should read
```
./utils/Scripts/MakeThornList --master thornlists/einsteintoolkit.th --output thornlists/Kerr-Schild_Multipole.th par/Kerr-Schild_Multipole.par
```
2. In step 4, where one reads
```
./simfactory/bin/sim create-submit --parfile par/Kerr-Schild_Multipole.par --cores 8 --num-threads 2 --walltime 0:30:00
```
one should read
```
./simfactory/bin/sim create-submit Kerr-Schild_Multipole --parfile par/Kerr-Schild_Multipole.par --cores 8 --num-threads 2 --walltime 0:30:00
```
# Visualization
I recommend removing the `wget http://einsteintoolkit.org/gallery/multipatch/Kerr-Schild_Multipole.session` file from the gallery for the following reasons:
1. In `visit` version `3.4.1`, where I produce the plots, several instructions on the session file are deprecated.
2. The session file is highly specific to the user that tested the visualization. Any changes in input, output and home folders cause the session to fail
I propose that instead of using the session file, we provide a python script to produce the output. The script increases reproducibility of the example and addresses both issues mentioned above and can be invoked via
```
visit -cli -nowin -s plot.py <Folder containing Carpet HDF5 files> <Output folder> <image name (without extension)>
```
How would I go about changing this @Roland Hass?
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2174/test-multi-patch-…
#2803: Add simfactory files for Frontier
Reporter: Liwei Ji
Status: resolved
Milestone:
Version:
Type: enhancement
Priority: major
Component:
Changes (by Samuel Cupp):
status: resolved (was new)
Comment (by Samuel Cupp):
This PR has been merged.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2803/add-simfactory-fi…
#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
GCC14 removed implicit pointer casts and requires explicit casts for C in the same manner that C\+\+ requires them.
[https://gcc.gnu.org/gcc-14/porting\_to.html](https://gcc.gnu.org/gcc-14/por…
This affects TwoPunctures and thus all thorns that are derived from TwoPunctures. Typical compile failures are error messages such as:
```
COMPILING Proca/TwoPunctures_KerrProca/src/Newton.c
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c: In function 'TPKP_TestRelax':
/Users/rhaas/Cactus/configs/sim/build/TwoPunctures_KerrProca/Newton.c:287:37: error: passing argument 6 of 'resid' from incompatible pointer type [-Wincompatible-pointer-types]
287 | resid (res, ntotal, dv, F, ncols, cols, JFD);
| ^~~~
| |
| int **
```
This is fixed for TwoPunctures in [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18]… but the patch used there does not cleanly apply to the derived codes \(possibly due to some extra lines of code being present\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…
#2802: compilation faiulres in TwoPunctures_BBHSF and TwoPunctures_KerrProca with gcc14
Reporter: Roland Haas
Status: open
Milestone:
Version:
Type: bug
Priority: major
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
README files list as maintainers:
* @{557058:a2800088-fc6e-4fbe-9a1e-663271f736bd}
* @{557058:65c5f18c-c3ad-4126-bb2b-be0e766b31ef}
* Giuseppe Ficarra \(who I cannot seem to @mention in bitbucket\)
* Cheng-Hsin Cheng \(who I cannot seem to @mention in bitbucket\)
If one of you could take a stab at adding the changes shown in [https://bitbucket.org/einsteintoolkit/einsteininitialdata/pull-requests/18]… to TwoPunctures\_KerrProca and TwoPunctures\_BBHSF that would be great.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2802/compilation-faiul…