#2798: VolumeIntegrals_GRMHD has a maximum value for out_every
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Zach Etienne):
Thanks for the report! This issue has been fixed in commit 8f9c036a05f98ff3b061ba6893e7673290c9fb4c .
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2798/volumeintegrals_g…
#2798: VolumeIntegrals_GRMHD has a maximum value for out_every
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
Changes (by Roland Haas):
responsible: [] (was )
assignee: Zach Etienne (was )
Comment (by Roland Haas):
Assigning to @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278}
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2798/volumeintegrals_g…
#2798: VolumeIntegrals_GRMHD has a maximum value for out_every
Reporter: Bruno Giacomazzo
Status: new
Milestone:
Version:
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
In WVUThorns\_Diagnostics/VolumeIntegrals\_GRMHD the parameter VolIntegral\_out\_every is defined in the following way:
```none
CCTK_INT VolIntegral_out_every "How often to compute volume integrals?" STEERABLE = ALWAYS
{
0:1000 :: "zero (disable integration) or some other number"
} 0
```
Is there a reason for not allowing the user to save every 1001 or larger number of iterations? I discovered it recently because I set it to 1024 and of course I got an error.
```none
WARNING[L1,P0] (Cactus): Major error in parameter file 'BH.par' line 684: Range error setting parameter 'VolumeIntegrals_GRMHD::VolIntegral_out_every' to '1024'
WARNING level 0 from host lrdn4615.leonardo.local process 0
in thorn Cactus, file /leonardo/home/userexternal/bgiacoma/ET_2023_11/Cactus/src/main/ProcessParameterDatabase.c:201:
-> CCTKi_SetParameterSetMask: 1 major error in parameter file
```
‌
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2798/volumeintegrals_g…
#2797: NRPyElliptic passes incompatible pointer types
Reporter: Roland Haas
Status: new
Milestone:
Version:
Type: bug
Priority: major
Component:
With gcc-14 NRPyElliptic fails with
```
Creating /Users/rhaas/Cactus/configs/sim/lib/libthorn_Meudon_Bin_BH.a
/Users/rhaas/Cactus/configs/sim/build/NRPyEllipticET/conformally_flat_BBH/NRPyEllipticET_conformally_flat_BBH_Initialize_ADMBase.c: In function 'NRPyEllipticET_conformally_flat_BBH_Initialize_ADMBase':
/Users/rhaas/Cactus/configs/sim/build/NRPyEllipticET/conformally_flat_BBH/NRPyEllipticET_conformally_flat_BBH_Initialize_ADMBase.c:147:71: error: passing argument 6 of 'NRPyEllipticET_conformally_flat_BBH_interpolate_solution_to_ADMBase' from incompatible pointer type [-Wincompatible-pointer-types]
147 | input_array,
| ^~~~~~~~~~~
| |
| CCTK_REAL8 (*)[Nxx_plus_2NGHOSTS1][Nxx_plus_2NGHOSTS0] {aka double (*)[Nxx_plus_2NGHOSTS1][Nxx_plus_2NGHOSTS0]}
In file included from /Users/rhaas/Cactus/configs/sim/build/NRPyEllipticET/conformally_flat_BBH/NRPyEllipticET_conformally_flat_BBH_Initialize_ADMBase.c:3:
/Users/rhaas/Cactus/arrangements/EinsteinInitialData/NRPyEllipticET/src/conformally_flat_BBH/./conformally_flat_BBH_NRPy_function_prototypes.h:74:92: note: expected 'const CCTK_REAL8 *' {aka 'const double *'} but argument is of type 'CCTK_REAL8 (*)[Nxx_plus_2NGHOSTS1][Nxx_plus_2NGHOSTS0]' {aka 'double (*)[Nxx_plus_2NGHOSTS1][Nxx_plus_2NGHOSTS0]'}
74 | const CCTK_REAL *input_gf,
| ~~~~~~~~~~~~~~~~~^~~~~~~~
```
Basically a `CCTK_REAL*` is not the same as a `CCTK_REAL[][]`.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2797/nrpyelliptic-pass…