#2777: Upgrade IllinoisGRMHD to use GRHayL
Reporter: Samuel Cupp
Status: new
Milestone: ET_2024_05
Version:
Type: enhancement
Priority: major
Component:
Comment (by Lorenzo Ennoggi):
I reviewed the changes to IllinoisGRMHD for the upcoming ET release and everything looks good to me.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2777/upgrade-illinoisg…
#2176: Test "Binary neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2023_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Roland Haas):
I think some differences were post-merger only \(so expected\) and some were missing data in the re-run.
The current setup uses higher resolution than the very old ones, so will look a bit different than say a 2019 run.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutr…
#2176: Test "Binary neutron star" example
Reporter: Roland Haas
Status: open
Milestone: ET_2023_11
Version: development version
Type: task
Priority: major
Component: EinsteinToolkit website
Comment (by Samuel Cupp):
@{557058:1671c5c3-29cc-4e83-9850-a152d33a6235} @{557058:a1365549-c6b3-47a0-a4ba-7749d6439c60} was this ever resolved in the previous release? I recall you saying the results differed, but never received any updates.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2176/test-binary-neutr…
#2794: TACC Stampede3-skx Compilation Failing [-Wincompatible-function-pointer-type]
Reporter: vik(a)arizona.edu
Status: new
Milestone: ET_2023_05
Version: ET_2023_05
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
Comment (by vik(a)arizona.edu):
Thank you for the suggestions. The compiler flag suggestion bypassed the error that was killing the compilation.
```
-Wno-incompatible-function-pointer-types
```
‌
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2794/tacc-stampede3-sk…
#2794: TACC Stampede3-skx Compilation Failing [-Wincompatible-function-pointer-type]
Reporter: vik(a)arizona.edu
Status: new
Milestone: ET_2023_05
Version: ET_2023_05
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
This was discussed in today’s Einstein Toolkit call. Steve also encountered this issue with g\+\+-14 which also flags this as an error.
The solution agree on in the phone call is to remove the restrict keyword from ReflectionSymmetry, at least for this release.
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2794/tacc-stampede3-sk…
#2794: TACC Stampede3-skx Compilation Failing [-Wincompatible-function-pointer-type]
Reporter: vik(a)arizona.edu
Status: new
Milestone: ET_2023_05
Version: ET_2023_05
Type: bug
Priority: minor
Component: EinsteinToolkit thorn
Comment (by Roland Haas):
these seem to differ only in the `restrict` keyword used by \`ReflectionSymmetry\`. The interface specification of the aliased function
```
CCTK_INT FUNCTION \
SymmetryRegisterGridInterpolator \
(CCTK_POINTER IN cctkGH, \
CCTK_INT IN sym_handle, \
CCTK_INT CCTK_FPOINTER IN symmetry_interpolate \
(CCTK_POINTER_TO_CONST IN cctkGH, \
CCTK_INT IN N_dims, \
CCTK_INT IN local_interp_handle, \
CCTK_INT IN param_table_handle, \
CCTK_INT IN coord_system_handle, \
CCTK_INT IN N_interp_points, \
CCTK_INT IN interp_coords_type, \
CCTK_POINTER_TO_CONST ARRAY IN interp_coords, \
CCTK_INT IN N_input_arrays, \
CCTK_INT ARRAY IN input_array_indices, \
CCTK_INT IN N_output_arrays, \
CCTK_INT ARRAY IN output_array_types, \
CCTK_POINTER ARRAY IN output_arrays, \
CCTK_INT IN faces))
```
has no `restrict` in it \(not sure if this can even be expressed in the CCL file\).
So the function prototypes differ, though if that difference is something that the compiler may care about \(since restrict is just a property of the function and does not affect externally visible behaviour\) may be a different question.
Since this is just a warning, it should not actually stop the compilation though.
It maybe good to include the full compilation output as described on [http://einsteintoolkit.org/support.html#general-guidelines-for-questions](h…
If this warning is indeed what makes the compilation abort I’d add
```
-Wno-incompatible-function-pointer-types
```
to `CFLAGS` and `CXXFLAGS` of the option list \(cfg file\).
--
Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2794/tacc-stampede3-sk…