Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Roland Haas 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): I’d remove the output file and thorn SystemStatistics from the ActiveThorns line \(to run with as few thorns as possible\). -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Thanks! The only other changes I would like to suggest are 1\. there are several variables that are outputted but don’t have files in the test dir \(`HydroBase::w_lorentz`, `SphericalSurface::sf_radius`, and `ML_ADMConstraints::ML_Ham`\); I’d just remove these from the parfile, but if you want to check them please add the corresponding output files 2\. we aim to have the tests be as light-weight as possible; to that end, I’d suggest cutting down the number of iterations for the test to two or three scalar outputs two outputs would correspond to setting ``` Cactus::terminate = "iteration" Cactus::cctk_itlast = 512 ``` Changing this also means replacing all the files in `DNSdata/test/DNSdata_test` with the new output. Thanks for working with us on these changes. If the test fails on any machines, we will let you know. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Done. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Sorry, I didn’t notice you were outputting a statistics file. You should also remove the SystemStatistics variable from the IO in the parfile so the output generated by the test matches what’s in the test directory. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Should I simply remove this file? -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Roland Haas 07 Nov '23

07 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Roland Haas): The test fails on the test server: [https://einsteintoolkit.github.io/tests/build\_810.html](https://einsteinto… The reason is that the test data includes data from SystemStatistics which includes eg the amount of free memory. See the diff output linked on the webpage: [https://github.com/EinsteinToolkit/tests/blob/gh-pages/records/version\_810… Tests should not include data that will change each time, see eg [https://docs.einsteintoolkit.org/et-docs/Adding\_a\_test\_case](https://doc… for how a test should be structured. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Michal Pirog 06 Nov '23

06 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Michal Pirog): Done. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 03 Nov '23

03 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): You’ll also have to add the output files to the `DNSdata/test/DNSdata_test` directory. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2747: Inclusion of sgrid importer in Einstein Toolkit
by Samuel Cupp 03 Nov '23

03 Nov '23

#2747: Inclusion of sgrid importer in Einstein Toolkit Reporter: Samuel Cupp Status: open Milestone: ET_2023_11 Version: Type: enhancement Priority: major Component: EinsteinToolkit thorn Comment (by Samuel Cupp): Hi Michal. I was looking over your test. It runs fine on my machine, and we’ll mention here if any of the test runners experience a failure. One thing I would suggest is that you activate the scalar output. You can just set it to the last iteration \(currently 10\) ``` IOScalar::outScalar_every = 10 # every_coarse ``` Then, the test will validate not just that the code runs, but also that the results match. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2747/inclusion-of-sgri…

1 0

#2172: Test "Binary black hole GW150914" example
by Roland Haas 03 Nov '23

03 Nov '23

#2172: Test "Binary black hole GW150914" example Reporter: Roland Haas Status: open Milestone: ET_2023_11 Version: development version Type: task Priority: major Component: EinsteinToolkit website Changes (by Roland Haas): status: open (was resolved) -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2172/test-binary-black…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac