Trac

trac@lists.einsteintoolkit.org

8708 discussions

#2943: Formaline rejects valid symlinks in GRHayLib
by Zach Etienne 14 May '26

14 May '26

#2943: Formaline rejects valid symlinks in GRHayLib Reporter: Zach Etienne Status: new Milestone: Version: Type: bug Priority: major Component: Formaline emits warnings while creating/updating the configuration git repository when a thorn contains symbolic links, for example in `GRHayL/GRHayLib/src`: ```text Formaline: Creating configuration git repository... Formaline: Updating files in git repository... WARNING: Refusing to add "arrangements/GRHayL/GRHayLib/src/Neutrinos" as it is not a regular file at Cactus/configs/etbhahaha/scratch/Formaline/bin/update-git-repo.pl line 202, <STDIN> line 6246. ... fatal: bad revision 'HEAD' Formaline: Committing source tree to git repository... ``` The full set of warnings occurs for the symlinked `GRHayLib/src` entries such as `Neutrinos`, `Induction`, `Flux_Source`, `Reconstruction`, `Atmosphere`, `EOS`, `include`, `GRHayL_Core`, and `Con2Prim`. **Root Cause** `Formaline/src/util/update-git-repo.pl` currently accepts only regular files before adding paths to the Formaline git repository: ```perl if (! -e $file) { push @to_remove, $file; next; } elsif (! -f $file) { warn "WARNING: Refusing to add \"$file\" as it is not a regular file"; next; } ``` This rejects valid symbolic links, including symlinks to directories. The listed `GRHayLib/src/*` entries are symlinks, not broken paths, so they should be represented in the Formaline git snapshot instead of being skipped. Git represents symlinks as mode `120000` blobs containing the link target. Formaline’s fallback path already uses `git update-index --cacheinfo` when hard-link staging fails, so symlinks need corresponding handling there rather than being rejected by the regular-file check. **Fix Available** The issue is fixed by this pull request, which is ready for review: https://bitbucket.org/cactuscode/cactusutils/pull-requests/46 **Expected Behavior** Formaline should preserve valid symbolic links in its git source snapshot. Broken symlinks should still produce a warning. **Suggested Resolution** Review and merge: https://bitbucket.org/cactuscode/cactusutils/pull-requests/46 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2943/formaline-rejects…

1 0

#2942: Formaline: preserve symlinks in git source snapshots
by Roland Haas 14 May '26

14 May '26

#2942: Formaline: preserve symlinks in git source snapshots Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Please review. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2942/formaline-preserv…

1 0

#2942: Formaline: preserve symlinks in git source snapshots
by Roland Haas 14 May '26

14 May '26

#2942: Formaline: preserve symlinks in git source snapshots Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: Comment (by Roland Haas): Pull request is here: https://bitbucket.org/cactuscode/cactusutils/pull-requests/46 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2942/formaline-preserv…

1 0

#2942: Formaline: preserve symlinks in git source snapshots
by Roland Haas 14 May '26

14 May '26

#2942: Formaline: preserve symlinks in git source snapshots Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: major Component: @{557058:8bc23f2a-45c0-477d-8ac4-a5a16c734278} reports: Formaline currently warns and skips symbolic links when updating its git source snapshot because update-git-repo.pl only accepts regular files. This causes valid symlinks, including symlinks to directories, to be omitted from the stored source tree. Allow symbolic links through the existing file-type check. When the temporary hard-link staging tree can represent the symlink, the existing bulk git add path continues to handle it. If hard-link staging fails, add a symlink-specific fallback that writes the link target as a Git blob and stages it with mode 120000, which is Git's native representation for symbolic links. Broken symlinks are still refused with a warning and removed from the desired tracked set, matching the existing behavior for missing files while making the broken-link case explicit. The fallback path also avoids shell-quoting the Cactus filename directly by passing paths and link targets through environment variables before feeding them to `git hash-object / git update-index`. -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2942/formaline-preserv…

1 0

#2912: Inconsistent computation of the volume form in Coordinates (llama) between Thornburg04/13 and default behavior
by Jordan Nicoules 14 May '26

14 May '26

#2912: Inconsistent computation of the volume form in Coordinates (llama) between Thornburg04/13 and default behavior Reporter: Jordan Nicoules Status: open Milestone: Version: Type: bug Priority: major Component: EinsteinToolkit thorn Comment (by Jordan Nicoules): Submitted another Llama ticket to add/update tests in `Coordinates` : https://bitbucket.org/llamacode/llama/issues/7/add-test-of-the-volume-form-… -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2912/inconsistent-comp…

1 0

#7: Add test of the volume form in Coordinates
by Jordan Nicoules 14 May '26

14 May '26

#7: Add test of the volume form in Coordinates Reporter: Jordan Nicoules Status: submitted Milestone: Version: Type: enhancement Priority: major Component: I'm adding here suggestions of tests, to add to `Coordinates`, regarding the modification to the volume form https://bitbucket.org/llamacode/llama/pull-requests/10. I basically added the sum reduction of the volume form to the existing test, and made a second similar one for `Thornburg04nc`. There might be the need for a tolerance for the results. attachment: test.zip (https://api.bitbucket.org/2.0/repositories/llamacode/llama/issues/7/attachm…) -- Ticket URL: https://bitbucket.org/llamacode/llama/issues/7/add-test-of-the-volume-form-…

1 0

#6: Inconsistent computation of the volume form in Coordinates (llama) between Thornburg04/13 and default behavior
by Steven R. Brandt 14 May '26

14 May '26

#6: Inconsistent computation of the volume form in Coordinates (llama) between Thornburg04/13 and default behavior Reporter: Jordan Nicoules Status: submitted Milestone: Version: Type: bug Priority: major Component: Comment (by Steven R. Brandt): https://bitbucket.org/llamacode/llama/pull-requests/10 -- Ticket URL: https://bitbucket.org/llamacode/llama/issues/6/inconsistent-computation-of-…

1 0

#2939: AHFinderDirect: range options for track_origin_source_x/y/z
by Jordan Nicoules 14 May '26

14 May '26

#2939: AHFinderDirect: range options for track_origin_source_x/y/z Reporter: Jordan Nicoules Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Jordan Nicoules): The PR doesn't change the default value being `""` and matching anything, is that intended? Maybe I wasn't clear, what I meant was ``` string track_origin_source_x[101] "grid scalar containing the x component of the origin estimate" STEERABLE=recover { "None" :: "None" "[a-zA-Z_][a-zA-Z0-9_]*[:][:][a-zA-Z_][a-zA-Z0-9_]*(\[0-9+\])" :: "name of a grid scalar" } "None" ``` -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2939/ahfinderdirect-ra…

1 0

#2939: AHFinderDirect: range options for track_origin_source_x/y/z
by Steven R. Brandt 14 May '26

14 May '26

#2939: AHFinderDirect: range options for track_origin_source_x/y/z Reporter: Jordan Nicoules Status: new Milestone: Version: Type: bug Priority: minor Component: EinsteinToolkit thorn Comment (by Steven R. Brandt): https://bitbucket.org/einsteintoolkit/einsteinanalysis/pull-requests/26 -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2939/ahfinderdirect-ra…

1 0

#2940: CCE_Export: allow for changing array_size
by Roland Haas 12 May '26

12 May '26

#2940: CCE_Export: allow for changing array_size Reporter: Roland Haas Status: new Milestone: Version: Type: bug Priority: minor Component: Comment (by Roland Haas): Please review -- Ticket URL: https://bitbucket.org/einsteintoolkit/tickets/issues/2940/cce_export-allow-…

1 0

Jump to page:

2026

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

Trac